From: Bjorn Andersson <bjorn.andersson@linaro.org>
To: Douglas Anderson <dianders@chromium.org>
Cc: andy.gross@linaro.org, kramasub@codeaurora.org,
wsa@the-dreams.de, devicetree@vger.kernel.org,
linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org,
Rob Herring <robh+dt@kernel.org>,
David Brown <david.brown@linaro.org>,
Mark Rutland <mark.rutland@arm.com>,
linux-soc@vger.kernel.org
Subject: Re: [PATCH] dt-bindings: soc: qcom: Fix default clock-freq for qcom,geni-i2c
Date: Fri, 22 Jun 2018 09:51:35 -0700 [thread overview]
Message-ID: <20180622165135.GB25607@builder> (raw)
In-Reply-To: <20180613175011.217585-1-dianders@chromium.org>
On Wed 13 Jun 10:50 PDT 2018, Douglas Anderson wrote:
> In an early version of the I2C patch that was posted to the list the
> default I2C frequency (if none was specified) was 400 kHz. There was
> debate on the list and we decided that it would be more consistent
> with the rest of i2c if we defaulted to 100 kHz. ...but we never
> updated the bindings. Let's fix this.
>
> NOTE: since the i2c driver itself hasn't actually landed yet and the
> SoC here is very new it seems terribly unlikely that anyone was
> relying on the old 400 kHz number, so I'll assume this is an OK
> "incompatible" device tree change.
>
> Signed-off-by: Douglas Anderson <dianders@chromium.org>
Reviewed-by: Bjorn Andersson <bjorn.andersson@linaro.org>
Regards,
Bjorn
> ---
>
> Documentation/devicetree/bindings/soc/qcom/qcom,geni-se.txt | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/Documentation/devicetree/bindings/soc/qcom/qcom,geni-se.txt b/Documentation/devicetree/bindings/soc/qcom/qcom,geni-se.txt
> index d330c73de9a2..68b7d6207e3d 100644
> --- a/Documentation/devicetree/bindings/soc/qcom/qcom,geni-se.txt
> +++ b/Documentation/devicetree/bindings/soc/qcom/qcom,geni-se.txt
> @@ -39,7 +39,7 @@ Required properties:
>
> Optional property:
> - clock-frequency: Desired I2C bus clock frequency in Hz.
> - When missing default to 400000Hz.
> + When missing default to 100000Hz.
>
> Child nodes should conform to I2C bus binding as described in i2c.txt.
>
> --
> 2.18.0.rc1.244.gcf134e6275-goog
>
next prev parent reply other threads:[~2018-06-22 16:51 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-06-13 17:50 [PATCH] dt-bindings: soc: qcom: Fix default clock-freq for qcom,geni-i2c Douglas Anderson
2018-06-22 16:51 ` Bjorn Andersson [this message]
2018-06-23 15:16 ` Wolfram Sang
2018-06-26 19:24 ` Rob Herring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180622165135.GB25607@builder \
--to=bjorn.andersson@linaro.org \
--cc=andy.gross@linaro.org \
--cc=david.brown@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=dianders@chromium.org \
--cc=kramasub@codeaurora.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-soc@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=robh+dt@kernel.org \
--cc=wsa@the-dreams.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.