From: Jesper Dangaard Brouer <brouer@redhat.com>
To: Martin KaFai Lau <kafai@fb.com>
Cc: brouer@redhat.com, <dsahern@kernel.org>, <netdev@vger.kernel.org>,
<borkmann@iogearbox.net>, <ast@kernel.org>, <davem@davemloft.net>,
David Ahern <dsahern@gmail.com>
Subject: Re: [PATCH v2 bpf-net] bpf: Change bpf_fib_lookup to return lookup status
Date: Fri, 22 Jun 2018 17:49:14 +0200 [thread overview]
Message-ID: <20180622174914.1fec862e@redhat.com> (raw)
In-Reply-To: <20180621170936.2tobn5lu24l6xuo7@kafai-mbp.dhcp.thefacebook.com>
On Thu, 21 Jun 2018 10:09:36 -0700
Martin KaFai Lau <kafai@fb.com> wrote:
> On Wed, Jun 20, 2018 at 08:00:11PM -0700, dsahern@kernel.org wrote:
> > From: David Ahern <dsahern@gmail.com>
> >
> > For ACLs implemented using either FIB rules or FIB entries, the BPF
> > program needs the FIB lookup status to be able to drop the packet.
> > Since the bpf_fib_lookup API has not reached a released kernel yet,
> > change the return code to contain an encoding of the FIB lookup
> > result and return the nexthop device index in the params struct.
> >
> > In addition, inform the BPF program of any post FIB lookup reason as
> > to why the packet needs to go up the stack.
> >
> > The fib result for unicast routes must have an egress device, so remove
> > the check that it is non-NULL.
> Acked-by: Martin KaFai Lau <kafai@fb.com>
Acked-by: Jesper Dangaard Brouer <brouer@redhat.com>
--
Best regards,
Jesper Dangaard Brouer
MSc.CS, Principal Kernel Engineer at Red Hat
LinkedIn: http://www.linkedin.com/in/brouer
next prev parent reply other threads:[~2018-06-22 15:49 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-06-21 3:00 [PATCH v2 bpf-net] bpf: Change bpf_fib_lookup to return lookup status dsahern
2018-06-21 17:09 ` Martin KaFai Lau
2018-06-22 15:49 ` Jesper Dangaard Brouer [this message]
2018-06-26 9:50 ` Daniel Borkmann
2018-06-26 13:53 ` David Ahern
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180622174914.1fec862e@redhat.com \
--to=brouer@redhat.com \
--cc=ast@kernel.org \
--cc=borkmann@iogearbox.net \
--cc=davem@davemloft.net \
--cc=dsahern@gmail.com \
--cc=dsahern@kernel.org \
--cc=kafai@fb.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.