From: Brandon Williams <bmwill@google.com>
To: Antonio Ospite <ao2@ao2.it>
Cc: git@vger.kernel.org, Jonathan Nieder <jrnieder@gmail.com>,
Stefan Beller <sbeller@google.com>, Jeff King <peff@peff.net>
Subject: Re: [PATCH 0/7] Restrict the usage of config_from_gitmodules()
Date: Fri, 22 Jun 2018 14:13:03 -0700 [thread overview]
Message-ID: <20180622211303.GF244185@google.com> (raw)
In-Reply-To: <20180622223139.5fae4cc7d3c33128e28e81d3@ao2.it>
On 06/22, Antonio Ospite wrote:
> On Fri, 22 Jun 2018 10:13:10 -0700
> Brandon Williams <bmwill@google.com> wrote:
>
> [...]
> > Thanks for working on this. I think its a good approach and the end
> > result makes it much harder for arbitrary config to sneak back in to the
> > .gitmodules file. And after this series it looks like you should be in
> > a good place to read the .gitmodules file from other places (not just in
> > the worktree).
> >
>
> :)
>
> > As you've mentioned here I also agree we could do without the last patch
> > but I'll leave that up to you. Other than a couple typos I found I
> > think this series looks good! Thanks again for revisiting this.
> >
>
> Thanks for the review.
>
> I understand your compromise solution for patch 7, but I'd say let's
> keep it simple and just drop patch 7 for now.
Yeah that's probably the best approach for the time being.
>
> I am going to wait a couple of days and then send a v2.
Perfect, thanks again!
--
Brandon Williams
prev parent reply other threads:[~2018-06-22 21:13 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-06-22 16:26 [PATCH 0/7] Restrict the usage of config_from_gitmodules() Antonio Ospite
2018-06-22 16:26 ` [PATCH 1/7] config: move config_from_gitmodules to submodule-config.c Antonio Ospite
2018-06-22 16:26 ` [PATCH 2/7] submodule-config: add helper function to get 'fetch' config from .gitmodules Antonio Ospite
2018-06-22 16:50 ` Brandon Williams
2018-06-22 16:26 ` [PATCH 3/7] submodule-config: add helper to get 'update-clone' " Antonio Ospite
2018-06-22 16:51 ` Brandon Williams
2018-06-22 16:26 ` [PATCH 4/7] submodule-config: make 'config_from_gitmodules' private Antonio Ospite
2018-06-22 16:26 ` [PATCH 5/7] submodule-config: pass repository as argument to config_from_gitmodules Antonio Ospite
2018-06-22 16:26 ` [PATCH 6/7] submodule-config: reuse config_from_gitmodules in repo_read_gitmodules Antonio Ospite
2018-06-22 16:55 ` Brandon Williams
2018-06-22 16:26 ` [PATCH 7/7] submodule-config: cleanup backward compatibility helpers Antonio Ospite
2018-06-22 17:09 ` Brandon Williams
2018-06-22 17:13 ` [PATCH 0/7] Restrict the usage of config_from_gitmodules() Brandon Williams
2018-06-22 20:31 ` Antonio Ospite
2018-06-22 21:13 ` Brandon Williams [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180622211303.GF244185@google.com \
--to=bmwill@google.com \
--cc=ao2@ao2.it \
--cc=git@vger.kernel.org \
--cc=jrnieder@gmail.com \
--cc=peff@peff.net \
--cc=sbeller@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.