From: Al Viro <viro@ZenIV.linux.org.uk>
To: Amir Goldstein <amir73il@gmail.com>
Cc: Jan Kara <jack@suse.cz>, linux-fsdevel@vger.kernel.org
Subject: Re: [PATCH v4 1/5] fsnotify: use typedef fsnotify_connp_t for brevity
Date: Sat, 23 Jun 2018 22:13:41 +0100 [thread overview]
Message-ID: <20180623211341.GC30522@ZenIV.linux.org.uk> (raw)
In-Reply-To: <1529765691-25170-2-git-send-email-amir73il@gmail.com>
On Sat, Jun 23, 2018 at 05:54:47PM +0300, Amir Goldstein wrote:
> The object marks manipulation functions fsnotify_destroy_marks()
> fsnotify_find_mark() and their helpers take an argument of type
> struct fsnotify_mark_connector __rcu ** to dereference the connector
> pointer. use a typedef to describe this type for brevity.
That kind of typedefs is generally considered a bad style kernel-side...
next prev parent reply other threads:[~2018-06-23 21:13 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-06-23 14:54 [PATCH v4 0/5] Fsnotify cleanup - part 2 Amir Goldstein
2018-06-23 14:54 ` [PATCH v4 1/5] fsnotify: use typedef fsnotify_connp_t for brevity Amir Goldstein
2018-06-23 21:13 ` Al Viro [this message]
2018-06-24 7:29 ` Amir Goldstein
2018-06-25 10:18 ` Jan Kara
2018-06-23 14:54 ` [PATCH v4 2/5] fsnotify: pass connp and object type to fsnotify_add_mark() Amir Goldstein
2018-06-23 14:54 ` [PATCH v4 3/5] fsnotify: let connector point to an abstract object Amir Goldstein
2018-06-23 14:54 ` [PATCH v4 4/5] fsnotify: add helper to get mask from connector Amir Goldstein
2018-06-23 14:54 ` [PATCH v4 5/5] fanotify: factor out helpers to add/remove mark Amir Goldstein
2018-06-27 11:48 ` [PATCH v4 0/5] Fsnotify cleanup - part 2 Jan Kara
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180623211341.GC30522@ZenIV.linux.org.uk \
--to=viro@zeniv.linux.org.uk \
--cc=amir73il@gmail.com \
--cc=jack@suse.cz \
--cc=linux-fsdevel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.