tags

[tobin@apporbit.com (Tobin C. Harding)]

Hi,

A question relating to 'Acked-by:' and tags in general please.  Relates
to Documentation/process/submitting-patches.rst (sections 12 through 14).

For discussion, say a two patch series goes to version six and is then
applied to some maintainers tree.

On version three patch one of the series gets acked.  On version four
should patch one include the acked-by tag:

 - If patch one is unmodified?
 - If patch one is _trivially_ modified (update comment string etc)?

Finally, if version 6 (the version that is _correct_) gets an acked-by
on patch two does this final acked-by tag get included in the commit
log? The only two ways I can see this happening both seem wrong, hence
my question?

 - Developer submits another version with the tag.
 - Maintainer adds the tag when applying the series.


If the tag does not make its way into the commit log this implies that
the tag (and other tags?) are temporal and are mainly used by
maintainers at the time of merging patches?  Is this a fair comment?

However, from the documentation the 'Cc' tag is meant to keep a record
that a developer was included in the conversation and had opportunity to
comment but did not i.e. this tag is _not_ temporal but is a permanent
record.


Thanks in advance,
Tobin.