[v3] USB: serial: ftdi_sio: Add MTP NVM support

[Johan Hovold <johan@kernel.org>]

On Mon, Jun 25, 2018 at 10:35:31AM +0200, Loic Poulain wrote:
> Hi Andy,
> 
> On 25 June 2018 at 09:36, Andy Shevchenko <andy.shevchenko@gmail.com> wrote:
> > On Fri, Jun 22, 2018 at 5:22 PM, Loic Poulain <loic.poulain@linaro.org> wrote:

> >> +#define EEPROM_SZ_FTX 2048 /* cf FTDI AN_201 */
> >> +#define EEPROM_SZ_FT232RL 128  /* cf FTDI AN_121 */
> >
> > These defines looks too particular, shouldn't be this a part of driver
> > data / platform data / device properties?
> 
> I'm not sure where to move this since it depends on chip type which is
> detected at runtime. I don't think ftdi_sio_quirk is the right place.
> So maybe I could just skip the defines for now and come back to:
> 
> switch (priv->chip_type) {
>     case FTX:
>         nvmconf.size = SZ_2K;
>         break;
> ...

Yes, please do that. The EEPROM_SZ_ defines you added in this (?)
revision add no value.

Thanks,
Johan
---
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html