From: Miquel Raynal <miquel.raynal@bootlin.com>
To: Boris Brezillon <boris.brezillon@bootlin.com>
Cc: Richard Weinberger <richard@nod.at>,
linux-mtd@lists.infradead.org,
David Woodhouse <dwmw2@infradead.org>,
Brian Norris <computersforpeace@gmail.com>,
Marek Vasut <marek.vasut@gmail.com>
Subject: Re: [PATCH] mtd: rawnand: micron: Update ecc_stats.corrected
Date: Mon, 25 Jun 2018 14:35:57 +0200 [thread overview]
Message-ID: <20180625143557.29d52b59@xps13> (raw)
In-Reply-To: <20180620100444.4f60f8dd@bbrezillon>
Hi Boris,
On Wed, 20 Jun 2018 10:04:44 +0200, Boris Brezillon
<boris.brezillon@bootlin.com> wrote:
> On Wed, 20 Jun 2018 09:58:43 +0200
> Miquel Raynal <miquel.raynal@bootlin.com> wrote:
>
> > Hi Boris,
> >
> > On Wed, 20 Jun 2018 09:44:43 +0200, Boris Brezillon
> > <boris.brezillon@bootlin.com> wrote:
> >
> > > Even if we can't update ecc_stats.corrected with an accurate value we
> > > should at least increase the number of bitflips so that MTD users can
> > > know that there was some bitflips.
> > >
> > > Just add chip->ecc.strength to mtd->ecc_stats.corrected which should
> > > account for the worst case situation.
> > >
> > > Signed-off-by: Boris Brezillon <boris.brezillon@bootlin.com>
> > > ---
> >
> > Shouldn't we consider this change as a fix?
>
> It's not really fixing a bug, in that ecc_stats.corrected are already
> not accurate, they just give a hint about how often you fix bitflips
> on a NAND device. But if you think it should be backported, I can add
> the Fixes and Cc-stable tags.
>
It's fine for me.
Applied to nand/next.
Thanks,
Miquèl
prev parent reply other threads:[~2018-06-25 12:36 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-06-20 7:44 [PATCH] mtd: rawnand: micron: Update ecc_stats.corrected Boris Brezillon
2018-06-20 7:58 ` Miquel Raynal
2018-06-20 8:04 ` Boris Brezillon
2018-06-25 12:35 ` Miquel Raynal [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180625143557.29d52b59@xps13 \
--to=miquel.raynal@bootlin.com \
--cc=boris.brezillon@bootlin.com \
--cc=computersforpeace@gmail.com \
--cc=dwmw2@infradead.org \
--cc=linux-mtd@lists.infradead.org \
--cc=marek.vasut@gmail.com \
--cc=richard@nod.at \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.