From: Peter Zijlstra <peterz@infradead.org>
To: Mark Rutland <mark.rutland@arm.com>
Cc: linux-kernel@vger.kernel.org, will.deacon@arm.com,
boqun.feng@gmail.com, arnd@arndb.de, aryabinin@virtuozzo.com,
catalin.marinas@arm.com, dvyukov@google.com, glider@google.com,
hpa@zytor.com, linuxdrivers@attotech.com, mingo@redhat.com,
parri.andrea@gmail.com, peter@hurleysoftware.com,
tglx@linutronix.de
Subject: Re: [PATCHv2 00/11] atomics: generate atomic headers / instrument arm64
Date: Mon, 25 Jun 2018 17:22:59 +0200 [thread overview]
Message-ID: <20180625152259.GD2494@hirez.programming.kicks-ass.net> (raw)
In-Reply-To: <20180625105952.3756-1-mark.rutland@arm.com>
On Mon, Jun 25, 2018 at 11:59:41AM +0100, Mark Rutland wrote:
> That scripting comes to ~900 lines, and replaces ~1700 lines of hand-written
> boilerplate with ~4700 lines of generated code. Some of that increase in line
> count is due to filling in missing portions of the API (e.g. adding all the
> ordering variants to the instrumented atomics), while some of that is due to
> expanding fallbacks in place, and consistently spreading these across multiple
> lines.
> Mark Rutland (10):
> atomics/x86: reduce arch_cmpxchg64*() instrumentation
> atomics: simplify cmpxchg() instrumentation
> atomics/treewide: instrument xchg()
> atomics: instrument cmpxchg_double*()
> atomics/treewide: rework ordering barriers
> atomics: add common header generation files
> atomics: switch to generated fallbacks
> atomics: switch to generated atomic-long
> atomics: switch to generated instrumentation
> arm64: use instrumented atomics
Awesome work Mark, thanks for doing that!
Aside from the nitpicks I mentioned on IRC (mostly spelling and
Changelog inconsistencies),
Acked-by: Peter Zijlstra (Intel) <peterz@infradead.org>
prev parent reply other threads:[~2018-06-25 15:23 UTC|newest]
Thread overview: 35+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-06-25 10:59 [PATCHv2 00/11] atomics: generate atomic headers / instrument arm64 Mark Rutland
2018-06-25 10:59 ` [PATCHv2 01/11] atomic/tty: Fix up atomic abuse in ldsem Mark Rutland
2018-06-26 18:53 ` Andy Shevchenko
2018-06-26 19:30 ` Peter Zijlstra
2018-06-27 17:33 ` Andy Shevchenko
2018-06-25 10:59 ` [PATCHv2 02/11] atomics/x86: reduce arch_cmpxchg64*() instrumentation Mark Rutland
2018-06-25 10:59 ` [PATCHv2 03/11] atomics: simplify cmpxchg() instrumentation Mark Rutland
2018-06-25 11:38 ` Andrea Parri
2018-06-25 11:47 ` Dmitry Vyukov
2018-06-25 11:48 ` Mark Rutland
2018-06-25 10:59 ` [PATCHv2 04/11] atomics/treewide: instrument xchg() Mark Rutland
2018-06-25 10:59 ` [PATCHv2 05/11] atomics: instrument cmpxchg_double*() Mark Rutland
2018-06-25 10:59 ` [PATCHv2 06/11] atomics/treewide: rework ordering barriers Mark Rutland
2018-06-25 15:44 ` Mark Rutland
2018-07-04 15:06 ` Will Deacon
2018-07-04 15:56 ` Mark Rutland
2018-07-04 17:50 ` Will Deacon
2018-07-05 10:12 ` Mark Rutland
2018-07-05 16:25 ` Will Deacon
2018-06-25 10:59 ` [PATCHv2 07/11] atomics: add common header generation files Mark Rutland
2018-06-28 10:58 ` Mark Rutland
2018-06-28 11:46 ` Peter Zijlstra
2018-06-25 10:59 ` [PATCHv2 08/11] atomics: switch to generated fallbacks Mark Rutland
2018-07-04 15:28 ` Will Deacon
2018-07-04 16:01 ` Mark Rutland
2018-07-04 17:44 ` Will Deacon
2018-07-05 11:52 ` Mark Rutland
2018-06-25 10:59 ` [PATCHv2 09/11] atomics: switch to generated atomic-long Mark Rutland
2018-06-25 10:59 ` [PATCHv2 10/11] atomics: switch to generated instrumentation Mark Rutland
2018-06-25 10:59 ` [PATCHv2 11/11] arm64: use instrumented atomics Mark Rutland
2018-07-04 15:24 ` Will Deacon
2018-07-04 16:37 ` Mark Rutland
2018-07-04 17:41 ` Will Deacon
2018-07-05 9:58 ` Mark Rutland
2018-06-25 15:22 ` Peter Zijlstra [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180625152259.GD2494@hirez.programming.kicks-ass.net \
--to=peterz@infradead.org \
--cc=arnd@arndb.de \
--cc=aryabinin@virtuozzo.com \
--cc=boqun.feng@gmail.com \
--cc=catalin.marinas@arm.com \
--cc=dvyukov@google.com \
--cc=glider@google.com \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxdrivers@attotech.com \
--cc=mark.rutland@arm.com \
--cc=mingo@redhat.com \
--cc=parri.andrea@gmail.com \
--cc=peter@hurleysoftware.com \
--cc=tglx@linutronix.de \
--cc=will.deacon@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.