From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: by yocto-www.yoctoproject.org (Postfix, from userid 118) id 2B029E010C3; Mon, 25 Jun 2018 13:22:40 -0700 (PDT) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on yocto-www.yoctoproject.org X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,RCVD_IN_DNSWL_NONE autolearn=ham version=3.3.1 X-Spam-HAM-Report: * -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at http://www.dnswl.org/, no * trust * [209.85.128.194 listed in list.dnswl.org] * -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% * [score: 0.0000] * 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily * valid * -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature Received: from mail-wr0-f194.google.com (mail-wr0-f194.google.com [209.85.128.194]) by yocto-www.yoctoproject.org (Postfix) with ESMTP id 39D86E00E73 for ; Mon, 25 Jun 2018 13:22:39 -0700 (PDT) Received: by mail-wr0-f194.google.com with SMTP id h10-v6so14920075wrq.8 for ; Mon, 25 Jun 2018 13:22:38 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=boundarydevices-com.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=et2UAgcBUrNCJF0HkOlk1w/vS33rwMX8o31FgcMWFs4=; b=fDrNuaBFqXL3cMvGoi9A99jGBjTR7pkwgkJG6F1fl24ZKxc+iv0kvjqkrxoKeZ05sl I1oFe1aKMIcMu5nwRyrfaxTJzR6dhNJo4o7Ql8pYVwcIosjWfW3Y6m6Gv3YhYWor+LDk IBHYL0MBLRwKiP4MmjGDUh1Akz9QXyU5vAP6V0U3O4SAEgeRyHxMplcCwCTPgfT8ApHN 4o9pkedFylDFrgrX9y401cYvk8RQ9PWFjPQ/GIN0lk3WULRV3GFwcGEF750XkbnRTPgU h/7hAQURiTh9Oia4fGbdWOzVbATJJZSe8ojtD3h6ImWGw0tg+wktESAxdgfqsQ62a5nZ +8EA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=et2UAgcBUrNCJF0HkOlk1w/vS33rwMX8o31FgcMWFs4=; b=Ojs0rYNAhA7BPEkxNKf1Cr43qtH5vmHh62VzqUcBfPX34gteOt2f9CiLXHw73bodA9 nqaFF6gjoa32oOkhO+KMvE2iAX6NUYxCOdZzvwCSY4pZ9pSj9or7Evj2UJ2HFVLeJmdg vgr7D4cbFYGjTXKgG7Bp8XpZSuwdjUmNm1WmzwWbRRjes/BDCqFeeq0Q7sW2CZO9BlTq iBhcL5K7n8HbnoZvwquPEBo1KVfbgqd6rj9zW0zEwfWOqN2VkkIrUa2e+g3PJfG94lsS mSI0jKburCL3fZme2EEaIx/Yaa6ozbOpL6i0ivC2sGKRseOepPDvASNvIb6Yv1UfwJge ienQ== X-Gm-Message-State: APt69E36SIP+b82LfJQf1G5xjcmnXia/YdRdJBvZfGmPmHsCK+eo+nqW 6kJznmRS0DynUO1sOuC5wXvqrhy+ X-Google-Smtp-Source: AAOMgpcCDm/8VR1ItRbnbh7qYXxBrdRm4l5obMf7lM0QYY/+wdilPYuaW5EOcKFNFMaQ6ybhK0Yauw== X-Received: by 2002:adf:90af:: with SMTP id i44-v6mr7886750wri.146.1529958158253; Mon, 25 Jun 2018 13:22:38 -0700 (PDT) Received: from g751.home (2a01cb040a78e3003d608593cd48de0b.ipv6.abo.wanadoo.fr. [2a01:cb04:a78:e300:3d60:8593:cd48:de0b]) by smtp.gmail.com with ESMTPSA id u16-v6sm4171000wrp.44.2018.06.25.13.22.37 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Mon, 25 Jun 2018 13:22:37 -0700 (PDT) Date: Mon, 25 Jun 2018 22:22:32 +0200 From: Gary Bisson To: Otavio Salvador Message-ID: <20180625202232.GA13915@g751.home> References: <20180625193032.9248-1-otavio@ossystems.com.br> <20180625193032.9248-29-otavio@ossystems.com.br> MIME-Version: 1.0 In-Reply-To: <20180625193032.9248-29-otavio@ossystems.com.br> User-Agent: Mutt/1.10.0 (2018-05-17) Cc: meta-freescale Mailing List Subject: Re: [PATCH 29/32] imx-base.inc: Add i.MX 8M support X-BeenThere: meta-freescale@yoctoproject.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: Usage and development list for the meta-fsl-* layers List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 25 Jun 2018 20:22:40 -0000 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Hi Otavio, Tom, Glad to see this series reaching the mailing list. I have a few comments. First the title only mentions i.MX8M whereas the patch seems to also add i.MX8M Mini support, it'd be clearer to state both in the title. On Mon, Jun 25, 2018 at 04:30:29PM -0300, Otavio Salvador wrote: > From: Tom Hochstein > > Signed-off-by: Tom Hochstein > Signed-off-by: Otavio Salvador > --- > > conf/machine/include/imx-base.inc | 13 ++++++++++--- > 1 file changed, 10 insertions(+), 3 deletions(-) > > diff --git a/conf/machine/include/imx-base.inc b/conf/machine/include/imx-base.inc > index 419ab1bc..346d1c77 100644 > --- a/conf/machine/include/imx-base.inc > +++ b/conf/machine/include/imx-base.inc > @@ -30,9 +30,10 @@ UBOOT_ENTRYPOINT_mx7 = "0x80008000" > UBOOT_ENTRYPOINT_vf = "0x80008000" > > PREFERRED_PROVIDER_virtual/xserver = "xserver-xorg" > -XSERVER_DRIVER = "xf86-video-fbdev" > -XSERVER_DRIVER_imxgpu2d = "xf86-video-imx-vivante" > -XSERVER_DRIVER_vf = "xf86-video-modesetting" > +XSERVER_DRIVER = "xf86-video-fbdev" > +XSERVER_DRIVER_imxgpu2d = "xf86-video-imx-vivante" > +XSERVER_DRIVER_vf = "xf86-video-modesetting" > +XSERVER_DRIVER_append_mx8 = " xf86-video-modesetting" > XSERVER_DRIVER_use-mainline-bsp = "xf86-video-armada" > XSERVER = "xserver-xorg \ > xf86-input-evdev \ > @@ -52,6 +53,7 @@ DEFAULTTUNE_mx6 ?= "cortexa9thf-neon" > DEFAULTTUNE_mx6ul ?= "cortexa7thf-neon" > DEFAULTTUNE_mx6ull ?= "cortexa7thf-neon" > DEFAULTTUNE_mx7 ?= "cortexa7thf-neon" > +DEFAULTTUNE_mx8 ?= "aarch64" > DEFAULTTUNE_vf ?= "cortexa5thf-neon" > > INHERIT += "machine-overrides-extender" > @@ -66,6 +68,8 @@ MACHINEOVERRIDES_EXTENDER_mx6ul = "imxpxp" > MACHINEOVERRIDES_EXTENDER_mx6ull = "imxpxp:imxepdc" > MACHINEOVERRIDES_EXTENDER_mx7d = "imxpxp:imxepdc" > MACHINEOVERRIDES_EXTENDER_mx7ulp = "imxpxp:imxgpu2d:imxgpu3d" > +MACHINEOVERRIDES_EXTENDER_mx8mq = "imxvpu:imxgpu3d" > +MACHINEOVERRIDES_EXTENDER_mx8mm = "imxvpu:imxgpu2d:imxgpu3d" > > MACHINEOVERRIDES_EXTENDER_FILTER_OUT_use-mainline-bsp = " \ > mx6 \ > @@ -97,6 +101,8 @@ MACHINE_SOCARCH_SUFFIX_vf60 = "-vf60" > MACHINE_SOCARCH_SUFFIX_vf50 = "-vf50" > MACHINE_SOCARCH_SUFFIX_mx6ul = "-mx6ul" > MACHINE_SOCARCH_SUFFIX_mx6ull = "-mx6ul" > +MACHINE_SOCARCH_SUFFIX_mx8mm = "-mx8mm" > +MACHINE_SOCARCH_SUFFIX_mx8mq = "-mx8m" > MACHINE_SOCARCH_SUFFIX_use-mainline-bsp = "-imx" > > MACHINE_ARCH_FILTER = "virtual/kernel" > @@ -158,6 +164,7 @@ MACHINE_FIRMWARE_append_mx6sll = " firmware-imx-epdc" > MACHINE_FIRMWARE_append_mx6ull = " firmware-imx-epdc" > MACHINE_FIRMWARE_append_mx53 = " firmware-imx-vpu-imx53 firmware-imx-sdma-imx53" > MACHINE_FIRMWARE_append_mx51 = " firmware-imx-vpu-imx51 firmware-imx-sdma-imx51" > +MACHINE_FIRMWARE_append_mx8 = " linux-firmware-ath10k" Shouldn't this be board specific? Yes the EVK requires ath10k driver but it's not a CPU requirement. Regards, Gary