From mboxrd@z Thu Jan 1 00:00:00 1970 From: Daniel Vetter Subject: Re: [PATCH v6 1/2] drm/i915/psr: Lockless version of psr_wait_for_idle Date: Tue, 26 Jun 2018 10:26:57 +0200 Message-ID: <20180626082657.GV2958@phenom.ffwll.local> References: <20180626055724.167534-1-tarun.vyas@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mail-wm0-x242.google.com (mail-wm0-x242.google.com [IPv6:2a00:1450:400c:c09::242]) by gabe.freedesktop.org (Postfix) with ESMTPS id E2E526E4A2 for ; Tue, 26 Jun 2018 08:27:02 +0000 (UTC) Received: by mail-wm0-x242.google.com with SMTP id 69-v6so788882wmf.3 for ; Tue, 26 Jun 2018 01:27:02 -0700 (PDT) Content-Disposition: inline In-Reply-To: <20180626055724.167534-1-tarun.vyas@intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Tarun Vyas Cc: intel-gfx@lists.freedesktop.org, dhinakaran.pandiyan@intel.com, rodrigo.vivi@intel.com List-Id: intel-gfx@lists.freedesktop.org T24gTW9uLCBKdW4gMjUsIDIwMTggYXQgMTA6NTc6MjNQTSAtMDcwMCwgVGFydW4gVnlhcyB3cm90 ZToKPiBUaGlzIGlzIGEgbG9ja2xlc3MgdmVyc2lvbiBvZiB0aGUgZXhpc2l0aW5nIHBzcl93YWl0 X2Zvcl9pZGxlKCkuCj4gV2Ugd2FudCB0byB3YWl0IGZvciBQU1IgdG8gaWRsZSBvdXQgaW5zaWRl IGludGVsX3BpcGVfdXBkYXRlX3N0YXJ0Lgo+IEF0IHRoZSB0aW1lIG9mIGEgcGlwZSB1cGRhdGUs IHdlIHNob3VsZCBuZXZlciByYWNlIHdpdGggYW55IHBzcgo+IGVuYWJsZSBvciBkaXNhYmxlIGNv ZGUsIHdoaWNoIGlzIGEgcGFydCBvZiBjcnRjIGVuYWJsZS9kaXNhYmxlLiBTbywKPiB3ZSBjYW4g bGl2ZSB3L28gdGFraW5nIGFueSBwc3IgbG9ja3MgYXQgYWxsLgo+IFRoZSBmb2xsb3cgdXAgcGF0 Y2ggd2lsbCB1c2UgdGhpcyBsb2NrbGVzcyB3YWl0IGluc2lkZSBwaXBlX3VwZGF0ZV8KPiBzdGFy dCB0byB3YWl0IGZvciBQU1IgdG8gaWRsZSBvdXQgYmVmb3JlIGNoZWNraW5nIGZvciB2Ymxhbmsg ZXZhc2lvbi4KCldoYXQncyB0aGUgdXBzaWRlIG9mIHRoZSBsb2NrbGVzcyB3YWl0PyBUaGUgcGF0 Y2ggc2VlbXMgdG8gYmUgZW50aXJlbHkKbWlzc2luZyB0aGUgbW90aXZhdGlvbiBmb3IgdGhlIGNo YW5nZS4gIk1ha2UgaXQgbG9ja2xlc3MiIGlzbid0IGEgZ29vZApqdXN0aWZpY2F0aW9uIG9uIGl0 c2VsZiwgdGhlcmUgbmVlZHMgdG8gYmUgZGF0YSBhYm91dCBvdmVyaGVhZCBvciBzdGFsbHMKaW5j bHVkZWQgaWYgdGhhdCdzIHRoZSByZWFzb24gZm9yIGRvaW5nIHRoaXMgY2hhbmdlLgoKPiBFdmVu IGlmIHBzciBpcyBuZXZlciBlbmFibGVkLCBwc3IyX2VuYWJsZWQgd2lsbCBiZSBmYWxzZSBhbmQg dGhpcwo+IGZ1bmN0aW9uIHdpbGwgd2FpdCBmb3IgUFNSMSB0byBpZGxlIG91dCwgd2hpY2ggc2hv dWxkIGp1c3QgcmV0dXJuCj4gaW1tZWRpYXRlbHksIHNvIGEgdmVyeSBzaG9ydCAofjEtMiB1c2Vj KSB3YWl0IGZvciBjYXNlcyB3aGVyZSBQU1IKPiBpcyBkaXNhYmxlZC4KPiAKPiB2MjogQWRkIGNv bW1lbnQgdG8gZXhwbGFpbiB0aGUgMjVtc2VjIHRpbWVvdXQgKERLKQo+IAo+IHYzOiBSZW5hbWUg cHNyX3dhaXRfZm9yX2lkbGUgdG8gX19wc3Jfd2FpdF9mb3JfaWRsZV9sb2NrZWQgdG8gYXZvaWQK PiAgICAgbmFtaW5nIGNvbmZsaWN0cyBhbmQgcHJvcGFnYXRlIGVyciAoaWYgYW55KSB0byB0aGUg Y2FsbGVyIChDaHJpcykKPiAKPiB2NTogRm9ybSBhIHNlcmllcyB3aXRoIHRoZSBuZXh0IHBhdGNo Cj4gCj4gU2lnbmVkLW9mZi1ieTogVGFydW4gVnlhcyA8dGFydW4udnlhc0BpbnRlbC5jb20+Cj4g LS0tCj4gIGRyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2Rydi5oIHwgIDEgKwo+ICBkcml2ZXJz L2dwdS9kcm0vaTkxNS9pbnRlbF9wc3IuYyB8IDI1ICsrKysrKysrKysrKysrKysrKysrKysrLS0K PiAgMiBmaWxlcyBjaGFuZ2VkLCAyNCBpbnNlcnRpb25zKCspLCAyIGRlbGV0aW9ucygtKQo+IAo+ IGRpZmYgLS1naXQgYS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9kcnYuaCBiL2RyaXZlcnMv Z3B1L2RybS9pOTE1L2ludGVsX2Rydi5oCj4gaW5kZXggNTc4MzQ2YjhkN2UyLi45Y2IyYjhhZmRk M2UgMTAwNjQ0Cj4gLS0tIGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfZHJ2LmgKPiArKysg Yi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9kcnYuaAo+IEBAIC0xOTIwLDYgKzE5MjAsNyBA QCB2b2lkIGludGVsX3Bzcl9jb21wdXRlX2NvbmZpZyhzdHJ1Y3QgaW50ZWxfZHAgKmludGVsX2Rw LAo+ICAJCQkgICAgICBzdHJ1Y3QgaW50ZWxfY3J0Y19zdGF0ZSAqY3J0Y19zdGF0ZSk7Cj4gIHZv aWQgaW50ZWxfcHNyX2lycV9jb250cm9sKHN0cnVjdCBkcm1faTkxNV9wcml2YXRlICpkZXZfcHJp diwgYm9vbCBkZWJ1Zyk7Cj4gIHZvaWQgaW50ZWxfcHNyX2lycV9oYW5kbGVyKHN0cnVjdCBkcm1f aTkxNV9wcml2YXRlICpkZXZfcHJpdiwgdTMyIHBzcl9paXIpOwo+ICtpbnQgaW50ZWxfcHNyX3dh aXRfZm9yX2lkbGUoc3RydWN0IGRybV9pOTE1X3ByaXZhdGUgKmRldl9wcml2KTsKPiAgCj4gIC8q IGludGVsX3J1bnRpbWVfcG0uYyAqLwo+ICBpbnQgaW50ZWxfcG93ZXJfZG9tYWluc19pbml0KHN0 cnVjdCBkcm1faTkxNV9wcml2YXRlICopOwo+IGRpZmYgLS1naXQgYS9kcml2ZXJzL2dwdS9kcm0v aTkxNS9pbnRlbF9wc3IuYyBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX3Bzci5jCj4gaW5k ZXggYWVhODFhY2U4NTRiLi40MWU2OTYyOTIzYWUgMTAwNjQ0Cj4gLS0tIGEvZHJpdmVycy9ncHUv ZHJtL2k5MTUvaW50ZWxfcHNyLmMKPiArKysgYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9w c3IuYwo+IEBAIC03NTcsNyArNzU3LDI4IEBAIHZvaWQgaW50ZWxfcHNyX2Rpc2FibGUoc3RydWN0 IGludGVsX2RwICppbnRlbF9kcCwKPiAgCWNhbmNlbF93b3JrX3N5bmMoJmRldl9wcml2LT5wc3Iu d29yayk7Cj4gIH0KPiAgCj4gLXN0YXRpYyBib29sIHBzcl93YWl0X2Zvcl9pZGxlKHN0cnVjdCBk cm1faTkxNV9wcml2YXRlICpkZXZfcHJpdikKPiAraW50IGludGVsX3Bzcl93YWl0X2Zvcl9pZGxl KHN0cnVjdCBkcm1faTkxNV9wcml2YXRlICpkZXZfcHJpdikKPiArewo+ICsJaTkxNV9yZWdfdCBy ZWc7Cj4gKwl1MzIgbWFzazsKPiArCgpJIHRoaW5rIGEgY29tbWVudCBoZXJlIGV4cGxhaW5pbmcg d2h5IHRoZSBsb2NrbGVzcyBhY2Nlc3MgaXMgY29ycmVjdCBpcwpqdXN0aWZpZWQgaGVyZS4KCj4g KwlpZiAoZGV2X3ByaXYtPnBzci5wc3IyX2VuYWJsZWQpIHsKPiArCQlyZWcgPSBFRFBfUFNSMl9T VEFUVVM7Cj4gKwkJbWFzayA9IEVEUF9QU1IyX1NUQVRVU19TVEFURV9NQVNLOwo+ICsJfSBlbHNl IHsKPiArCQlyZWcgPSBFRFBfUFNSX1NUQVRVUzsKPiArCQltYXNrID0gRURQX1BTUl9TVEFUVVNf U1RBVEVfTUFTSzsKPiArCX0KPiArCj4gKwkvKgo+ICsJICogVGhlICAyNSBtc2VjIHRpbWVvdXQg YWNjb3VudHMgZm9yIGEgZnJhbWUgQCA2MEh6IHJlZnJlc2ggcmF0ZSwKPiArCSAqIGV4aXQgdHJh aW5pbmcgYW4gYXV4IGhhbmRzaGFrZSB0aW1lLgo+ICsJICovCgpTbyB0aGlzIGdvZXMgYm9vbSBp ZiB0aGUgcGFuZWwgaXMgcnVubmluZyBhdCBlLmcuIDUwSHo/IFBsZWFzZSBlaXRoZXIKY2FsY3Vs YXRlIHRoaXMgZnJvbSB0aGUgY3VycmVudCBtb2RlIChidXQgdGhhdCdzIGEgYml0IHRyaWNreSwg ZHVlIHRvCkRSUlMpLCBvciBnbyB3aXRoIGEgbW9yZSBkZWZlbnNpdmUgdGltZW91dC4gQWxzbyBz bWFsbCB0eXBvLCBzL2FuL2FuZC8uCgpXb3VsZCBhbHNvIGJlIGdvb2QgdG8gaGF2ZSBudW1iZXJz IGZvciB0aGUgZXhpdCB0cmFpbmluZy9hdXggaGFuZHNoYWtlCnRpbWUuCi1EYW5pZWwKCj4gKwly ZXR1cm4gaW50ZWxfd2FpdF9mb3JfcmVnaXN0ZXIoZGV2X3ByaXYsIHJlZywgbWFzaywKPiArCQkJ CSAgICAgICBFRFBfUFNSX1NUQVRVU19TVEFURV9JRExFLCAyNSk7Cj4gK30KPiArCj4gK3N0YXRp YyBib29sIF9fcHNyX3dhaXRfZm9yX2lkbGVfbG9ja2VkKHN0cnVjdCBkcm1faTkxNV9wcml2YXRl ICpkZXZfcHJpdikKPiAgewo+ICAJc3RydWN0IGludGVsX2RwICppbnRlbF9kcDsKPiAgCWk5MTVf cmVnX3QgcmVnOwo+IEBAIC04MDMsNyArODI0LDcgQEAgc3RhdGljIHZvaWQgaW50ZWxfcHNyX3dv cmsoc3RydWN0IHdvcmtfc3RydWN0ICp3b3JrKQo+ICAJICogUFNSIG1pZ2h0IHRha2Ugc29tZSB0 aW1lIHRvIGdldCBmdWxseSBkaXNhYmxlZAo+ICAJICogYW5kIGJlIHJlYWR5IGZvciByZS1lbmFi bGUuCj4gIAkgKi8KPiAtCWlmICghcHNyX3dhaXRfZm9yX2lkbGUoZGV2X3ByaXYpKQo+ICsJaWYg KCFfX3Bzcl93YWl0X2Zvcl9pZGxlX2xvY2tlZChkZXZfcHJpdikpCj4gIAkJZ290byB1bmxvY2s7 Cj4gIAo+ICAJLyoKPiAtLSAKPiAyLjEzLjUKPiAKPiBfX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fXwo+IEludGVsLWdmeCBtYWlsaW5nIGxpc3QKPiBJbnRlbC1n ZnhAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCj4gaHR0cHM6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcv bWFpbG1hbi9saXN0aW5mby9pbnRlbC1nZngKCi0tIApEYW5pZWwgVmV0dGVyClNvZnR3YXJlIEVu Z2luZWVyLCBJbnRlbCBDb3Jwb3JhdGlvbgpodHRwOi8vYmxvZy5mZndsbC5jaApfX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpJbnRlbC1nZnggbWFpbGluZyBs aXN0CkludGVsLWdmeEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKaHR0cHM6Ly9saXN0cy5mcmVlZGVz a3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9pbnRlbC1nZngK