From mboxrd@z Thu Jan 1 00:00:00 1970 From: Miquel Raynal Subject: Re: [PATCH v2 06/23] thermal: armada: convert driver to syscon register accesses Date: Tue, 26 Jun 2018 09:29:31 +0200 Message-ID: <20180626092931.7f0f0ad4@xps13> References: <20180625151239.20976-1-miquel.raynal@bootlin.com> <20180625151239.20976-7-miquel.raynal@bootlin.com> <20180626033724.q7radxgjeqtsl7ae@tarshish> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: <20180626033724.q7radxgjeqtsl7ae@tarshish> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=m.gmane.org@lists.infradead.org To: Baruch Siach Cc: Mark Rutland , Andrew Lunn , Jason Cooper , Nadav Haklai , devicetree@vger.kernel.org, Antoine Tenart , Catalin Marinas , Gregory Clement , linux-pm@vger.kernel.org, Will Deacon , Rob Herring , Maxime Chevallier , Eduardo Valentin , David Sniatkiwicz , Thomas Petazzoni , Zhang Rui , linux-arm-kernel@lists.infradead.org, Sebastian Hesselbarth List-Id: linux-pm@vger.kernel.org SGkgQmFydWNoLAoKT24gVHVlLCAyNiBKdW4gMjAxOCAwNjozNzoyNCArMDMwMCwgQmFydWNoIFNp YWNoIDxiYXJ1Y2hAdGtvcy5jby5pbD4Kd3JvdGU6Cgo+IEhpIE1pcXVlbCwKPiAKPiBPbiBNb24s IEp1biAyNSwgMjAxOCBhdCAwNToxMjoyMlBNICswMjAwLCBNaXF1ZWwgUmF5bmFsIHdyb3RlOgo+ ID4gVW50aWwgcmVjZW50bHksIG9ubHkgb25lIHJlZ2lzdGVyIHdhcyByZWZlcmVuY2VkIGluIE1W RUJVIHRoZXJtYWwgSVAKPiA+IG5vZGUuIFJlY2VudCBjaGFuZ2VzIGFkZGVkIGEgc2Vjb25kIGVu dHJ5IHBvaW50aW5nIHRvIGFub3RoZXIKPiA+IHJlZ2lzdGVyIHJpZ2h0IG5leHQgdG8gaXQuIFdl IGNhbm5vdCBrbm93IGZvciBzdXJlIHRoYXQgd2Ugd2lsbCBub3QKPiA+IGhhdmUgdG8gYWNjZXNz IG90aGVyIHJlZ2lzdGVycy4gVGhhdCB3aWxsIGJlIGFjdHVhbGx5IHRoZSBjYXNlIHdoZW4KPiA+ IG92ZXJoZWF0IGludGVycnVwdCBmZWF0dXJlIHdpbGwgY29tZSwgd2hlcmUgaXQgd2lsbCBiZSBu ZWVkZWQgdG8gYWNjZXNzCj4gPiBERlggcmVnaXN0ZXJzIGluIHRoZSBzYW1lIGFyZWEuCj4gPiAK PiA+IFRoaXMgYXBwcm9hY2ggaXMgbm90IHNjYWxhYmxlIHNvIGludGVhZCBvZiBhZGRpbmcgY29u c2ludW91c2x5IG1lbW9yeQo+ID4gYXJlYXMgaW4gdGhlIERUIChhbmQgY2hhbmdlIGRlIERUIGJp bmRpbmdzLCB3aGlsZSBrZWVwaW5nIGJhY2t3YXJkICAKPiAKPiBzL2RlL3RoZS8KCk9oIGFuZCBz L2ludGVhZC9pbnN0ZWFkLyB0b28uCgpUaGFua3MgZm9yIHBvaW50aW5nIGl0LApNaXF1w6hsCgpf X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpsaW51eC1hcm0t a2VybmVsIG1haWxpbmcgbGlzdApsaW51eC1hcm0ta2VybmVsQGxpc3RzLmluZnJhZGVhZC5vcmcK aHR0cDovL2xpc3RzLmluZnJhZGVhZC5vcmcvbWFpbG1hbi9saXN0aW5mby9saW51eC1hcm0ta2Vy bmVsCg== From mboxrd@z Thu Jan 1 00:00:00 1970 From: miquel.raynal@bootlin.com (Miquel Raynal) Date: Tue, 26 Jun 2018 09:29:31 +0200 Subject: [PATCH v2 06/23] thermal: armada: convert driver to syscon register accesses In-Reply-To: <20180626033724.q7radxgjeqtsl7ae@tarshish> References: <20180625151239.20976-1-miquel.raynal@bootlin.com> <20180625151239.20976-7-miquel.raynal@bootlin.com> <20180626033724.q7radxgjeqtsl7ae@tarshish> Message-ID: <20180626092931.7f0f0ad4@xps13> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org Hi Baruch, On Tue, 26 Jun 2018 06:37:24 +0300, Baruch Siach wrote: > Hi Miquel, > > On Mon, Jun 25, 2018 at 05:12:22PM +0200, Miquel Raynal wrote: > > Until recently, only one register was referenced in MVEBU thermal IP > > node. Recent changes added a second entry pointing to another > > register right next to it. We cannot know for sure that we will not > > have to access other registers. That will be actually the case when > > overheat interrupt feature will come, where it will be needed to access > > DFX registers in the same area. > > > > This approach is not scalable so intead of adding consinuously memory > > areas in the DT (and change de DT bindings, while keeping backward > > s/de/the/ Oh and s/intead/instead/ too. Thanks for pointing it, Miqu?l