From: Flavio Leitner <fbl@redhat.com>
To: Eric Dumazet <eric.dumazet@gmail.com>
Cc: Cong Wang <xiyou.wangcong@gmail.com>,
Linux Kernel Network Developers <netdev@vger.kernel.org>,
Paolo Abeni <pabeni@redhat.com>,
David Miller <davem@davemloft.net>,
Florian Westphal <fw@strlen.de>,
NetFilter <netfilter-devel@vger.kernel.org>
Subject: Re: [PATCH net-next] net: preserve sock reference when scrubbing the skb.
Date: Tue, 26 Jun 2018 09:38:05 -0300 [thread overview]
Message-ID: <20180626123805.GK19565@plex.lan> (raw)
In-Reply-To: <48e15faf-f935-0166-e1db-18f7286e7264@gmail.com>
On Mon, Jun 25, 2018 at 11:41:05PM -0700, Eric Dumazet wrote:
> I am not sure why the patch is so complex, I would have simply
> removed the skb_orphan().
All the rest is fixing netfilter to consider the namespaces before
doing any actions. For instance, it would be possible to dump GID/UID
of the process originating the packet in a foreign net namespace.
Another example is matching if it has a socket or not. I don't think
it's correct to match on a socket that is on a foreign netns.
So, you're right that removing the skb_orphan() is the only thing
required to fix both issues, but then what about the above examples?
--
Flavio
next prev parent reply other threads:[~2018-06-26 12:38 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-06-25 15:56 [PATCH net-next] net: preserve sock reference when scrubbing the skb Flavio Leitner
2018-06-26 4:15 ` Cong Wang
2018-06-26 6:41 ` Eric Dumazet
2018-06-26 12:38 ` Flavio Leitner [this message]
2018-06-26 13:06 ` Eric Dumazet
2018-06-26 13:32 ` Flavio Leitner
2018-06-26 21:48 ` Cong Wang
2018-06-26 22:03 ` Flavio Leitner
2018-06-26 22:47 ` Cong Wang
2018-06-26 23:33 ` Flavio Leitner
2018-06-27 0:29 ` Cong Wang
2018-06-27 0:39 ` Flavio Leitner
2018-06-27 1:28 ` Cong Wang
2018-06-27 12:31 ` Flavio Leitner
2018-06-27 19:06 ` Cong Wang
2018-06-27 20:19 ` Flavio Leitner
2018-06-28 21:51 ` Cong Wang
2018-06-27 2:32 ` Eric Dumazet
2018-06-26 23:53 ` Eric Dumazet
2018-06-27 0:44 ` Cong Wang
2018-06-27 2:35 ` Eric Dumazet
2018-06-27 18:59 ` Cong Wang
2018-06-27 19:33 ` Eric Dumazet
2018-06-27 19:55 ` Cong Wang
2018-06-28 23:18 ` Cong Wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180626123805.GK19565@plex.lan \
--to=fbl@redhat.com \
--cc=davem@davemloft.net \
--cc=eric.dumazet@gmail.com \
--cc=fw@strlen.de \
--cc=netdev@vger.kernel.org \
--cc=netfilter-devel@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=xiyou.wangcong@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.