From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ville =?iso-8859-1?Q?Syrj=E4l=E4?= Subject: Re: [PATCH] drm/gma500: Fix compile warning Date: Tue, 26 Jun 2018 16:28:28 +0300 Message-ID: <20180626132828.GY20518@intel.com> References: <20180625123355.GA16757@embeddedor.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by gabe.freedesktop.org (Postfix) with ESMTPS id 637A689FA7 for ; Tue, 26 Jun 2018 13:28:47 +0000 (UTC) Content-Disposition: inline In-Reply-To: <20180625123355.GA16757@embeddedor.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: "Gustavo A. R. Silva" Cc: David Airlie , dri-devel@lists.freedesktop.org, Daniel Stone , linux-kernel@vger.kernel.org List-Id: dri-devel@lists.freedesktop.org T24gTW9uLCBKdW4gMjUsIDIwMTggYXQgMDc6MzM6NTVBTSAtMDUwMCwgR3VzdGF2byBBLiBSLiBT aWx2YSB3cm90ZToKPiBGaXggdGhlIGZvbGxvd2luZyBjb21waWxlIHdhcm5pbmc6Cj4gCj4gd2Fy bmluZzogdW51c2VkIHZhcmlhYmxlIOKAmHBzYmZi4oCZIFstV3VudXNlZC12YXJpYWJsZV0KPiAg IHN0cnVjdCBwc2JfZnJhbWVidWZmZXIgKnBzYmZiID0gdG9fcHNiX2ZiKGZiKTsKPiAKPiBGaXhl czogYzdjYmVkNTYwY2UyICgiZHJtL2dtYTUwMDogRml4IE1lZGZpZWxkIGZvciBkcm1fZnJhbWVi dWZmZXIgbW92ZSIpCj4gU2lnbmVkLW9mZi1ieTogR3VzdGF2byBBLiBSLiBTaWx2YSA8Z3VzdGF2 b0BlbWJlZGRlZG9yLmNvbT4KCkkgc2VudCB0aGUgc2FtZSBwYXRjaCBhIGZldyBkYXlzIGFnby4g SW5zdGVhZCBvZiBodW50aW5nIGZvciBhbiByLWIKSSBqdXN0IHdlbnQgYWhlYWQgYW5kIHB1c2hl ZCB5b3VyIHZlcnNpb24uIFRoYW5rcyBmb3IgdGhlIHBhdGNoLgoKPiAtLS0KPiAgZHJpdmVycy9n cHUvZHJtL2dtYTUwMC9tZGZsZF9pbnRlbF9kaXNwbGF5LmMgfCAxIC0KPiAgMSBmaWxlIGNoYW5n ZWQsIDEgZGVsZXRpb24oLSkKPiAKPiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9ncHUvZHJtL2dtYTUw MC9tZGZsZF9pbnRlbF9kaXNwbGF5LmMgYi9kcml2ZXJzL2dwdS9kcm0vZ21hNTAwL21kZmxkX2lu dGVsX2Rpc3BsYXkuYwo+IGluZGV4IDg4MWQ2MTMuLjJiOWZhMDEgMTAwNjQ0Cj4gLS0tIGEvZHJp dmVycy9ncHUvZHJtL2dtYTUwMC9tZGZsZF9pbnRlbF9kaXNwbGF5LmMKPiArKysgYi9kcml2ZXJz L2dwdS9kcm0vZ21hNTAwL21kZmxkX2ludGVsX2Rpc3BsYXkuYwo+IEBAIC0xNjcsNyArMTY3LDYg QEAgc3RhdGljIGludCBtZGZsZF9faW50ZWxfcGlwZV9zZXRfYmFzZShzdHJ1Y3QgZHJtX2NydGMg KmNydGMsIGludCB4LCBpbnQgeSwKPiAgCXN0cnVjdCBkcm1fcHNiX3ByaXZhdGUgKmRldl9wcml2 ID0gZGV2LT5kZXZfcHJpdmF0ZTsKPiAgCXN0cnVjdCBkcm1fZnJhbWVidWZmZXIgKmZiID0gY3J0 Yy0+cHJpbWFyeS0+ZmI7Cj4gIAlzdHJ1Y3QgZ21hX2NydGMgKmdtYV9jcnRjID0gdG9fZ21hX2Ny dGMoY3J0Yyk7Cj4gLQlzdHJ1Y3QgcHNiX2ZyYW1lYnVmZmVyICpwc2JmYiA9IHRvX3BzYl9mYihm Yik7Cj4gIAlpbnQgcGlwZSA9IGdtYV9jcnRjLT5waXBlOwo+ICAJY29uc3Qgc3RydWN0IHBzYl9v ZmZzZXQgKm1hcCA9ICZkZXZfcHJpdi0+cmVnbWFwW3BpcGVdOwo+ICAJdW5zaWduZWQgbG9uZyBz dGFydCwgb2Zmc2V0Owo+IC0tIAo+IDIuNy40Cj4gCj4gX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX18KPiBkcmktZGV2ZWwgbWFpbGluZyBsaXN0Cj4gZHJpLWRl dmVsQGxpc3RzLmZyZWVkZXNrdG9wLm9yZwo+IGh0dHBzOi8vbGlzdHMuZnJlZWRlc2t0b3Aub3Jn L21haWxtYW4vbGlzdGluZm8vZHJpLWRldmVsCgotLSAKVmlsbGUgU3lyasOkbMOkCkludGVsCl9f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCmRyaS1kZXZlbCBt YWlsaW5nIGxpc3QKZHJpLWRldmVsQGxpc3RzLmZyZWVkZXNrdG9wLm9yZwpodHRwczovL2xpc3Rz LmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2RyaS1kZXZlbAo= From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_PASS,URIBL_BLOCKED,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4AAB5C43142 for ; Tue, 26 Jun 2018 13:28:51 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 112FD2683E for ; Tue, 26 Jun 2018 13:28:51 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 112FD2683E Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linux.intel.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S965560AbeFZN2t (ORCPT ); Tue, 26 Jun 2018 09:28:49 -0400 Received: from mga11.intel.com ([192.55.52.93]:4117 "EHLO mga11.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S965544AbeFZN2r (ORCPT ); Tue, 26 Jun 2018 09:28:47 -0400 X-Amp-Result: UNKNOWN X-Amp-Original-Verdict: FILE UNKNOWN X-Amp-File-Uploaded: False Received: from orsmga006.jf.intel.com ([10.7.209.51]) by fmsmga102.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 26 Jun 2018 06:28:46 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.51,274,1526367600"; d="scan'208";a="53003094" Received: from stinkbox.fi.intel.com (HELO stinkbox) ([10.237.72.174]) by orsmga006.jf.intel.com with SMTP; 26 Jun 2018 06:28:28 -0700 Received: by stinkbox (sSMTP sendmail emulation); Tue, 26 Jun 2018 16:28:28 +0300 Date: Tue, 26 Jun 2018 16:28:28 +0300 From: Ville =?iso-8859-1?Q?Syrj=E4l=E4?= To: "Gustavo A. R. Silva" Cc: Patrik Jakobsson , David Airlie , Daniel Stone , linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org Subject: Re: [PATCH] drm/gma500: Fix compile warning Message-ID: <20180626132828.GY20518@intel.com> References: <20180625123355.GA16757@embeddedor.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20180625123355.GA16757@embeddedor.com> User-Agent: Mutt/1.9.4 (2018-02-28) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Jun 25, 2018 at 07:33:55AM -0500, Gustavo A. R. Silva wrote: > Fix the following compile warning: > > warning: unused variable ‘psbfb’ [-Wunused-variable] > struct psb_framebuffer *psbfb = to_psb_fb(fb); > > Fixes: c7cbed560ce2 ("drm/gma500: Fix Medfield for drm_framebuffer move") > Signed-off-by: Gustavo A. R. Silva I sent the same patch a few days ago. Instead of hunting for an r-b I just went ahead and pushed your version. Thanks for the patch. > --- > drivers/gpu/drm/gma500/mdfld_intel_display.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/drivers/gpu/drm/gma500/mdfld_intel_display.c b/drivers/gpu/drm/gma500/mdfld_intel_display.c > index 881d613..2b9fa01 100644 > --- a/drivers/gpu/drm/gma500/mdfld_intel_display.c > +++ b/drivers/gpu/drm/gma500/mdfld_intel_display.c > @@ -167,7 +167,6 @@ static int mdfld__intel_pipe_set_base(struct drm_crtc *crtc, int x, int y, > struct drm_psb_private *dev_priv = dev->dev_private; > struct drm_framebuffer *fb = crtc->primary->fb; > struct gma_crtc *gma_crtc = to_gma_crtc(crtc); > - struct psb_framebuffer *psbfb = to_psb_fb(fb); > int pipe = gma_crtc->pipe; > const struct psb_offset *map = &dev_priv->regmap[pipe]; > unsigned long start, offset; > -- > 2.7.4 > > _______________________________________________ > dri-devel mailing list > dri-devel@lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/dri-devel -- Ville Syrjälä Intel