From mboxrd@z Thu Jan 1 00:00:00 1970 From: Mike Snitzer Subject: Re: [PATCH v3 1/3] pmem: only set QUEUE_FLAG_DAX for fsdax mode Date: Tue, 26 Jun 2018 14:58:30 -0400 Message-ID: <20180626185830.GA7171@redhat.com> References: <20180626175932.8899-1-ross.zwisler@linux.intel.com> <20180626175932.8899-2-ross.zwisler@linux.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: Sender: stable-owner@vger.kernel.org To: Dan Williams Cc: Ross Zwisler , Toshi Kani , device-mapper development , linux-nvdimm , Linux Kernel Mailing List , stable , linux-xfs , linux-fsdevel List-Id: dm-devel.ids On Tue, Jun 26 2018 at 2:52pm -0400, Dan Williams wrote: > On Tue, Jun 26, 2018 at 10:59 AM, Ross Zwisler > wrote: > > QUEUE_FLAG_DAX is an indication that a given block device supports > > filesystem DAX and should not be set for PMEM namespaces which are in "raw" > > or "sector" modes. These namespaces lack struct page and are prevented > > from participating in filesystem DAX. > > > > Signed-off-by: Ross Zwisler > > Suggested-by: Mike Snitzer > > Cc: stable@vger.kernel.org > > Why is this cc: stable? What is the user visible impact of this change > especially given the requirement to validate QUEUE_FLAG_DAX with > bdev_dax_supported()? Patch looks good, but it's just a cosmetic fixup > afaics. This isn't cosmetic when you consider that stacking up a DM device is looking at this flag to determine whether a table does or does _not_ support DAX. So this patch, in conjunction with the other changes in the series, is certainly something I'd consider appropriate for stable. Mike From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx1.redhat.com (mx3-rdu2.redhat.com [66.187.233.73]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 59218202E53DF for ; Tue, 26 Jun 2018 11:58:33 -0700 (PDT) Date: Tue, 26 Jun 2018 14:58:30 -0400 From: Mike Snitzer Subject: Re: [PATCH v3 1/3] pmem: only set QUEUE_FLAG_DAX for fsdax mode Message-ID: <20180626185830.GA7171@redhat.com> References: <20180626175932.8899-1-ross.zwisler@linux.intel.com> <20180626175932.8899-2-ross.zwisler@linux.intel.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: linux-nvdimm-bounces@lists.01.org Sender: "Linux-nvdimm" To: Dan Williams Cc: linux-nvdimm , Linux Kernel Mailing List , stable , linux-xfs , device-mapper development , linux-fsdevel List-ID: On Tue, Jun 26 2018 at 2:52pm -0400, Dan Williams wrote: > On Tue, Jun 26, 2018 at 10:59 AM, Ross Zwisler > wrote: > > QUEUE_FLAG_DAX is an indication that a given block device supports > > filesystem DAX and should not be set for PMEM namespaces which are in "raw" > > or "sector" modes. These namespaces lack struct page and are prevented > > from participating in filesystem DAX. > > > > Signed-off-by: Ross Zwisler > > Suggested-by: Mike Snitzer > > Cc: stable@vger.kernel.org > > Why is this cc: stable? What is the user visible impact of this change > especially given the requirement to validate QUEUE_FLAG_DAX with > bdev_dax_supported()? Patch looks good, but it's just a cosmetic fixup > afaics. This isn't cosmetic when you consider that stacking up a DM device is looking at this flag to determine whether a table does or does _not_ support DAX. So this patch, in conjunction with the other changes in the series, is certainly something I'd consider appropriate for stable. Mike _______________________________________________ Linux-nvdimm mailing list Linux-nvdimm@lists.01.org https://lists.01.org/mailman/listinfo/linux-nvdimm