From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.4 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_PASS, URIBL_BLOCKED,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C0A3EC43144 for ; Tue, 26 Jun 2018 19:38:15 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 4570A26E05 for ; Tue, 26 Jun 2018 19:38:15 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=lunn.ch header.i=@lunn.ch header.b="0FKi9V+6" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 4570A26E05 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=lunn.ch Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754844AbeFZTiN (ORCPT ); Tue, 26 Jun 2018 15:38:13 -0400 Received: from vps0.lunn.ch ([185.16.172.187]:43728 "EHLO vps0.lunn.ch" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752147AbeFZTiL (ORCPT ); Tue, 26 Jun 2018 15:38:11 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lunn.ch; s=20171124; h=In-Reply-To:Content-Type:MIME-Version:References:Message-ID:Subject:Cc:To:From:Date; bh=3NLBw74Tb7e9Icka9Y0s7C/SNJsVScBTC5dPAQCa0Ck=; b=0FKi9V+6j7tJhgfaZI/JWYKu5Nlue3kXND7mLpxUvR9YpMRmE1Uxcq4+lINEah4qETXIzGsoTM8sVJvpw8lF3rnLhkm7f4f+atYr9cC3T4jFOLPKXn7Nidpgak1UiWc3t98ceot49DMFgbWvDSTuInQ5JQOQg/wTm4OJbITJmJ8=; Received: from andrew by vps0.lunn.ch with local (Exim 4.84_2) (envelope-from ) id 1fXtmx-0004Kr-Ef; Tue, 26 Jun 2018 21:38:07 +0200 Date: Tue, 26 Jun 2018 21:38:07 +0200 From: Andrew Lunn To: Brandon Maier Cc: netdev@vger.kernel.org, f.fainelli@gmail.com, davem@davemloft.net, michal.simek@xilinx.com, clayton.shotwell@rockwellcollins.com, kristopher.cory@rockwellcollins.com, linux-kernel@vger.kernel.org Subject: Re: [PATCH net-next v2 3/3] net: phy: xgmiitorgmii: Check read_status results Message-ID: <20180626193807.GE9800@lunn.ch> References: <20180626175050.71165-1-brandon.maier@rockwellcollins.com> <20180626175050.71165-3-brandon.maier@rockwellcollins.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20180626175050.71165-3-brandon.maier@rockwellcollins.com> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Jun 26, 2018 at 12:50:50PM -0500, Brandon Maier wrote: > We're ignoring the result of the attached phy device's read_status(). > Return it so we can detect errors. > > Signed-off-by: Brandon Maier Reviewed-by: Andrew Lunn Andrew