From: Omar Sandoval <osandov@osandov.com>
To: Bart Van Assche <bart.vanassche@wdc.com>
Cc: Johannes Thumshirn <jthumshirn@suse.de>,
Omar Sandoval <osandov@fb.com>,
"linux-block@vger.kernel.org" <linux-block@vger.kernel.org>
Subject: Re: [PATCH blktests 15/15] Add tests for the SRP initiator and target drivers
Date: Tue, 26 Jun 2018 14:01:30 -0700 [thread overview]
Message-ID: <20180626210130.GF1218@vader> (raw)
In-Reply-To: <eed94957-58cd-3fe0-3447-a1d97cd0b9a9@wdc.com>
On Tue, Jun 26, 2018 at 08:25:40AM -0700, Bart Van Assche wrote:
> On 06/26/18 01:58, Johannes Thumshirn wrote:
> > On Fri, Jun 22, 2018 at 03:19:46PM -0700, Bart Van Assche wrote:
> > > tests/srp/functions | 1288 +++++++++++++++++++++++++++++++++++++++++++
> >
> > Can you please move these into common/srp?
>
> Let's do that once other tests than those in tests/srp need one or more of
> the functions defined in that file.
>
> Bart.
I moved things around just now to accomodate this sort of thing.
tests/foo/group is now tests/foo/rc, and that's where group-specific
functions should go, in addition to the group_requires() and
group_device_requires() definitions.
next prev parent reply other threads:[~2018-06-26 21:01 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-06-22 22:19 [PATCH blktests 00/15] Add SRP initiator driver tests Bart Van Assche
2018-06-22 22:19 ` [PATCH blktests 01/15] common/rc: Fix _have_tracepoint() Bart Van Assche
2018-06-22 22:19 ` [PATCH blktests 02/15] Annotate include statements in shell scripts where the source file is a variable Bart Van Assche
2018-06-22 22:19 ` [PATCH blktests 03/15] check, tests/meta/012: Use array["index"] instead of array[index] Bart Van Assche
2018-06-22 22:19 ` [PATCH blktests 04/15] Suppress shellcheck complaints about global variables Bart Van Assche
2018-06-22 22:19 ` [PATCH blktests 05/15] check: Avoid that shellcheck complains that $FULL appears unused Bart Van Assche
2018-06-22 22:19 ` [PATCH blktests 06/15] Multiple tests: remove unused and undefined variables Bart Van Assche
2018-06-22 22:19 ` [PATCH blktests 07/15] Avoid passing tests/block/002 arguments to _init_scsi_debug Bart Van Assche
2018-06-22 22:19 ` [PATCH blktests 08/15] check: Suppress a shellcheck warning about the DMESG_FILTER initialization Bart Van Assche
2018-06-22 22:19 ` [PATCH blktests 09/15] Makefile: Do not suppress useful shellcheck warnings Bart Van Assche
2018-06-22 22:19 ` [PATCH blktests 10/15] tests/meta/group: Fix shellcheck complaints Bart Van Assche
2018-06-22 22:19 ` [PATCH blktests 11/15] make check: Also check tests/*/group files Bart Van Assche
2018-06-22 22:19 ` [PATCH blktests 12/15] check: Make TMPDIR absolute Bart Van Assche
2018-06-22 22:19 ` [PATCH blktests 13/15] src/Makefile: Fix pattern rule Bart Van Assche
2018-06-25 22:54 ` Omar Sandoval
2018-06-22 22:19 ` [PATCH blktests 14/15] Add the discontiguous-io test program Bart Van Assche
2018-06-22 22:19 ` [PATCH blktests 15/15] Add tests for the SRP initiator and target drivers Bart Van Assche
2018-06-26 8:57 ` Johannes Thumshirn
2018-06-26 15:25 ` Bart Van Assche
2018-06-26 21:01 ` Omar Sandoval [this message]
2018-06-23 3:14 ` [PATCH blktests 00/15] Add SRP initiator driver tests Ming Lei
2018-06-23 3:19 ` Ming Lei
2018-06-25 17:05 ` Bart Van Assche
2018-06-26 1:37 ` Ming Lei
2018-06-26 2:16 ` Bart Van Assche
2018-06-26 7:27 ` Johannes Thumshirn
2018-06-26 15:24 ` Bart Van Assche
2018-06-26 21:00 ` Omar Sandoval
2018-06-27 7:04 ` Johannes Thumshirn
2018-06-26 21:02 ` Omar Sandoval
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180626210130.GF1218@vader \
--to=osandov@osandov.com \
--cc=bart.vanassche@wdc.com \
--cc=jthumshirn@suse.de \
--cc=linux-block@vger.kernel.org \
--cc=osandov@fb.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.