From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: by yocto-www.yoctoproject.org (Postfix, from userid 118) id 55011E010C7; Wed, 27 Jun 2018 07:13:02 -0700 (PDT) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on yocto-www.yoctoproject.org X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,RCVD_IN_DNSWL_NONE autolearn=ham version=3.3.1 X-Spam-HAM-Report: * -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at http://www.dnswl.org/, no * trust * [209.85.128.195 listed in list.dnswl.org] * -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% * [score: 0.0000] * 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily * valid * -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature Received: from mail-wr0-f195.google.com (mail-wr0-f195.google.com [209.85.128.195]) by yocto-www.yoctoproject.org (Postfix) with ESMTP id CD43CE007CE for ; Wed, 27 Jun 2018 07:13:00 -0700 (PDT) Received: by mail-wr0-f195.google.com with SMTP id c5-v6so2205707wrs.10 for ; Wed, 27 Jun 2018 07:13:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=boundarydevices-com.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=aLRyR1ZINWbK+yBY/vLhFE7GnPMVBMpehXvNZ+gbnog=; b=T1iril9y4PvECFzKsvJGZafSqOvwNk7FxEj3eujSAZoTPit+lD/pen29xdGC5DuAIj kXvHZeug9FZOVf8OCnzOOu68riEIp9pIqr8yLmHhMwFM9hYWLynjD+lOd97Qt/cXe76V m1YN7jVbwo9qFNV1OUkycF7n5LjopBTyW5etg6L8HbF642WgWjfeaVgwXSPXWtOKG6mA UBToorMQwAlcEKS01hICGfi6x4ia18lGzA3a0fZeQxh7hNCYGBXXd3E35Z6bxq3Ny6Fv 6dXmw2vi/cIpSBPmsm0J33utyHJAz0H1MIWjBwSQp5aGMpvglnmAt4GuGzbXaMvWVrui 7qXg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=aLRyR1ZINWbK+yBY/vLhFE7GnPMVBMpehXvNZ+gbnog=; b=S9fAlC6lvWkXsXkpFTBBoGJOjT0Qo7tR/3/POhVonkl0KQFyH2eQM8k93wqOIYd6e6 IAFcq5JV4ORS7SW+DsvU81UxdwTyWepoz2xgPgfOslxOl9OQl+MY4kgFdoGRm6/MpsDE O6KjF0UaLERM3VcKyqB6e2JeeVLqobneVKP0eBH5saPJVLVoee/5Imos19MWZwGzNLmH /UA2gNhXUOX40SR1KNFPevL3+2q79SY18Ngk4cfV/cRMN6sQY8m8mK8l32VuQx1AkMF+ SPElmf3HX4DWMiD+vZN7oUkMatZ0fG9984H837/ycZIS/yIffwZjm9ORfqzKlnR5IR+P vlrw== X-Gm-Message-State: APt69E3iMW2m32oU9plrS7SxJul9qLyZAqWpCWvcbm3vikCPirsY+2zX y8NfPgrk5pLxqq168oTnGdvYSg== X-Google-Smtp-Source: AAOMgpdqnSnlkPWR+o82jD0/e/lqGDCEwqM7hSx02LPA66+XBT0qNfRdOIrFs91Rda//PWk9gKn/3Q== X-Received: by 2002:adf:adae:: with SMTP id w43-v6mr5615526wrc.251.1530108779833; Wed, 27 Jun 2018 07:12:59 -0700 (PDT) Received: from g751.home (2a01cb040a78e3003d608593cd48de0b.ipv6.abo.wanadoo.fr. [2a01:cb04:a78:e300:3d60:8593:cd48:de0b]) by smtp.gmail.com with ESMTPSA id 189-v6sm6638863wmd.17.2018.06.27.07.12.58 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Wed, 27 Jun 2018 07:12:58 -0700 (PDT) Date: Wed, 27 Jun 2018 16:12:54 +0200 From: Gary Bisson To: Tom Hochstein Message-ID: <20180627141254.GA13530@g751.home> References: <20180625193032.9248-1-otavio@ossystems.com.br> <20180625193032.9248-30-otavio@ossystems.com.br> <20180626081931.GB13334@g751.home> MIME-Version: 1.0 In-Reply-To: User-Agent: Mutt/1.10.0 (2018-05-17) Cc: meta-freescale Mailing List , Otavio Salvador Subject: Re: [PATCH 30/32] imx-base.inc: Add imxdpu and imxdpublit to MACHINEOVERRIDES_EXTENDER X-BeenThere: meta-freescale@yoctoproject.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: Usage and development list for the meta-fsl-* layers List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 27 Jun 2018 14:13:02 -0000 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Hi Tom, On Wed, Jun 27, 2018 at 02:00:29PM +0000, Tom Hochstein wrote: > After thinking on this some more, let me start over. > > > -----Original Message----- > > From: meta-freescale-bounces@yoctoproject.org [mailto:meta-freescale- > > bounces@yoctoproject.org] On Behalf Of Gary Bisson > > Sent: Tuesday, June 26, 2018 3:20 AM > > To: Otavio Salvador > > Cc: meta-freescale Mailing List > > Subject: Re: [meta-freescale] [PATCH 30/32] imx-base.inc: Add imxdpu and > > imxdpublit to MACHINEOVERRIDES_EXTENDER > > > > Hi Otavio, Tom, > > > > On Mon, Jun 25, 2018 at 04:30:30PM -0300, Otavio Salvador wrote: > > > From: Tom Hochstein > > > > > > - imx-gpu-g2d requires DPU-blit support > > > > Can you elaborate on that? What has changed in the g2d package so that it > > now depends on DPU-blit? > > Nothing has changed, this just makes an existing requirement explicit. i.MX 6 and 7 with 2D GPU do in fact have a separate DPU blitting engine, different from the DPU used for i.MX 8. What does "DPU" mean to you? I think what you mean is "i.MX6 and 7 can do 2D blit operations with their 2D GPU". Using the term DPU doesn't make sense to me, please elaborate. My definition of DPU is "Display Processing Unit" as defined in i.MX8QM docs, therefore using the same term for CPU that don't have that IP is confusing, isn't it? > > > - imx-dpu-g2d requires DPU support > > > > > > Signed-off-by: Tom Hochstein > > > Signed-off-by: Otavio Salvador > > > --- > > > > > > conf/machine/include/imx-base.inc | 14 +++++++------- > > > recipes-graphics/imx-dpu-g2d/imx-dpu-g2d_1.4.2.bb | 4 +++- > > > .../imx-gpu-g2d/imx-gpu-g2d_6.2.4.p1.2.bb | 4 +++- > > > 3 files changed, 13 insertions(+), 9 deletions(-) > > > > > > diff --git a/conf/machine/include/imx-base.inc > > > b/conf/machine/include/imx-base.inc > > > index 346d1c77..6ba5014d 100644 > > > --- a/conf/machine/include/imx-base.inc > > > +++ b/conf/machine/include/imx-base.inc > > > @@ -59,17 +59,17 @@ DEFAULTTUNE_vf ?= "cortexa5thf-neon" > > > INHERIT += "machine-overrides-extender" > > > > > > MACHINEOVERRIDES_EXTENDER_mx25 = "use-mainline-bsp" > > > -MACHINEOVERRIDES_EXTENDER_mx6q = > > "imxipu:imxvpu:imxgpu2d:imxgpu3d" > > > -MACHINEOVERRIDES_EXTENDER_mx6dl = > > "imxpxp:imxipu:imxvpu:imxgpu2d:imxgpu3d:imxepdc" > > > -MACHINEOVERRIDES_EXTENDER_mx6sx = "imxpxp:imxgpu2d:imxgpu3d" > > > -MACHINEOVERRIDES_EXTENDER_mx6sl = "imxpxp:imxgpu2d:imxepdc" > > > +MACHINEOVERRIDES_EXTENDER_mx6q = > > "imxipu:imxvpu:imxgpu2d:imxdpublit:imxgpu3d" > > > +MACHINEOVERRIDES_EXTENDER_mx6dl = > > "imxpxp:imxipu:imxvpu:imxgpu2d:imxdpublit:imxgpu3d:imxepdc" > > > +MACHINEOVERRIDES_EXTENDER_mx6sx = > > "imxpxp:imxgpu2d:imxdpublit:imxgpu3d" > > > +MACHINEOVERRIDES_EXTENDER_mx6sl = > > "imxpxp:imxgpu2d:imxdpublit:imxepdc" > > > > ?? I don't understand that naming at all. Shouldn't imxdpublit be necessary > > on HW that has a DPU (ie none of the above)? > > > > > MACHINEOVERRIDES_EXTENDER_mx6sll = "imxpxp:imxepdc" > > > MACHINEOVERRIDES_EXTENDER_mx6ul = "imxpxp" > > > MACHINEOVERRIDES_EXTENDER_mx6ull = "imxpxp:imxepdc" > > > MACHINEOVERRIDES_EXTENDER_mx7d = "imxpxp:imxepdc" > > > -MACHINEOVERRIDES_EXTENDER_mx7ulp = "imxpxp:imxgpu2d:imxgpu3d" > > > -MACHINEOVERRIDES_EXTENDER_mx8mq = "imxvpu:imxgpu3d" > > > -MACHINEOVERRIDES_EXTENDER_mx8mm = > > "imxvpu:imxgpu2d:imxgpu3d" > > > +MACHINEOVERRIDES_EXTENDER_mx7ulp = > > "imxpxp:imxgpu2d:imxdpublit:imxgpu3d" > > > +MACHINEOVERRIDES_EXTENDER_mx8mq = "imxvpu:imxdpu:imxgpu3d" > > > > This is wrong, mx8mq doesn't have a DPU. > > You are correct about that, my mistake. > > So at this point just need to fix this patch. Note, that I need to submit an update for imx-gpu-sdk that also depends on imxdpublit. Sorry but that still doesn't tell me why we're not using imxgpu2d as before? Why creating a "2dblit" feature, it was known in the first place that imxgpu2d is capable of 2dblit. Actually let's generalize it and say that "libg2d" (whether it is gpu or dpu) is capable of blitting. The only issue I see is that in the case of imx8mm, both gpu-g2d and dpu-g2d can be built, but that should be easily selectable via a preferred provider for lig2d no? Also I find it more flexible to leave it to the user to select which 2D blitting engine he wants to use instead of forcing one over the other. Regards, Gary