From mboxrd@z Thu Jan  1 00:00:00 1970
From: Andrew Lunn <andrew@lunn.ch>
Subject: Re: [PATCH v7 03/11] net: pch_gbe: Probe PHY ID & initialize only
 once
Date: Wed, 27 Jun 2018 19:33:51 +0200
Message-ID: <20180627173351.GF885@lunn.ch>
References: <20180627000612.27263-1-paul.burton@mips.com>
 <20180627000612.27263-4-paul.burton@mips.com>
 <20180627172131.GB885@lunn.ch>
 <20180627173106.s2lbolvz4x5mqr64@pburton-laptop>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Cc: netdev@vger.kernel.org, "David S . Miller" <davem@davemloft.net>
To: Paul Burton <paul.burton@mips.com>
Return-path: <netdev-owner@vger.kernel.org>
Received: from vps0.lunn.ch ([185.16.172.187]:44697 "EHLO vps0.lunn.ch"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S965055AbeF0Rdx (ORCPT <rfc822;netdev@vger.kernel.org>);
        Wed, 27 Jun 2018 13:33:53 -0400
Content-Disposition: inline
In-Reply-To: <20180627173106.s2lbolvz4x5mqr64@pburton-laptop>
Sender: netdev-owner@vger.kernel.org
List-ID: <netdev.vger.kernel.org>

> This is actually needed because pch_gbe_check_options() sets up, amongst
> other things, the autoneg_advertised field in struct pch_gbe_phy_info
> and that needs to happen before pch_gbe_phy_init_setting() is called.

Hi Paul

Please add a comment to the commit message about this.

       Andrew