From: keith.busch@linux.intel.com (Keith Busch)
Subject: [PATCH 1/1] nvme: Ensure forward progress during Admin passthru
Date: Wed, 27 Jun 2018 14:49:14 -0600 [thread overview]
Message-ID: <20180627204914.GA10657@localhost.localdomain> (raw)
In-Reply-To: <20180627202741.GF9361@localhost.localdomain>
On Wed, Jun 27, 2018@02:27:41PM -0600, Keith Busch wrote:
> static void nvme_update_formats(struct nvme_ctrl *ctrl)
> {
> struct nvme_ns *ns, *next;
> - LIST_HEAD(rm_list);
>
> - down_write(&ctrl->namespaces_rwsem);
> + down_read(&ctrl->namespaces_rwsem);
> list_for_each_entry(ns, &ctrl->namespaces, list) {
> - if (ns->disk && nvme_revalidate_disk(ns->disk)) {
> - list_move_tail(&ns->list, &rm_list);
> - }
> + if (ns->disk && nvme_revalidate_disk(ns->disk))
> + if (test_bit(NVME_NS_DEAD, &ns->flags))
> + set_capacity(disk, 0);
Meant to be "!test_and_set_bit(...)" ... and needs to do a few other
things on top of setting capacity to 0, like blk_set_queue_dying. Maybe
just turn the inner loop of nvme_kill_queues() into a function call so
this path can reuse it.
next prev parent reply other threads:[~2018-06-27 20:49 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-06-22 19:59 [PATCH 0/1] nvme: Ensure forward progress during Admin passthru Scott Bauer
2018-06-22 19:59 ` [PATCH 1/1] " Scott Bauer
2018-06-27 19:12 ` Keith Busch
2018-06-27 19:01 ` Scott Bauer
2018-06-27 20:27 ` Keith Busch
2018-06-27 20:49 ` Keith Busch [this message]
2018-06-24 17:38 ` [PATCH 0/1] " Sagi Grimberg
2018-06-27 19:08 ` Keith Busch
2018-06-28 17:10 ` [PATCH v2 1/1] " Scott Bauer
2018-06-28 19:16 ` Keith Busch
2018-06-28 19:19 ` Scott Bauer
2018-06-28 19:54 ` Keith Busch
2018-06-29 19:03 ` [PATCH v3 " Scott Bauer
2018-06-29 20:23 ` Keith Busch
2018-07-16 22:09 ` Keith Busch
2018-07-17 12:42 ` Christoph Hellwig
2018-07-18 11:26 ` Sagi Grimberg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180627204914.GA10657@localhost.localdomain \
--to=keith.busch@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.