From: Kevin Wolf <kwolf@redhat.com>
To: Laurent Vivier <laurent@vivier.eu>
Cc: qemu-devel@nongnu.org, "Gerd Hoffmann" <kraxel@redhat.com>,
"Paolo Bonzini" <pbonzini@redhat.com>,
"Mark Cave-Ayland" <mark.cave-ayland@ilande.co.uk>,
"Max Reitz" <mreitz@redhat.com>,
"Andreas Färber" <afaerber@suse.de>,
"Hervé Poussineau" <hpoussin@reactos.org>,
"Aurelien Jarno" <aurelien@aurel32.net>,
"Jason Wang" <jasowang@redhat.com>, "Fam Zheng" <famz@redhat.com>,
qemu-block@nongnu.org,
"Dr. David Alan Gilbert" <dgilbert@redhat.com>,
"Yongbok Kim" <yongbok.kim@mips.com>
Subject: Re: [Qemu-devel] [C v2 08/10] hw/m68k: add a dummy SWIM floppy controller
Date: Thu, 28 Jun 2018 10:44:37 +0200 [thread overview]
Message-ID: <20180628084437.GA4833@localhost.localdomain> (raw)
In-Reply-To: <20180627232334.14142-9-laurent@vivier.eu>
Am 28.06.2018 um 01:23 hat Laurent Vivier geschrieben:
> Co-developed-by: Mark Cave-Ayland <mark.cave-ayland@ilande.co.uk>
> Signed-off-by: Mark Cave-Ayland <mark.cave-ayland@ilande.co.uk>
> Signed-off-by: Laurent Vivier <laurent@vivier.eu>
> +static Property swim_properties[] = {
> + DEFINE_PROP_DRIVE("driveA", SWIMCtrl, drives[0].blk),
> + DEFINE_PROP_DRIVE("driveB", SWIMCtrl, drives[1].blk),
> + DEFINE_PROP_END_OF_LIST(),
> +};
This is not the right way to model things. The floppy controller needs
to expose a bus and floppy drives need to be created with a separate
-device option.
isa-fdc still has these options, but that's only for compatibility and
their implementation is basically a wrapper around the modern qdev way.
Kevin
next prev parent reply other threads:[~2018-06-28 8:44 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-06-27 23:23 [Qemu-devel] [C v2 00/10] hw/m68k: add Apple Machintosh Quadra 800 machine Laurent Vivier
2018-06-27 23:23 ` [Qemu-devel] [C v2 01/10] hw/m68k: add via support Laurent Vivier
2018-06-27 23:23 ` [Qemu-devel] [C v2 02/10] ADB: VIA probes ADB bus when it is idle Laurent Vivier
2018-06-27 23:23 ` [Qemu-devel] [C v2 03/10] escc: introduce a selector for the register bit Laurent Vivier
2018-06-27 23:23 ` [Qemu-devel] [C v2 04/10] hw/m68k: add video card Laurent Vivier
2018-06-27 23:23 ` [Qemu-devel] [C v2 05/10] hw/m68k: Apple Sound Chip (ASC) emulation Laurent Vivier
2018-06-27 23:23 ` [Qemu-devel] [C v2 06/10] ESP: add pseudo-DMA as used by Macintosh Laurent Vivier
2018-06-27 23:23 ` [Qemu-devel] [C v2 07/10] hw/m68k: add Nubus support Laurent Vivier
2018-06-27 23:23 ` [Qemu-devel] [C v2 08/10] hw/m68k: add a dummy SWIM floppy controller Laurent Vivier
2018-06-28 8:44 ` Kevin Wolf [this message]
2018-06-28 9:04 ` Laurent Vivier
2018-06-27 23:23 ` [Qemu-devel] [C v2 09/10] dp8393x: manage big endian bus Laurent Vivier
2018-07-08 6:35 ` Thomas Huth
2018-06-27 23:23 ` [Qemu-devel] [C v2 10/10] hw/m68k: define Macintosh Quadra 800 Laurent Vivier
2018-07-08 6:51 ` Thomas Huth
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180628084437.GA4833@localhost.localdomain \
--to=kwolf@redhat.com \
--cc=afaerber@suse.de \
--cc=aurelien@aurel32.net \
--cc=dgilbert@redhat.com \
--cc=famz@redhat.com \
--cc=hpoussin@reactos.org \
--cc=jasowang@redhat.com \
--cc=kraxel@redhat.com \
--cc=laurent@vivier.eu \
--cc=mark.cave-ayland@ilande.co.uk \
--cc=mreitz@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=yongbok.kim@mips.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.