All of lore.kernel.org
 help / color / mirror / Atom feed
From: Greg KH <gregkh@linuxfoundation.org>
To: Shubhrajyoti Datta <shubhrajyoti.datta@xilinx.com>
Cc: linux-serial@vger.kernel.org, devicetree@vger.kernel.org,
	robh+dt@kernel.org, shubhrajyoti.datta@gmail.com,
	Tanvi Desai <tanvi.desai@xilinx.com>
Subject: Re: [PATCH 2/4] tty: serial: uartlite: Add clock adaptation
Date: Thu, 28 Jun 2018 21:12:12 +0900	[thread overview]
Message-ID: <20180628121212.GA22500@kroah.com> (raw)
In-Reply-To: <1530102225-6459-2-git-send-email-shubhrajyoti.datta@xilinx.com>

On Wed, Jun 27, 2018 at 05:53:43PM +0530, Shubhrajyoti Datta wrote:
>  - Add support of Common Clock Framework for Uartlite driver
>  - Add support for suspend and resume operations
> 

When you have to list multiple things that a single patch does, that's a
huge hint that it should be broken up into smaller pieces.  Can you
split this up into two patches please?

thanks,

greg k-h

  reply	other threads:[~2018-06-28 12:12 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-06-27 12:23 [PATCH 1/4] tty: serial: uartlite: Add structure for private data Shubhrajyoti Datta
2018-06-27 12:23 ` [PATCH 2/4] tty: serial: uartlite: Add clock adaptation Shubhrajyoti Datta
2018-06-28 12:12   ` Greg KH [this message]
2018-06-27 12:23 ` [PATCH 3/4] doc: uartlite: Add binding for the driver Shubhrajyoti Datta
2018-07-03 22:42   ` Rob Herring
2018-07-09 13:44     ` Maarten Brock
2018-07-09 14:36       ` Rob Herring
2018-07-03 22:43   ` Rob Herring
2018-06-27 12:23 ` [PATCH 4/4] Documentation: uartlite: Add clock to the binding Shubhrajyoti Datta
2018-07-03 22:45   ` Rob Herring
2018-06-28 12:14 ` [PATCH 1/4] tty: serial: uartlite: Add structure for private data Greg KH
2018-07-02  4:29   ` Shubhrajyoti Datta

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180628121212.GA22500@kroah.com \
    --to=gregkh@linuxfoundation.org \
    --cc=devicetree@vger.kernel.org \
    --cc=linux-serial@vger.kernel.org \
    --cc=robh+dt@kernel.org \
    --cc=shubhrajyoti.datta@gmail.com \
    --cc=shubhrajyoti.datta@xilinx.com \
    --cc=tanvi.desai@xilinx.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.