From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Simon Que <sque@chromium.org>
Cc: linux-kernel@vger.kernel.org, Ben Chan <benchan@chromium.org>,
Chun-Ta Lin <itspeter@chromium.org>,
Zhongze Hu <frankhu@chromium.org>,
Rob Springer <rspringer@google.com>,
John Joseph <jnjoseph@google.com>
Subject: Re: [PATCH v4] drivers/staging: Gasket driver framework + Apex driver
Date: Thu, 28 Jun 2018 22:16:17 +0900 [thread overview]
Message-ID: <20180628131617.GA30635@kroah.com> (raw)
In-Reply-To: <20180620232441.204171-1-sque@chromium.org>
On Wed, Jun 20, 2018 at 07:24:41PM -0400, Simon Que wrote:
> The Gasket (Google ASIC Software, Kernel Extensions, and Tools) kernel
> framework is a generic, flexible system that supports thin kernel
> drivers. Gasket kernel drivers are expected to handle opening and
> closing devices, mmap'ing BAR space as requested, a small selection of
> ioctls, and handling page table translation (covered below). Any other
> functions should be handled by userspace code.
>
> The Gasket common module is not enough to run a device. In order to
> customize the Gasket code for a given piece of hardware, a device
> specific module must be created. At a minimum, this module must define a
> struct gasket_driver_desc containing the device-specific data for use by
> the framework; in addition, the module must declare an __init function
> that calls gasket_register_device with the module's gasket_driver_desc
> struct. Finally, the driver must define an exit function that calls
> gasket_unregister_device with the module's gasket_driver_desc struct.
>
> One of the core assumptions of the Gasket framework is that precisely
> one process is allowed to have an open write handle to the device node
> at any given time. (That process may, once it has one write handle, open
> any number of additional write handles.) This is accomplished by
> tracking open and close data for each driver instance.
>
> Signed-off-by: Rob Springer <rspringer@google.com>
> Signed-off-by: John Joseph <jnjoseph@google.com>
> Signed-off-by: Simon Que <sque@chromium.org>
This patch does not apply against my staging-testing tree. Or against
4.18-rc1 either, what did you make it against?
Please rebase and resend so that I can apply it.
thanks,
greg k-h
prev parent reply other threads:[~2018-06-28 15:35 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-06-20 23:24 [PATCH v4] drivers/staging: Gasket driver framework + Apex driver Simon Que
2018-06-24 4:14 ` Joe Perches
2018-06-28 13:16 ` Greg Kroah-Hartman [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180628131617.GA30635@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=benchan@chromium.org \
--cc=frankhu@chromium.org \
--cc=itspeter@chromium.org \
--cc=jnjoseph@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=rspringer@google.com \
--cc=sque@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.