All of lore.kernel.org
 help / color / mirror / Atom feed
From: Greg KH <gregkh@linuxfoundation.org>
To: Andreas Klinger <ak@it-klinger.de>
Cc: jacek.anaszewski@gmail.com, pavel@ucw.cz, ben.whitten@gmail.com,
	geert+renesas@glider.be, w@1wt.eu, pombredanne@nexb.com,
	linux-kernel@vger.kernel.org, linux-leds@vger.kernel.org
Subject: Re: [PATCH] leds: ledtrig-morse: send out morse code
Date: Thu, 28 Jun 2018 22:54:46 +0900	[thread overview]
Message-ID: <20180628135446.GA18287@kroah.com> (raw)
In-Reply-To: <20180628134227.GA1719@arbeit>

On Thu, Jun 28, 2018 at 03:42:27PM +0200, Andreas Klinger wrote:
> Send out a morse code by using LEDs.
> 
> This is useful especially on embedded systems without displays to tell the
> user about error conditions and status information.
> 
> The trigger will be called "morse"
> 
> The string to be send is written into the file morse_string and sent out
> with a workqueue. Supported are letters and digits.
> 
> With the file dot_unit the minimal time unit can be adjusted in
> milliseconds.

This is great stuff, nice work.

But you need to document your new sysfs files in Documentation/ABI/
somewhere, so that people know how to use this.

thanks,

greg k-h

  reply	other threads:[~2018-06-28 13:54 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-06-28 13:42 [PATCH] leds: ledtrig-morse: send out morse code Andreas Klinger
2018-06-28 13:54 ` Greg KH [this message]
2018-06-28 15:36 ` Geert Uytterhoeven
2018-06-28 18:21 ` Willy Tarreau
2018-06-28 18:56 ` Pavel Machek
2018-06-28 20:29   ` Andreas Klinger
2018-06-28 20:45     ` Pavel Machek
2018-06-29  6:41       ` Andreas Klinger
2018-06-29  7:17         ` Pavel Machek
2018-06-29  7:21           ` Geert Uytterhoeven
2018-06-29  7:29             ` Pavel Machek
2018-06-29  7:48               ` Geert Uytterhoeven
2018-06-29  8:07                 ` Pavel Machek
2018-06-29  8:24                   ` Greg KH
2018-06-29  9:23                     ` Pavel Machek
2018-06-28 20:33   ` Andreas Klinger

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180628135446.GA18287@kroah.com \
    --to=gregkh@linuxfoundation.org \
    --cc=ak@it-klinger.de \
    --cc=ben.whitten@gmail.com \
    --cc=geert+renesas@glider.be \
    --cc=jacek.anaszewski@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-leds@vger.kernel.org \
    --cc=pavel@ucw.cz \
    --cc=pombredanne@nexb.com \
    --cc=w@1wt.eu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.