From: "Richard W.M. Jones" <rjones@redhat.com>
To: "Daniel P. Berrangé" <berrange@redhat.com>
Cc: Eric Blake <eblake@redhat.com>,
qemu-devel@nongnu.org, qemu-block@nongnu.org
Subject: Re: [Qemu-devel] [PATCH v3] crypto: Implement TLS Pre-Shared Keys (PSK).
Date: Thu, 28 Jun 2018 17:51:18 +0100 [thread overview]
Message-ID: <20180628165118.GH1455@redhat.com> (raw)
In-Reply-To: <20180628160620.GS3513@redhat.com>
On Thu, Jun 28, 2018 at 05:06:20PM +0100, Daniel P. Berrangé wrote:
> On Thu, Jun 28, 2018 at 09:42:18AM -0500, Eric Blake wrote:
> > Does it make sense to forbid this operation on servers (since it only makes
> > sense for clients)?
>
> We can't validate that here, because we can't guarantee that 'endpoint'
> is set before 'username' is set.
>
>
> We could enforce it in the setter for the "loaded" property as that is
> set only after every other property is set.
As far as I can see we could only warn here, since the set_loaded
function returns void.
Rich.
--
Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones
Read my programming and virtualization blog: http://rwmj.wordpress.com
virt-top is 'top' for virtual machines. Tiny program with many
powerful monitoring features, net stats, disk stats, logging, etc.
http://people.redhat.com/~rjones/virt-top
next prev parent reply other threads:[~2018-06-28 16:51 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-06-28 13:22 [Qemu-devel] [PATCH v3] crypto: Implement TLS Pre-Shared Keys (PSK) Richard W.M. Jones
2018-06-28 13:22 ` Richard W.M. Jones
2018-06-28 14:42 ` Eric Blake
2018-06-28 14:48 ` Eric Blake
2018-06-28 15:54 ` Richard W.M. Jones
2018-06-28 15:58 ` Daniel P. Berrangé
2018-06-28 16:06 ` Daniel P. Berrangé
2018-06-28 16:51 ` Richard W.M. Jones [this message]
2018-06-28 17:13 ` Daniel P. Berrangé
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180628165118.GH1455@redhat.com \
--to=rjones@redhat.com \
--cc=berrange@redhat.com \
--cc=eblake@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.