From mboxrd@z Thu Jan 1 00:00:00 1970 From: Rodrigo Vivi Subject: Re: [PATCH 1/3] drm: Extract __setplane_check() Date: Thu, 28 Jun 2018 09:53:45 -0700 Message-ID: <20180628165345.GA20915@intel.com> References: <20180628135457.14647-1-ville.syrjala@linux.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Content-Disposition: inline In-Reply-To: <20180628135457.14647-1-ville.syrjala@linux.intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Ville Syrjala Cc: intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org List-Id: dri-devel@lists.freedesktop.org T24gVGh1LCBKdW4gMjgsIDIwMTggYXQgMDQ6NTQ6NTVQTSArMDMwMCwgVmlsbGUgU3lyamFsYSB3 cm90ZToKPiBGcm9tOiBWaWxsZSBTeXJqw6Rsw6QgPHZpbGxlLnN5cmphbGFAbGludXguaW50ZWwu Y29tPgo+IAo+IFB1bGwgYWxsIHRoZSBlcnJvciBjaGVja2luZyBvdXQgZnJvbSBfX3NldF9wbGFu ZV9pbnRlcm5hbCgpIHRvIGEgaGVscGVyCj4gZnVuY3Rpb24uIFdlJ2xsIGhhdmUgYW5vdGhlciB1 c2VyIG9mIHRoaXMgc29vbi4KPiAKPiBTaWduZWQtb2ZmLWJ5OiBWaWxsZSBTeXJqw6Rsw6QgPHZp bGxlLnN5cmphbGFAbGludXguaW50ZWwuY29tPgoKUmV2aWV3ZWQtYnk6IFJvZHJpZ28gVml2aSA8 cm9kcmlnby52aXZpQGludGVsLmNvbT4KCj4gLS0tCj4gIGRyaXZlcnMvZ3B1L2RybS9kcm1fcGxh bmUuYyB8IDgwICsrKysrKysrKysrKysrKysrKysrKysrKysrKy0tLS0tLS0tLS0tLS0tLS0tLQo+ ICAxIGZpbGUgY2hhbmdlZCwgNDkgaW5zZXJ0aW9ucygrKSwgMzEgZGVsZXRpb25zKC0pCj4gCj4g ZGlmZiAtLWdpdCBhL2RyaXZlcnMvZ3B1L2RybS9kcm1fcGxhbmUuYyBiL2RyaXZlcnMvZ3B1L2Ry bS9kcm1fcGxhbmUuYwo+IGluZGV4IGRmMGI0ZWJiZWRiZi4uNWM5N2EwMTMxNDg0IDEwMDY0NAo+ IC0tLSBhL2RyaXZlcnMvZ3B1L2RybS9kcm1fcGxhbmUuYwo+ICsrKyBiL2RyaXZlcnMvZ3B1L2Ry bS9kcm1fcGxhbmUuYwo+IEBAIC01ODMsNiArNTgzLDUyIEBAIGludCBkcm1fcGxhbmVfY2hlY2tf cGl4ZWxfZm9ybWF0KHN0cnVjdCBkcm1fcGxhbmUgKnBsYW5lLAo+ICAJcmV0dXJuIDA7Cj4gIH0K PiAgCj4gK3N0YXRpYyBpbnQgX19zZXRwbGFuZV9jaGVjayhzdHJ1Y3QgZHJtX3BsYW5lICpwbGFu ZSwKPiArCQkJICAgIHN0cnVjdCBkcm1fY3J0YyAqY3J0YywKPiArCQkJICAgIHN0cnVjdCBkcm1f ZnJhbWVidWZmZXIgKmZiLAo+ICsJCQkgICAgaW50MzJfdCBjcnRjX3gsIGludDMyX3QgY3J0Y195 LAo+ICsJCQkgICAgdWludDMyX3QgY3J0Y193LCB1aW50MzJfdCBjcnRjX2gsCj4gKwkJCSAgICB1 aW50MzJfdCBzcmNfeCwgdWludDMyX3Qgc3JjX3ksCj4gKwkJCSAgICB1aW50MzJfdCBzcmNfdywg dWludDMyX3Qgc3JjX2gpCj4gK3sKPiArCWludCByZXQ7Cj4gKwo+ICsJLyogQ2hlY2sgd2hldGhl ciB0aGlzIHBsYW5lIGlzIHVzYWJsZSBvbiB0aGlzIENSVEMgKi8KPiArCWlmICghKHBsYW5lLT5w b3NzaWJsZV9jcnRjcyAmIGRybV9jcnRjX21hc2soY3J0YykpKSB7Cj4gKwkJRFJNX0RFQlVHX0tN UygiSW52YWxpZCBjcnRjIGZvciBwbGFuZVxuIik7Cj4gKwkJcmV0dXJuIC1FSU5WQUw7Cj4gKwl9 Cj4gKwo+ICsJLyogQ2hlY2sgd2hldGhlciB0aGlzIHBsYW5lIHN1cHBvcnRzIHRoZSBmYiBwaXhl bCBmb3JtYXQuICovCj4gKwlyZXQgPSBkcm1fcGxhbmVfY2hlY2tfcGl4ZWxfZm9ybWF0KHBsYW5l LCBmYi0+Zm9ybWF0LT5mb3JtYXQsCj4gKwkJCQkJICAgZmItPm1vZGlmaWVyKTsKPiArCWlmIChy ZXQpIHsKPiArCQlzdHJ1Y3QgZHJtX2Zvcm1hdF9uYW1lX2J1ZiBmb3JtYXRfbmFtZTsKPiArCj4g KwkJRFJNX0RFQlVHX0tNUygiSW52YWxpZCBwaXhlbCBmb3JtYXQgJXMsIG1vZGlmaWVyIDB4JWxs eFxuIiwKPiArCQkJICAgICAgZHJtX2dldF9mb3JtYXRfbmFtZShmYi0+Zm9ybWF0LT5mb3JtYXQs Cj4gKwkJCQkJCSAgJmZvcm1hdF9uYW1lKSwKPiArCQkJICAgICAgZmItPm1vZGlmaWVyKTsKPiAr CQlyZXR1cm4gcmV0Owo+ICsJfQo+ICsKPiArCS8qIEdpdmUgZHJpdmVycyBzb21lIGhlbHAgYWdh aW5zdCBpbnRlZ2VyIG92ZXJmbG93cyAqLwo+ICsJaWYgKGNydGNfdyA+IElOVF9NQVggfHwKPiAr CSAgICBjcnRjX3ggPiBJTlRfTUFYIC0gKGludDMyX3QpIGNydGNfdyB8fAo+ICsJICAgIGNydGNf aCA+IElOVF9NQVggfHwKPiArCSAgICBjcnRjX3kgPiBJTlRfTUFYIC0gKGludDMyX3QpIGNydGNf aCkgewo+ICsJCURSTV9ERUJVR19LTVMoIkludmFsaWQgQ1JUQyBjb29yZGluYXRlcyAldXgldSsl ZCslZFxuIiwKPiArCQkJICAgICAgY3J0Y193LCBjcnRjX2gsIGNydGNfeCwgY3J0Y195KTsKPiAr CQlyZXR1cm4gLUVSQU5HRTsKPiArCX0KPiArCj4gKwlyZXQgPSBkcm1fZnJhbWVidWZmZXJfY2hl Y2tfc3JjX2Nvb3JkcyhzcmNfeCwgc3JjX3ksIHNyY193LCBzcmNfaCwgZmIpOwo+ICsJaWYgKHJl dCkKPiArCQlyZXR1cm4gcmV0Owo+ICsKPiArCXJldHVybiAwOwo+ICt9Cj4gKwo+ICAvKgo+ICAg KiBfX3NldHBsYW5lX2ludGVybmFsIC0gc2V0cGxhbmUgaGFuZGxlciBmb3IgaW50ZXJuYWwgY2Fs bGVycwo+ICAgKgo+IEBAIC02MTYsMzcgKzY2Miw5IEBAIHN0YXRpYyBpbnQgX19zZXRwbGFuZV9p bnRlcm5hbChzdHJ1Y3QgZHJtX3BsYW5lICpwbGFuZSwKPiAgCQlnb3RvIG91dDsKPiAgCX0KPiAg Cj4gLQkvKiBDaGVjayB3aGV0aGVyIHRoaXMgcGxhbmUgaXMgdXNhYmxlIG9uIHRoaXMgQ1JUQyAq Lwo+IC0JaWYgKCEocGxhbmUtPnBvc3NpYmxlX2NydGNzICYgZHJtX2NydGNfbWFzayhjcnRjKSkp IHsKPiAtCQlEUk1fREVCVUdfS01TKCJJbnZhbGlkIGNydGMgZm9yIHBsYW5lXG4iKTsKPiAtCQly ZXQgPSAtRUlOVkFMOwo+IC0JCWdvdG8gb3V0Owo+IC0JfQo+IC0KPiAtCS8qIENoZWNrIHdoZXRo ZXIgdGhpcyBwbGFuZSBzdXBwb3J0cyB0aGUgZmIgcGl4ZWwgZm9ybWF0LiAqLwo+IC0JcmV0ID0g ZHJtX3BsYW5lX2NoZWNrX3BpeGVsX2Zvcm1hdChwbGFuZSwgZmItPmZvcm1hdC0+Zm9ybWF0LAo+ IC0JCQkJCSAgIGZiLT5tb2RpZmllcik7Cj4gLQlpZiAocmV0KSB7Cj4gLQkJc3RydWN0IGRybV9m b3JtYXRfbmFtZV9idWYgZm9ybWF0X25hbWU7Cj4gLQkJRFJNX0RFQlVHX0tNUygiSW52YWxpZCBw aXhlbCBmb3JtYXQgJXMsIG1vZGlmaWVyIDB4JWxseFxuIiwKPiAtCQkJICAgICAgZHJtX2dldF9m b3JtYXRfbmFtZShmYi0+Zm9ybWF0LT5mb3JtYXQsCj4gLQkJCQkJCSAgJmZvcm1hdF9uYW1lKSwK PiAtCQkJICAgICAgZmItPm1vZGlmaWVyKTsKPiAtCQlnb3RvIG91dDsKPiAtCX0KPiAtCj4gLQkv KiBHaXZlIGRyaXZlcnMgc29tZSBoZWxwIGFnYWluc3QgaW50ZWdlciBvdmVyZmxvd3MgKi8KPiAt CWlmIChjcnRjX3cgPiBJTlRfTUFYIHx8Cj4gLQkgICAgY3J0Y194ID4gSU5UX01BWCAtIChpbnQz Ml90KSBjcnRjX3cgfHwKPiAtCSAgICBjcnRjX2ggPiBJTlRfTUFYIHx8Cj4gLQkgICAgY3J0Y195 ID4gSU5UX01BWCAtIChpbnQzMl90KSBjcnRjX2gpIHsKPiAtCQlEUk1fREVCVUdfS01TKCJJbnZh bGlkIENSVEMgY29vcmRpbmF0ZXMgJXV4JXUrJWQrJWRcbiIsCj4gLQkJCSAgICAgIGNydGNfdywg Y3J0Y19oLCBjcnRjX3gsIGNydGNfeSk7Cj4gLQkJcmV0ID0gLUVSQU5HRTsKPiAtCQlnb3RvIG91 dDsKPiAtCX0KPiAtCj4gLQlyZXQgPSBkcm1fZnJhbWVidWZmZXJfY2hlY2tfc3JjX2Nvb3Jkcyhz cmNfeCwgc3JjX3ksIHNyY193LCBzcmNfaCwgZmIpOwo+ICsJcmV0ID0gX19zZXRwbGFuZV9jaGVj ayhwbGFuZSwgY3J0YywgZmIsCj4gKwkJCSAgICAgICBjcnRjX3gsIGNydGNfeSwgY3J0Y193LCBj cnRjX2gsCj4gKwkJCSAgICAgICBzcmNfeCwgc3JjX3ksIHNyY193LCBzcmNfaCk7Cj4gIAlpZiAo cmV0KQo+ICAJCWdvdG8gb3V0Owo+ICAKPiAtLSAKPiAyLjE2LjQKPiAKPiBfX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwo+IEludGVsLWdmeCBtYWlsaW5nIGxp c3QKPiBJbnRlbC1nZnhAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCj4gaHR0cHM6Ly9saXN0cy5mcmVl ZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9pbnRlbC1nZngKX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX18KSW50ZWwtZ2Z4IG1haWxpbmcgbGlzdApJbnRl bC1nZnhAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlzdHMuZnJlZWRlc2t0b3Aub3Jn L21haWxtYW4vbGlzdGluZm8vaW50ZWwtZ2Z4Cg==