All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Ville Syrjälä" <ville.syrjala@linux.intel.com>
To: Dhinakaran Pandiyan <dhinakaran.pandiyan@intel.com>
Cc: intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH] drm/i915: Remove unecessary check for unsupported modifiers for NV12
Date: Thu, 28 Jun 2018 21:21:07 +0300	[thread overview]
Message-ID: <20180628182107.GR20518@intel.com> (raw)
In-Reply-To: <1530210960.25239.1.camel@intel.com>

On Thu, Jun 28, 2018 at 11:36:00AM -0700, Dhinakaran Pandiyan wrote:
> On Thu, 2018-06-28 at 08:48 +0200, Daniel Vetter wrote:
> > On Wed, Jun 27, 2018 at 11:18:54PM -0700, Dhinakaran Pandiyan wrote:
> > > 
> > > There is already a check to allow only RGB8888 formats with CCS
> > > modifiers.
> > > 
> > > Signed-off-by: Dhinakaran Pandiyan <dhinakaran.pandiyan@intel.com>
> > Reviewed-by: Daniel Vetter <daniel.vetter@ffwll.ch>
> > 
> 
> Thanks for the reviews.
> 
> 
> > Aside: intel_framebuffer_init is horribly long function, and it would
> > probably make a lot of sense to extract all the framebuffer related
> > stuff
> > into a new intel_framebuffer.c file. intel_display.c is a bit ... big
> > :-)
> 
> Yup, it's become a pain to add new stuff. I'll add this to my todo
> list.

A big chunk of intel_framebuffer_init() should simply be disappeared.
I tried but couldn't really come up with any entirely satisfactory
solution. Someone should revisit that topic now that we at least
figured out what to do with the .format_mod_supported() vs.
plane->modifiers[].

https://patchwork.freedesktop.org/series/39384/
https://patchwork.freedesktop.org/series/39701/
https://patchwork.freedesktop.org/series/39814/

-- 
Ville Syrjälä
Intel
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

  reply	other threads:[~2018-06-28 18:21 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-06-28  6:18 [PATCH] drm/i915: Remove unecessary check for unsupported modifiers for NV12 Dhinakaran Pandiyan
2018-06-28  6:48 ` Daniel Vetter
2018-06-28 18:36   ` Dhinakaran Pandiyan
2018-06-28 18:21     ` Ville Syrjälä [this message]
2018-07-02 18:35     ` Dhinakaran Pandiyan
2018-06-28  7:07 ` ✗ Fi.CI.CHECKPATCH: warning for " Patchwork
2018-06-28  7:23 ` ✓ Fi.CI.BAT: success " Patchwork
2018-06-28  8:35 ` [PATCH] " Maarten Lankhorst
2018-06-28  9:18 ` ✓ Fi.CI.IGT: success for " Patchwork

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180628182107.GR20518@intel.com \
    --to=ville.syrjala@linux.intel.com \
    --cc=dhinakaran.pandiyan@intel.com \
    --cc=intel-gfx@lists.freedesktop.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.