From mboxrd@z Thu Jan 1 00:00:00 1970 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Subject: USB: musb: mark expected switch fall-throughs From: "Gustavo A. R. Silva" Message-Id: <20180628183233.GA23194@embeddedor.com> Date: Thu, 28 Jun 2018 13:32:33 -0500 To: Bin Liu , Greg Kroah-Hartman Cc: linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org, "Gustavo A. R. Silva" List-ID: SW4gcHJlcGFyYXRpb24gdG8gZW5hYmxpbmcgLVdpbXBsaWNpdC1mYWxsdGhyb3VnaCwgbWFyayBz d2l0Y2ggY2FzZXMKd2hlcmUgd2UgYXJlIGV4cGVjdGluZyB0byBmYWxsIHRocm91Z2guCgpTaWdu ZWQtb2ZmLWJ5OiBHdXN0YXZvIEEuIFIuIFNpbHZhIDxndXN0YXZvQGVtYmVkZGVkb3IuY29tPgot LS0KIGRyaXZlcnMvdXNiL211c2IvbXVzYl9kc3BzLmMgfCAyICstCiBkcml2ZXJzL3VzYi9tdXNi L211c2JfaG9zdC5jIHwgMSArCiAyIGZpbGVzIGNoYW5nZWQsIDIgaW5zZXJ0aW9ucygrKSwgMSBk ZWxldGlvbigtKQoKZGlmZiAtLWdpdCBhL2RyaXZlcnMvdXNiL211c2IvbXVzYl9kc3BzLmMgYi9k cml2ZXJzL3VzYi9tdXNiL211c2JfZHNwcy5jCmluZGV4IGZiODcxZWEuLmRmODI3ZmYgMTAwNjQ0 Ci0tLSBhL2RyaXZlcnMvdXNiL211c2IvbXVzYl9kc3BzLmMKKysrIGIvZHJpdmVycy91c2IvbXVz Yi9tdXNiX2RzcHMuYwpAQCAtMjM3LDcgKzIzNyw3IEBAIHN0YXRpYyBpbnQgZHNwc19jaGVja19z dGF0dXMoc3RydWN0IG11c2IgKm11c2IsIHZvaWQgKnVudXNlZCkKIAkJfQogCQltdXNiX3dyaXRl YihtdXNiLT5tcmVncywgTVVTQl9ERVZDVEwsIDApOwogCQlza2lwX3Nlc3Npb24gPSAxOwotCQkv KiBmYWxsICovCisJCS8qIGZhbGwgdGhyb3VnaCAqLwogCiAJY2FzZSBPVEdfU1RBVEVfQV9JRExF OgogCWNhc2UgT1RHX1NUQVRFX0JfSURMRToKZGlmZiAtLWdpdCBhL2RyaXZlcnMvdXNiL211c2Iv bXVzYl9ob3N0LmMgYi9kcml2ZXJzL3VzYi9tdXNiL211c2JfaG9zdC5jCmluZGV4IDgwMDBjN2Mu LmI1OWNlOWEgMTAwNjQ0Ci0tLSBhL2RyaXZlcnMvdXNiL211c2IvbXVzYl9ob3N0LmMKKysrIGIv ZHJpdmVycy91c2IvbXVzYi9tdXNiX2hvc3QuYwpAQCAtMzc4LDYgKzM3OCw3IEBAIHN0YXRpYyB2 b2lkIG11c2JfYWR2YW5jZV9zY2hlZHVsZShzdHJ1Y3QgbXVzYiAqbXVzYiwgc3RydWN0IHVyYiAq dXJiLAogCQkJCXFoID0gZmlyc3RfcWgoaGVhZCk7CiAJCQkJYnJlYWs7CiAJCQl9CisJCQkvKiBl bHNlOiBmYWxsIHRocm91Z2ggKi8KIAogCQljYXNlIFVTQl9FTkRQT0lOVF9YRkVSX0lTT0M6CiAJ CWNhc2UgVVNCX0VORFBPSU5UX1hGRVJfSU5UOgo= From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.3 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_PASS,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2FA00C43144 for ; Thu, 28 Jun 2018 18:32:54 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id DC39D277D3 for ; Thu, 28 Jun 2018 18:32:53 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org DC39D277D3 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=embeddedor.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1030501AbeF1Scw (ORCPT ); Thu, 28 Jun 2018 14:32:52 -0400 Received: from gateway22.websitewelcome.com ([192.185.46.156]:34500 "EHLO gateway22.websitewelcome.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S966745AbeF1Scv (ORCPT ); Thu, 28 Jun 2018 14:32:51 -0400 Received: from cm15.websitewelcome.com (cm15.websitewelcome.com [100.42.49.9]) by gateway22.websitewelcome.com (Postfix) with ESMTP id 703ECC16D for ; Thu, 28 Jun 2018 13:32:50 -0500 (CDT) Received: from gator4166.hostgator.com ([108.167.133.22]) by cmsmtp with SMTP id YbicfQTJWbXuJYbilfbluM; Thu, 28 Jun 2018 13:32:49 -0500 X-Authority-Reason: nr=8 Received: from [189.250.65.56] (port=60484 helo=embeddedor) by gator4166.hostgator.com with esmtpa (Exim 4.91) (envelope-from ) id 1fYbib-003zmb-VO; Thu, 28 Jun 2018 13:32:34 -0500 Date: Thu, 28 Jun 2018 13:32:33 -0500 From: "Gustavo A. R. Silva" To: Bin Liu , Greg Kroah-Hartman Cc: linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org, "Gustavo A. R. Silva" Subject: [PATCH] USB: musb: mark expected switch fall-throughs Message-ID: <20180628183233.GA23194@embeddedor.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline User-Agent: Mutt/1.5.24 (2015-08-30) X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - gator4166.hostgator.com X-AntiAbuse: Original Domain - vger.kernel.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - embeddedor.com X-BWhitelist: no X-Source-IP: 189.250.65.56 X-Source-L: No X-Exim-ID: 1fYbib-003zmb-VO X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: (embeddedor) [189.250.65.56]:60484 X-Source-Auth: gustavo@embeddedor.com X-Email-Count: 4 X-Source-Cap: Z3V6aWRpbmU7Z3V6aWRpbmU7Z2F0b3I0MTY2Lmhvc3RnYXRvci5jb20= X-Local-Domain: yes Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org In preparation to enabling -Wimplicit-fallthrough, mark switch cases where we are expecting to fall through. Signed-off-by: Gustavo A. R. Silva --- drivers/usb/musb/musb_dsps.c | 2 +- drivers/usb/musb/musb_host.c | 1 + 2 files changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/usb/musb/musb_dsps.c b/drivers/usb/musb/musb_dsps.c index fb871ea..df827ff 100644 --- a/drivers/usb/musb/musb_dsps.c +++ b/drivers/usb/musb/musb_dsps.c @@ -237,7 +237,7 @@ static int dsps_check_status(struct musb *musb, void *unused) } musb_writeb(musb->mregs, MUSB_DEVCTL, 0); skip_session = 1; - /* fall */ + /* fall through */ case OTG_STATE_A_IDLE: case OTG_STATE_B_IDLE: diff --git a/drivers/usb/musb/musb_host.c b/drivers/usb/musb/musb_host.c index 8000c7c..b59ce9a 100644 --- a/drivers/usb/musb/musb_host.c +++ b/drivers/usb/musb/musb_host.c @@ -378,6 +378,7 @@ static void musb_advance_schedule(struct musb *musb, struct urb *urb, qh = first_qh(head); break; } + /* else: fall through */ case USB_ENDPOINT_XFER_ISOC: case USB_ENDPOINT_XFER_INT: -- 2.7.4