From mboxrd@z Thu Jan 1 00:00:00 1970 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Subject: USB: serial: io_edgeport: mark expected switch fall-throughs From: "Gustavo A. R. Silva" Message-Id: <20180628184030.GA23656@embeddedor.com> Date: Thu, 28 Jun 2018 13:40:30 -0500 To: Johan Hovold , Greg Kroah-Hartman Cc: linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org, "Gustavo A. R. Silva" List-ID: SW4gcHJlcGFyYXRpb24gdG8gZW5hYmxpbmcgLVdpbXBsaWNpdC1mYWxsdGhyb3VnaCwgbWFyayBz d2l0Y2ggY2FzZXMKd2hlcmUgd2UgYXJlIGV4cGVjdGluZyB0byBmYWxsIHRocm91Z2guCgpTaWdu ZWQtb2ZmLWJ5OiBHdXN0YXZvIEEuIFIuIFNpbHZhIDxndXN0YXZvQGVtYmVkZGVkb3IuY29tPgot LS0KIGRyaXZlcnMvdXNiL3NlcmlhbC9pb19lZGdlcG9ydC5jIHwgNCArKy0tCiAxIGZpbGUgY2hh bmdlZCwgMiBpbnNlcnRpb25zKCspLCAyIGRlbGV0aW9ucygtKQoKZGlmZiAtLWdpdCBhL2RyaXZl cnMvdXNiL3NlcmlhbC9pb19lZGdlcG9ydC5jIGIvZHJpdmVycy91c2Ivc2VyaWFsL2lvX2VkZ2Vw b3J0LmMKaW5kZXggOTdjNjlkMy4uNDQxZGFiNiAxMDA2NDQKLS0tIGEvZHJpdmVycy91c2Ivc2Vy aWFsL2lvX2VkZ2Vwb3J0LmMKKysrIGIvZHJpdmVycy91c2Ivc2VyaWFsL2lvX2VkZ2Vwb3J0LmMK QEAgLTE3NjAsNyArMTc2MCw3IEBAIHN0YXRpYyB2b2lkIHByb2Nlc3NfcmN2ZF9kYXRhKHN0cnVj dCBlZGdlcG9ydF9zZXJpYWwgKmVkZ2Vfc2VyaWFsLAogCQkJCWVkZ2Vfc2VyaWFsLT5yeFN0YXRl ID0gRVhQRUNUX0hEUjI7CiAJCQkJYnJlYWs7CiAJCQl9Ci0JCQkvKiBvdGhlcndpc2UsIGRyb3Ag b24gdGhyb3VnaCAqLworCQkJLyogZWxzZTogZmFsbCB0aHJvdWdoICovCiAJCWNhc2UgRVhQRUNU X0hEUjI6CiAJCQllZGdlX3NlcmlhbC0+cnhIZWFkZXIyID0gKmJ1ZmZlcjsKIAkJCSsrYnVmZmVy OwpAQCAtMTgyMCw3ICsxODIwLDcgQEAgc3RhdGljIHZvaWQgcHJvY2Vzc19yY3ZkX2RhdGEoc3Ry dWN0IGVkZ2Vwb3J0X3NlcmlhbCAqZWRnZV9zZXJpYWwsCiAJCQkJCWVkZ2Vfc2VyaWFsLT5yeFN0 YXRlID0gRVhQRUNUX0RBVEE7CiAJCQkJCWJyZWFrOwogCQkJCX0KLQkJCQkvKiBFbHNlLCBkcm9w IHRocm91Z2ggKi8KKwkJCQkvKiBlbHNlOiBmYWxsIHRocm91Z2ggKi8KIAkJCX0KIAkJY2FzZSBF WFBFQ1RfREFUQTogLyogRXhwZWN0IGRhdGEgKi8KIAkJCWlmIChidWZmZXJMZW5ndGggPCBlZGdl X3NlcmlhbC0+cnhCeXRlc1JlbWFpbmluZykgewo= From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_PASS,URIBL_BLOCKED,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6703DC43141 for ; Thu, 28 Jun 2018 18:40:47 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 298B0277D3 for ; Thu, 28 Jun 2018 18:40:47 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 298B0277D3 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=embeddedor.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1030555AbeF1Skp (ORCPT ); Thu, 28 Jun 2018 14:40:45 -0400 Received: from gateway22.websitewelcome.com ([192.185.46.156]:12912 "EHLO gateway22.websitewelcome.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S934003AbeF1Sko (ORCPT ); Thu, 28 Jun 2018 14:40:44 -0400 Received: from cm16.websitewelcome.com (cm16.websitewelcome.com [100.42.49.19]) by gateway22.websitewelcome.com (Postfix) with ESMTP id 9BEBB1A22E for ; Thu, 28 Jun 2018 13:40:43 -0500 (CDT) Received: from gator4166.hostgator.com ([108.167.133.22]) by cmsmtp with SMTP id YbqJfeM6caSeyYbqQfJqru; Thu, 28 Jun 2018 13:40:43 -0500 X-Authority-Reason: nr=8 Received: from [189.250.65.56] (port=60540 helo=embeddedor) by gator4166.hostgator.com with esmtpa (Exim 4.91) (envelope-from ) id 1fYbqJ-0044Pa-AE; Thu, 28 Jun 2018 13:40:31 -0500 Date: Thu, 28 Jun 2018 13:40:30 -0500 From: "Gustavo A. R. Silva" To: Johan Hovold , Greg Kroah-Hartman Cc: linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org, "Gustavo A. R. Silva" Subject: [PATCH] USB: serial: io_edgeport: mark expected switch fall-throughs Message-ID: <20180628184030.GA23656@embeddedor.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline User-Agent: Mutt/1.5.24 (2015-08-30) X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - gator4166.hostgator.com X-AntiAbuse: Original Domain - vger.kernel.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - embeddedor.com X-BWhitelist: no X-Source-IP: 189.250.65.56 X-Source-L: No X-Exim-ID: 1fYbqJ-0044Pa-AE X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: (embeddedor) [189.250.65.56]:60540 X-Source-Auth: gustavo@embeddedor.com X-Email-Count: 11 X-Source-Cap: Z3V6aWRpbmU7Z3V6aWRpbmU7Z2F0b3I0MTY2Lmhvc3RnYXRvci5jb20= X-Local-Domain: yes Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org In preparation to enabling -Wimplicit-fallthrough, mark switch cases where we are expecting to fall through. Signed-off-by: Gustavo A. R. Silva --- drivers/usb/serial/io_edgeport.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/usb/serial/io_edgeport.c b/drivers/usb/serial/io_edgeport.c index 97c69d3..441dab6 100644 --- a/drivers/usb/serial/io_edgeport.c +++ b/drivers/usb/serial/io_edgeport.c @@ -1760,7 +1760,7 @@ static void process_rcvd_data(struct edgeport_serial *edge_serial, edge_serial->rxState = EXPECT_HDR2; break; } - /* otherwise, drop on through */ + /* else: fall through */ case EXPECT_HDR2: edge_serial->rxHeader2 = *buffer; ++buffer; @@ -1820,7 +1820,7 @@ static void process_rcvd_data(struct edgeport_serial *edge_serial, edge_serial->rxState = EXPECT_DATA; break; } - /* Else, drop through */ + /* else: fall through */ } case EXPECT_DATA: /* Expect data */ if (bufferLength < edge_serial->rxBytesRemaining) { -- 2.7.4