From: Ivan Gorinov <ivan.gorinov@intel.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH v3] x86: Use microcode update from device tree for all processors
Date: Thu, 28 Jun 2018 14:06:52 -0700 [thread overview]
Message-ID: <20180628210652.GA19749@intel.com> (raw)
In-Reply-To: <CAEUhbmVBbhKnGMgGtWoujO9JmOrcNaky01G71PfQB+_=rs1zbw@mail.gmail.com>
On Tue, Jun 26, 2018 at 03:47:49PM +0800, Bin Meng wrote:
> Hi Ivan,
>
> On Fri, Jun 22, 2018 at 12:13 PM, Bin Meng <bmeng.cn@gmail.com> wrote:
> > Hi Ivan,
> >
> > On Fri, Jun 22, 2018 at 12:16 PM, Bin Meng <bmeng.cn@gmail.com> wrote:
> >> From: Ivan Gorinov <ivan.gorinov@intel.com>
> >>
> >> Built without a ROM image with FSP (u-boot.rom), the U-Boot loader applies
> >> the microcode update data block encoded in Device Tree to the bootstrap
> >> processor but not passed to the other CPUs when multiprocessing is enabled.
> >>
> >> If the bootstrap processor successfully performs a microcode update
> >> from Device Tree, use the same data block for the other processors.
> >>
> >> Signed-off-by: Ivan Gorinov <ivan.gorinov@intel.com>
> >> Reviewed-by: Bin Meng <bmeng.cn@gmail.com>
> >> [bmeng: fixed build errors on edison and qemu-x86]
> >> Signed-off-by: Bin Meng <bmeng.cn@gmail.com>
> >>
> >> ---
> >>
> >> Changes in v3:
> >> - don't change arch/x86/cpu/i386/cpu.c to fix build errors on edison and
> >> qemu-x86
> >>
> >
> > I don't think the update to arch/x86/cpu/i386/cpu.c in previous
> > version is needed as mp_params.microcode_pointer is not needed during
> > the MP boot. Please test this patch to see if it works on your board.
> >
> >> arch/x86/cpu/intel_common/car.S | 2 ++
> >> arch/x86/cpu/intel_common/microcode.c | 10 +++++++---
> >> arch/x86/include/asm/microcode.h | 1 +
> >> arch/x86/lib/fsp/fsp_car.S | 4 +++-
> >> 4 files changed, 13 insertions(+), 4 deletions(-)
>
> Did you get a chance to test this? If no issue, I will take this patch
> for v2018.07.
No issues. Thank you!
next prev parent reply other threads:[~2018-06-28 21:06 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-06-22 4:16 [U-Boot] [PATCH v3] x86: Use microcode update from device tree for all processors Bin Meng
2018-06-22 4:13 ` Bin Meng
2018-06-26 7:47 ` Bin Meng
2018-06-28 21:06 ` Ivan Gorinov [this message]
2018-06-29 8:53 ` Bin Meng
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180628210652.GA19749@intel.com \
--to=ivan.gorinov@intel.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.