From: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 1/2] wampcc: new package
Date: Thu, 28 Jun 2018 21:37:48 +0200 [thread overview]
Message-ID: <20180628213748.086bb791@windsurf> (raw)
In-Reply-To: <20180628135009.20421-1-neumann@teufel.de>
Hello,
I've applied, after fixing a few issues, see below.
On Thu, 28 Jun 2018 15:50:08 +0200, Sven Neumann wrote:
> Signed-off-by: Sven Neumann <neumann@teufel.de>
> ---
> package/Config.in | 1 +
> package/wampcc/Config.in | 19 +++++++++++++++++++
> package/wampcc/wampcc.hash | 3 +++
> package/wampcc/wampcc.mk | 14 ++++++++++++++
> 4 files changed, 37 insertions(+)
> create mode 100644 package/wampcc/Config.in
> create mode 100644 package/wampcc/wampcc.hash
> create mode 100644 package/wampcc/wampcc.mk
The entry to the DEVELOPERS file was still missing. I know it was in
your second patch, but the addition of wampcc to DEVELOPERS should have
been with this patch.
> diff --git a/package/wampcc/Config.in b/package/wampcc/Config.in
> new file mode 100644
> index 0000000000..e7cf6b26fd
> --- /dev/null
> +++ b/package/wampcc/Config.in
> @@ -0,0 +1,19 @@
> +config BR2_PACKAGE_WAMPCC
> + bool "wampcc"
> + depends on BR2_TOOLCHAIN_HAS_THREADS_NPTL # pthread_barrier_*
> + depends on BR2_USE_MMU # fork()
> + depends on !BR2_STATIC_LIBS
> + depends on BR2_TOOLCHAIN_HAS_SYNC_4
Those dependencies come from libuv, some instead of "fork()" and
"pthread_barrier_" which are the reason for libuv to have those
dependencies, we prefer to have the reason for wampcc to have those
dependencies, i.e the fact that it selects libuv. So:
depends on BR2_TOOLCHAIN_HAS_THREADS_NPTL # libuv
and so on.
Also, another dependency was missing: BR2_TOOLCHAIN_HAS_GCC_BUG_64735.
The C++ code uses std::shared_future, which doesn't work on gcc < 7.x
on some architectures.
As I said above, I fixed those issues and applied.
Thomas
--
Thomas Petazzoni, CTO, Bootlin (formerly Free Electrons)
Embedded Linux and Kernel engineering
https://bootlin.com
prev parent reply other threads:[~2018-06-28 19:37 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-06-26 9:53 [Buildroot] [PATCH] wampcc: new package Sven Neumann
2018-06-26 19:40 ` Thomas Petazzoni
2018-06-28 13:50 ` [Buildroot] [PATCH 1/2] " Sven Neumann
2018-06-28 13:50 ` [Buildroot] [PATCH 2/2] DEVELOPERS: add myself for wampcc Sven Neumann
2018-06-28 19:38 ` Thomas Petazzoni
2018-06-28 19:37 ` Thomas Petazzoni [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180628213748.086bb791@windsurf \
--to=thomas.petazzoni@bootlin.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.