From: Christoph Hellwig <hch@lst.de>
To: Ming Lei <ming.lei@redhat.com>
Cc: Jens Axboe <axboe@kernel.dk>,
linux-block@vger.kernel.org,
Kashyap Desai <kashyap.desai@broadcom.com>,
Laurence Oberman <loberman@redhat.com>,
Omar Sandoval <osandov@fb.com>, Christoph Hellwig <hch@lst.de>,
Bart Van Assche <bart.vanassche@wdc.com>
Subject: Re: [PATCH V2 1/3] blk-mq: use list_splice_tail_init() to insert requests
Date: Fri, 29 Jun 2018 10:34:48 +0200 [thread overview]
Message-ID: <20180629083448.GC15870@lst.de> (raw)
In-Reply-To: <20180629081252.13836-2-ming.lei@redhat.com>
On Fri, Jun 29, 2018 at 04:12:50PM +0800, Ming Lei wrote:
> list_splice_tail_init() is much more faster than inserting each
> request one by one, given all requets in 'list' belong to
> same sw queue and ctx->lock is required to insert requests.
Looks fine:
Reviewed-by: Christoph Hellwig <hch@lst.de>
We should still make the trace loop conditional, but than can be a
separate patch.
next prev parent reply other threads:[~2018-06-29 8:34 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-06-29 8:12 [PATCH V2 0/3] blk-mq: improve IO perf in case of none io sched Ming Lei
2018-06-29 8:12 ` [PATCH V2 1/3] blk-mq: use list_splice_tail_init() to insert requests Ming Lei
2018-06-29 8:34 ` Christoph Hellwig [this message]
2018-06-29 8:12 ` [PATCH V2 2/3] blk-mq: only attempt to merge bio if there is rq in sw queue Ming Lei
2018-06-29 8:35 ` Christoph Hellwig
2018-06-29 8:12 ` [PATCH V2 3/3] blk-mq: dequeue request one by one from sw queue iff hctx is busy Ming Lei
2018-06-29 8:39 ` Christoph Hellwig
2018-06-29 15:24 ` Ming Lei
2018-06-29 14:58 ` Jens Axboe
2018-06-29 15:34 ` Ming Lei
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180629083448.GC15870@lst.de \
--to=hch@lst.de \
--cc=axboe@kernel.dk \
--cc=bart.vanassche@wdc.com \
--cc=kashyap.desai@broadcom.com \
--cc=linux-block@vger.kernel.org \
--cc=loberman@redhat.com \
--cc=ming.lei@redhat.com \
--cc=osandov@fb.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.