Re: [Qemu-devel] [PATCH V9 11/20] qapi/migration.json: Rename COLO unknown mode to none mode.

["Dr. David Alan Gilbert" <dgilbert@redhat.com>]

* Eric Blake (eblake@redhat.com) wrote:
> On 06/27/2018 03:41 PM, Zhang Chen wrote:
> > From: Zhang Chen <chen.zhang@intel.com>
> > 
> > Suggested by Markus Armbruster rename COLO unknown mode to none mode.
> > 
> > Signed-off-by: Zhang Chen <chen.zhang@intel.com>
> > ---
> >   migration/colo-failover.c |  2 +-
> >   migration/colo.c          |  2 +-
> >   qapi/migration.json       | 10 +++++-----
> >   3 files changed, 7 insertions(+), 7 deletions(-)
> 
> >   # Since: 2.8
> >   ##
> >   { 'enum': 'COLOMode',
> > -  'data': [ 'unknown', 'primary', 'secondary'] }
> > +  'data': [ 'none', 'primary', 'secondary'] }
> 
> The deletion of 'unknown' could potentially be a user-visible regression
> visible if COLOMode were in a QMP command; but thankfully the generated
> qapi/qapi-introspect.c does not seem to cover this enum, so it just affects
> internal code for now.

Note that the migration capability to enable colo is still x-colo;
so I take that to mean we've still got a free hand to change any part of
the COLO interface until we're happy it's right.

Dave

> Reviewed-by: Eric Blake <eblake@redhat.com>
> 
> -- 
> Eric Blake, Principal Software Engineer
> Red Hat, Inc.           +1-919-301-3266
> Virtualization:  qemu.org | libvirt.org
--
Dr. David Alan Gilbert / dgilbert@redhat.com / Manchester, UK