From mboxrd@z Thu Jan 1 00:00:00 1970 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Subject: [1/4] ath9k: use irqsave() in USB's complete callback From: Kalle Valo Message-Id: <20180629115642.51C5160AFF@smtp.codeaurora.org> Date: Fri, 29 Jun 2018 11:56:42 +0000 (UTC) To: Sebastian Andrzej Siewior Cc: netdev@vger.kernel.org, linux-usb@vger.kernel.org, tglx@linutronix.de, "David S. Miller" , linux-wireless@vger.kernel.org, QCA ath9k Development List-ID: U2ViYXN0aWFuIEFuZHJ6ZWogU2lld2lvciA8YmlnZWFzeUBsaW51dHJvbml4LmRlPiB3cm90ZToK Cj4gVGhlIFVTQiBjb21wbGV0aW9uIGNhbGxiYWNrIGRvZXMgbm90IGRpc2FibGUgaW50ZXJydXB0 cyB3aGlsZSBhY3F1aXJpbmcKPiB0aGUgbG9jay4gV2Ugd2FudCB0byByZW1vdmUgdGhlIGxvY2Fs X2lycV9kaXNhYmxlKCkgaW52b2NhdGlvbiBmcm9tCj4gX191c2JfaGNkX2dpdmViYWNrX3VyYigp IGFuZCB0aGVyZWZvcmUgaXQgaXMgcmVxdWlyZWQgZm9yIHRoZSBjYWxsYmFjawo+IGhhbmRsZXIg dG8gZGlzYWJsZSB0aGUgaW50ZXJydXB0cyB3aGlsZSBhY3F1aXJpbmcgdGhlIGxvY2suCj4gVGhl IGNhbGxiYWNrIG1heSBiZSBpbnZva2VkIGVpdGhlciBpbiBJUlEgb3IgQkggY29udGV4dCBkZXBl bmRpbmcgb24gdGhlCj4gVVNCIGhvc3QgY29udHJvbGxlci4KPiBVc2UgdGhlIF9pcnFzYXZlKCkg dmFyaWFudCBvZiB0aGUgbG9ja2luZyBwcmltaXRpdmVzLgo+IAo+IENjOiBRQ0EgYXRoOWsgRGV2 ZWxvcG1lbnQgPGF0aDlrLWRldmVsQHFjYS5xdWFsY29tbS5jb20+Cj4gQ2M6IEthbGxlIFZhbG8g PGt2YWxvQGNvZGVhdXJvcmEub3JnPgo+IENjOiAiRGF2aWQgUy4gTWlsbGVyIiA8ZGF2ZW1AZGF2 ZW1sb2Z0Lm5ldD4KPiBDYzogbGludXgtd2lyZWxlc3NAdmdlci5rZXJuZWwub3JnCj4gU2lnbmVk LW9mZi1ieTogU2ViYXN0aWFuIEFuZHJ6ZWogU2lld2lvciA8YmlnZWFzeUBsaW51dHJvbml4LmRl Pgo+IFNpZ25lZC1vZmYtYnk6IEthbGxlIFZhbG8gPGt2YWxvQGNvZGVhdXJvcmEub3JnPgoKUGF0 Y2ggYXBwbGllZCB0byBhdGgtbmV4dCBicmFuY2ggb2YgYXRoLmdpdCwgdGhhbmtzLgoKODRhMGQ0 NjY5YzhmIGF0aDlrOiB1c2UgaXJxc2F2ZSgpIGluIFVTQidzIGNvbXBsZXRlIGNhbGxiYWNrCg== From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from smtp.codeaurora.org ([198.145.29.96]:54396 "EHLO smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933005AbeF2L4m (ORCPT ); Fri, 29 Jun 2018 07:56:42 -0400 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Subject: Re: [1/4] ath9k: use irqsave() in USB's complete callback From: Kalle Valo In-Reply-To: <20180620193648.25136-2-bigeasy@linutronix.de> References: <20180620193648.25136-2-bigeasy@linutronix.de> To: Sebastian Andrzej Siewior Cc: netdev@vger.kernel.org, linux-usb@vger.kernel.org, tglx@linutronix.de, "David S. Miller" , linux-wireless@vger.kernel.org, Sebastian Andrzej Siewior , QCA ath9k Development Message-Id: <20180629115642.51C5160AFF@smtp.codeaurora.org> (sfid-20180629_135655_266863_729E9AB6) Date: Fri, 29 Jun 2018 11:56:42 +0000 (UTC) Sender: linux-wireless-owner@vger.kernel.org List-ID: Sebastian Andrzej Siewior wrote: > The USB completion callback does not disable interrupts while acquiring > the lock. We want to remove the local_irq_disable() invocation from > __usb_hcd_giveback_urb() and therefore it is required for the callback > handler to disable the interrupts while acquiring the lock. > The callback may be invoked either in IRQ or BH context depending on the > USB host controller. > Use the _irqsave() variant of the locking primitives. > > Cc: QCA ath9k Development > Cc: Kalle Valo > Cc: "David S. Miller" > Cc: linux-wireless@vger.kernel.org > Signed-off-by: Sebastian Andrzej Siewior > Signed-off-by: Kalle Valo Patch applied to ath-next branch of ath.git, thanks. 84a0d4669c8f ath9k: use irqsave() in USB's complete callback -- https://patchwork.kernel.org/patch/10478601/ https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches