From: Cyril Hrubis <chrubis@suse.cz>
To: ltp@lists.linux.it
Subject: [LTP] [PATCH 1/1] tst_test.sh: Fix check for $TST_DEVICE
Date: Fri, 29 Jun 2018 15:49:46 +0200 [thread overview]
Message-ID: <20180629134945.GA13958@rei> (raw)
In-Reply-To: <20180628122944.3373-1-pvorel@suse.cz>
Hi!
> When tst_device acquire call fails, it outputs into stdout,
> therefore the content is actually help message.
> => Check for file presence rather than variable not being empty.
>
> Fixes: c5ac5d712 tst_test.sh: Make use of tst_device helper
Good catch, I guess that it also wouldn't harm if we changed the helper
to print the help message to stderr as well.
--
Cyril Hrubis
chrubis@suse.cz
next prev parent reply other threads:[~2018-06-29 13:49 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-06-28 12:29 [LTP] [PATCH 1/1] tst_test.sh: Fix check for $TST_DEVICE Petr Vorel
2018-06-28 19:59 ` Jan Stancek
2018-06-29 13:49 ` Cyril Hrubis [this message]
2018-06-29 15:22 ` Petr Vorel
2018-06-29 14:58 ` Petr Vorel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180629134945.GA13958@rei \
--to=chrubis@suse.cz \
--cc=ltp@lists.linux.it \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.