From mboxrd@z Thu Jan 1 00:00:00 1970 From: Rodrigo Vivi Subject: Re: [PATCH] drm/i915: abstract and document register picking macros Date: Fri, 29 Jun 2018 07:38:39 -0700 Message-ID: <20180629143839.GE5309@intel.com> References: <20180629102039.2435-1-jani.nikula@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by gabe.freedesktop.org (Postfix) with ESMTPS id A5E646F071 for ; Fri, 29 Jun 2018 14:38:45 +0000 (UTC) Content-Disposition: inline In-Reply-To: <20180629102039.2435-1-jani.nikula@intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Jani Nikula Cc: intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org T24gRnJpLCBKdW4gMjksIDIwMTggYXQgMDE6MjA6MzlQTSArMDMwMCwgSmFuaSBOaWt1bGEgd3Jv dGU6Cj4gVHJ5IHRvIGRlc2NyaWJlIHdoYXQgdGhlIHBpY2sgdmFyaWFudHMgZG8sIGFuZCB3aGlj aCB0byBwcmVmZXIuIE5vCj4gZnVuY3Rpb25hbCBjaGFuZ2VzLgo+IAo+IFNpZ25lZC1vZmYtYnk6 IEphbmkgTmlrdWxhIDxqYW5pLm5pa3VsYUBpbnRlbC5jb20+CgpSZXZpZXdlZC1ieTogUm9kcmln byBWaXZpIDxyb2RyaWdvLnZpdmlAaW50ZWwuY29tPgoKPiAKPiAtLS0KPiAKPiBMZXQgdGhlIG5h bWluZyBiaWtlc2hlZCBmZXN0IGJlZ2luIQo+IC0tLQo+ICBkcml2ZXJzL2dwdS9kcm0vaTkxNS9p OTE1X3JlZy5oIHwgMjggKysrKysrKysrKysrKysrKysrKysrKy0tLS0tLQo+ICAxIGZpbGUgY2hh bmdlZCwgMjIgaW5zZXJ0aW9ucygrKSwgNiBkZWxldGlvbnMoLSkKPiAKPiBkaWZmIC0tZ2l0IGEv ZHJpdmVycy9ncHUvZHJtL2k5MTUvaTkxNV9yZWcuaCBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2k5 MTVfcmVnLmgKPiBpbmRleCBjMzBjZmNkOTA3NTQuLjdkYzc3NDY4MjkyMiAxMDA2NDQKPiAtLS0g YS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pOTE1X3JlZy5oCj4gKysrIGIvZHJpdmVycy9ncHUvZHJt L2k5MTUvaTkxNV9yZWcuaAo+IEBAIC0xMzksMTkgKzEzOSwzNSBAQCBzdGF0aWMgaW5saW5lIGJv b2wgaTkxNV9tbWlvX3JlZ192YWxpZChpOTE1X3JlZ190IHJlZykKPiAgCXJldHVybiAhaTkxNV9t bWlvX3JlZ19lcXVhbChyZWcsIElOVkFMSURfTU1JT19SRUcpOwo+ICB9Cj4gIAo+ICsvKgo+ICsg KiBHaXZlbiB0aGUgZmlyc3QgdHdvIG51bWJlcnMgX19hIGFuZCBfX2Igb2YgYXJiaXRyYXJpbHkg bWFueSBldmVubHkgc3BhY2VkCj4gKyAqIG51bWJlcnMsIHBpY2sgdGhlIDAtYmFzZWQgX19pbmRl eCd0aCB2YWx1ZS4KPiArICoKPiArICogQWx3YXlzIHByZWZlciB0aGlzIG92ZXIgX1BJQ0soKSBp ZiB0aGUgbnVtYmVycyBhcmUgZXZlbmx5IHNwYWNlZC4KPiArICovCj4gKyNkZWZpbmUgX1BJQ0tf RVZFTihfX2luZGV4LCBfX2EsIF9fYikgKChfX2EpICsgKF9faW5kZXgpICogKChfX2IpIC0gKF9f YSkpKQo+ICsKPiArLyoKPiArICogR2l2ZW4gdGhlIGFyYml0cmFyeSBudW1iZXJzIGluIHZhcmFy Z3MsIHBpY2sgdGhlIDAtYmFzZWQgX19pbmRleCd0aCBudW1iZXIuCj4gKyAqCj4gKyAqIEFsd2F5 cyBwcmVmZXIgX1BJQ0tfRVZFTigpIG92ZXIgdGhpcyBpZiB0aGUgbnVtYmVycyBhcmUgZXZlbmx5 IHNwYWNlZC4KPiArICovCj4gICNkZWZpbmUgX1BJQ0soX19pbmRleCwgLi4uKSAoKChjb25zdCB1 MzIgW10peyBfX1ZBX0FSR1NfXyB9KVtfX2luZGV4XSkKPiAgCj4gLSNkZWZpbmUgX1BJUEUocGlw ZSwgYSwgYikgKChhKSArIChwaXBlKSAqICgoYikgLSAoYSkpKQo+ICsvKgo+ICsgKiBOYW1lZCBo ZWxwZXIgd3JhcHBlcnMgYXJvdW5kIF9QSUNLX0VWRU4oKSBhbmQgX1BJQ0soKS4KPiArICovCj4g KyNkZWZpbmUgX1BJUEUocGlwZSwgYSwgYikgX1BJQ0tfRVZFTihwaXBlLCBhLCBiKQo+ICAjZGVm aW5lIF9NTUlPX1BJUEUocGlwZSwgYSwgYikgX01NSU8oX1BJUEUocGlwZSwgYSwgYikpCj4gLSNk ZWZpbmUgX1BMQU5FKHBsYW5lLCBhLCBiKSBfUElQRShwbGFuZSwgYSwgYikKPiArI2RlZmluZSBf UExBTkUocGxhbmUsIGEsIGIpIF9QSUNLX0VWRU4ocGxhbmUsIGEsIGIpCj4gICNkZWZpbmUgX01N SU9fUExBTkUocGxhbmUsIGEsIGIpIF9NTUlPX1BJUEUocGxhbmUsIGEsIGIpCj4gLSNkZWZpbmUg X1RSQU5TKHRyYW4sIGEsIGIpICgoYSkgKyAodHJhbikgKiAoKGIpIC0gKGEpKSkKPiArI2RlZmlu ZSBfVFJBTlModHJhbiwgYSwgYikgX1BJQ0tfRVZFTih0cmFuLCBhLCBiKQo+ICAjZGVmaW5lIF9N TUlPX1RSQU5TKHRyYW4sIGEsIGIpIF9NTUlPKF9UUkFOUyh0cmFuLCBhLCBiKSkKPiAtI2RlZmlu ZSBfUE9SVChwb3J0LCBhLCBiKSAoKGEpICsgKHBvcnQpICogKChiKSAtIChhKSkpCj4gKyNkZWZp bmUgX1BPUlQocG9ydCwgYSwgYikgX1BJQ0tfRVZFTihwb3J0LCBhLCBiKQo+ICAjZGVmaW5lIF9N TUlPX1BPUlQocG9ydCwgYSwgYikgX01NSU8oX1BPUlQocG9ydCwgYSwgYikpCj4gICNkZWZpbmUg X01NSU9fUElQRTMocGlwZSwgYSwgYiwgYykgX01NSU8oX1BJQ0socGlwZSwgYSwgYiwgYykpCj4g ICNkZWZpbmUgX01NSU9fUE9SVDMocGlwZSwgYSwgYiwgYykgX01NSU8oX1BJQ0socGlwZSwgYSwg YiwgYykpCj4gLSNkZWZpbmUgX1BMTChwbGwsIGEsIGIpICgoYSkgKyAocGxsKSAqICgoYikgLSAo YSkpKQo+ICsjZGVmaW5lIF9QTEwocGxsLCBhLCBiKSBfUElDS19FVkVOKHBsbCwgYSwgYikKPiAg I2RlZmluZSBfTU1JT19QTEwocGxsLCBhLCBiKSBfTU1JTyhfUExMKHBsbCwgYSwgYikpCj4gICNk ZWZpbmUgX1BIWTMocGh5LCAuLi4pIF9QSUNLKHBoeSwgX19WQV9BUkdTX18pCj4gICNkZWZpbmUg X01NSU9fUEhZMyhwaHksIGEsIGIsIGMpIF9NTUlPKF9QSFkzKHBoeSwgYSwgYiwgYykpCj4gQEAg LTY4NzQsNyArNjg5MCw3IEBAIGVudW0gewo+ICAjZGVmaW5lIF9QU19FQ0NfU1RBVF8yQiAgICAg MHg2OEFEMAo+ICAjZGVmaW5lIF9QU19FQ0NfU1RBVF8xQyAgICAgMHg2OTFEMAo+ICAKPiAtI2Rl ZmluZSBfSUQoaWQsIGEsIGIpICgoYSkgKyAoaWQpICogKChiKSAtIChhKSkpCj4gKyNkZWZpbmUg X0lEKGlkLCBhLCBiKSBfUElDS19FVkVOKGlkLCBhLCBiKQo+ICAjZGVmaW5lIFNLTF9QU19DVFJM KHBpcGUsIGlkKSBfTU1JT19QSVBFKHBpcGUsICAgICAgICBcCj4gIAkJCV9JRChpZCwgX1BTXzFB X0NUUkwsIF9QU18yQV9DVFJMKSwgICAgICAgXAo+ICAJCQlfSUQoaWQsIF9QU18xQl9DVFJMLCBf UFNfMkJfQ1RSTCkpCj4gLS0gCj4gMi4xMS4wCj4gCj4gX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX18KPiBJbnRlbC1nZnggbWFpbGluZyBsaXN0Cj4gSW50ZWwt Z2Z4QGxpc3RzLmZyZWVkZXNrdG9wLm9yZwo+IGh0dHBzOi8vbGlzdHMuZnJlZWRlc2t0b3Aub3Jn L21haWxtYW4vbGlzdGluZm8vaW50ZWwtZ2Z4Cl9fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fCkludGVsLWdmeCBtYWlsaW5nIGxpc3QKSW50ZWwtZ2Z4QGxpc3Rz LmZyZWVkZXNrdG9wLm9yZwpodHRwczovL2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xp c3RpbmZvL2ludGVsLWdmeAo=