From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ville =?iso-8859-1?Q?Syrj=E4l=E4?= Subject: Re: [PATCH] drm: Use kvzalloc for allocating blob property memory Date: Fri, 29 Jun 2018 19:12:05 +0300 Message-ID: <20180629161205.GE5565@intel.com> References: <20180629142710.2069-1-michel@daenzer.net> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) by gabe.freedesktop.org (Postfix) with ESMTPS id 840096F0E2 for ; Fri, 29 Jun 2018 16:12:16 +0000 (UTC) Content-Disposition: inline In-Reply-To: <20180629142710.2069-1-michel@daenzer.net> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Michel =?iso-8859-1?Q?D=E4nzer?= Cc: David Airlie , linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org List-Id: dri-devel@lists.freedesktop.org T24gRnJpLCBKdW4gMjksIDIwMTggYXQgMDQ6Mjc6MTBQTSArMDIwMCwgTWljaGVsIETDpG56ZXIg d3JvdGU6Cj4gRnJvbTogTWljaGVsIETDpG56ZXIgPG1pY2hlbC5kYWVuemVyQGFtZC5jb20+Cj4g Cj4gVGhlIHByb3BlcnR5IHNpemUgbWF5IGJlIGNvbnRyb2xsZWQgYnkgdXNlcnNwYWNlLCBjYW4g YmUgbGFyZ2UgKEkndmUKPiBzZWVuIGZhaWx1cmUgd2l0aCBvcmRlciA0LCBpLmUuIDE2IHBhZ2Vz IC8gNjQgS0IpIGFuZCBkb2Vzbid0IG5lZWQgdG8gYmUKPiBwaHlzaWNhbGx5IGNvbnRpZ3VvdXMu CgpJIHdvbmRlciBpZiB3ZSBzaG91bGQgZW5mb3JjZSBzb21lIGtpbmQgb2YgcmVhc29uYWJsZSBs aW1pdApvbiB0aGUgYmxvYiBzaXplLiBMb29rcyBsaWtlIHdlIGFsbG93IGFueXRoaW5nIHVwIHRv ClVMT05HX01BWCBjdXJyZW50bHkuIFdlIGNhbid0IHRlbGwgYXQgY3JlYXRlYmxvYiB0aW1lIGhv dwp0aGUgdGhpbmcgaXMgZ29pbmcgdG8gYmUgdXNlZCwgc28gY2FuJ3QgaGF2ZSBhbnkga2luZApv ZiBwcm9wZXJ0eSBzcGVjaWZpYyBsaW1pdCB1bmZvcnR1bmF0ZWx5LgoKPiAKPiBTaWduZWQtb2Zm LWJ5OiBNaWNoZWwgRMOkbnplciA8bWljaGVsLmRhZW56ZXJAYW1kLmNvbT4KPiAtLS0KPiAgZHJp dmVycy9ncHUvZHJtL2RybV9wcm9wZXJ0eS5jIHwgNiArKystLS0KPiAgMSBmaWxlIGNoYW5nZWQs IDMgaW5zZXJ0aW9ucygrKSwgMyBkZWxldGlvbnMoLSkKPiAKPiBkaWZmIC0tZ2l0IGEvZHJpdmVy cy9ncHUvZHJtL2RybV9wcm9wZXJ0eS5jIGIvZHJpdmVycy9ncHUvZHJtL2RybV9wcm9wZXJ0eS5j Cj4gaW5kZXggMWY4MDMxZTMwZjUzLi5jZGIxMGY4ODVhNGYgMTAwNjQ0Cj4gLS0tIGEvZHJpdmVy cy9ncHUvZHJtL2RybV9wcm9wZXJ0eS5jCj4gKysrIGIvZHJpdmVycy9ncHUvZHJtL2RybV9wcm9w ZXJ0eS5jCj4gQEAgLTUzMiw3ICs1MzIsNyBAQCBzdGF0aWMgdm9pZCBkcm1fcHJvcGVydHlfZnJl ZV9ibG9iKHN0cnVjdCBrcmVmICprcmVmKQo+ICAKPiAgCWRybV9tb2RlX29iamVjdF91bnJlZ2lz dGVyKGJsb2ItPmRldiwgJmJsb2ItPmJhc2UpOwo+ICAKPiAtCWtmcmVlKGJsb2IpOwo+ICsJa3Zm cmVlKGJsb2IpOwo+ICB9Cj4gIAo+ICAvKioKPiBAQCAtNTU5LDcgKzU1OSw3IEBAIGRybV9wcm9w ZXJ0eV9jcmVhdGVfYmxvYihzdHJ1Y3QgZHJtX2RldmljZSAqZGV2LCBzaXplX3QgbGVuZ3RoLAo+ ICAJaWYgKCFsZW5ndGggfHwgbGVuZ3RoID4gVUxPTkdfTUFYIC0gc2l6ZW9mKHN0cnVjdCBkcm1f cHJvcGVydHlfYmxvYikpCj4gIAkJcmV0dXJuIEVSUl9QVFIoLUVJTlZBTCk7Cj4gIAo+IC0JYmxv YiA9IGt6YWxsb2Moc2l6ZW9mKHN0cnVjdCBkcm1fcHJvcGVydHlfYmxvYikrbGVuZ3RoLCBHRlBf S0VSTkVMKTsKPiArCWJsb2IgPSBrdnphbGxvYyhzaXplb2Yoc3RydWN0IGRybV9wcm9wZXJ0eV9i bG9iKStsZW5ndGgsIEdGUF9LRVJORUwpOwo+ICAJaWYgKCFibG9iKQo+ICAJCXJldHVybiBFUlJf UFRSKC1FTk9NRU0pOwo+ICAKPiBAQCAtNTc2LDcgKzU3Niw3IEBAIGRybV9wcm9wZXJ0eV9jcmVh dGVfYmxvYihzdHJ1Y3QgZHJtX2RldmljZSAqZGV2LCBzaXplX3QgbGVuZ3RoLAo+ICAJcmV0ID0g X19kcm1fbW9kZV9vYmplY3RfYWRkKGRldiwgJmJsb2ItPmJhc2UsIERSTV9NT0RFX09CSkVDVF9C TE9CLAo+ICAJCQkJICAgIHRydWUsIGRybV9wcm9wZXJ0eV9mcmVlX2Jsb2IpOwo+ICAJaWYgKHJl dCkgewo+IC0JCWtmcmVlKGJsb2IpOwo+ICsJCWt2ZnJlZShibG9iKTsKPiAgCQlyZXR1cm4gRVJS X1BUUigtRUlOVkFMKTsKPiAgCX0KPiAgCj4gLS0gCj4gMi4xOC4wCj4gCj4gX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KPiBkcmktZGV2ZWwgbWFpbGluZyBs aXN0Cj4gZHJpLWRldmVsQGxpc3RzLmZyZWVkZXNrdG9wLm9yZwo+IGh0dHBzOi8vbGlzdHMuZnJl ZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vZHJpLWRldmVsCgotLSAKVmlsbGUgU3lyasOk bMOkCkludGVsCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f CmRyaS1kZXZlbCBtYWlsaW5nIGxpc3QKZHJpLWRldmVsQGxpc3RzLmZyZWVkZXNrdG9wLm9yZwpo dHRwczovL2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2RyaS1kZXZlbAo= From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_PASS,URIBL_BLOCKED,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B295BC43141 for ; Fri, 29 Jun 2018 16:12:19 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 74F37250EE for ; Fri, 29 Jun 2018 16:12:19 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 74F37250EE Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linux.intel.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S936862AbeF2QMR (ORCPT ); Fri, 29 Jun 2018 12:12:17 -0400 Received: from mga04.intel.com ([192.55.52.120]:53559 "EHLO mga04.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S936537AbeF2QMQ (ORCPT ); Fri, 29 Jun 2018 12:12:16 -0400 X-Amp-Result: UNKNOWN X-Amp-Original-Verdict: FILE UNKNOWN X-Amp-File-Uploaded: False Received: from fmsmga008.fm.intel.com ([10.253.24.58]) by fmsmga104.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 29 Jun 2018 09:12:15 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.51,285,1526367600"; d="scan'208";a="51511896" Received: from stinkbox.fi.intel.com (HELO stinkbox) ([10.237.72.174]) by fmsmga008.fm.intel.com with SMTP; 29 Jun 2018 09:12:05 -0700 Received: by stinkbox (sSMTP sendmail emulation); Fri, 29 Jun 2018 19:12:05 +0300 Date: Fri, 29 Jun 2018 19:12:05 +0300 From: Ville =?iso-8859-1?Q?Syrj=E4l=E4?= To: Michel =?iso-8859-1?Q?D=E4nzer?= Cc: Gustavo Padovan , Maarten Lankhorst , Sean Paul , David Airlie , linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org Subject: Re: [PATCH] drm: Use kvzalloc for allocating blob property memory Message-ID: <20180629161205.GE5565@intel.com> References: <20180629142710.2069-1-michel@daenzer.net> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20180629142710.2069-1-michel@daenzer.net> User-Agent: Mutt/1.9.4 (2018-02-28) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Jun 29, 2018 at 04:27:10PM +0200, Michel Dänzer wrote: > From: Michel Dänzer > > The property size may be controlled by userspace, can be large (I've > seen failure with order 4, i.e. 16 pages / 64 KB) and doesn't need to be > physically contiguous. I wonder if we should enforce some kind of reasonable limit on the blob size. Looks like we allow anything up to ULONG_MAX currently. We can't tell at createblob time how the thing is going to be used, so can't have any kind of property specific limit unfortunately. > > Signed-off-by: Michel Dänzer > --- > drivers/gpu/drm/drm_property.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/drivers/gpu/drm/drm_property.c b/drivers/gpu/drm/drm_property.c > index 1f8031e30f53..cdb10f885a4f 100644 > --- a/drivers/gpu/drm/drm_property.c > +++ b/drivers/gpu/drm/drm_property.c > @@ -532,7 +532,7 @@ static void drm_property_free_blob(struct kref *kref) > > drm_mode_object_unregister(blob->dev, &blob->base); > > - kfree(blob); > + kvfree(blob); > } > > /** > @@ -559,7 +559,7 @@ drm_property_create_blob(struct drm_device *dev, size_t length, > if (!length || length > ULONG_MAX - sizeof(struct drm_property_blob)) > return ERR_PTR(-EINVAL); > > - blob = kzalloc(sizeof(struct drm_property_blob)+length, GFP_KERNEL); > + blob = kvzalloc(sizeof(struct drm_property_blob)+length, GFP_KERNEL); > if (!blob) > return ERR_PTR(-ENOMEM); > > @@ -576,7 +576,7 @@ drm_property_create_blob(struct drm_device *dev, size_t length, > ret = __drm_mode_object_add(dev, &blob->base, DRM_MODE_OBJECT_BLOB, > true, drm_property_free_blob); > if (ret) { > - kfree(blob); > + kvfree(blob); > return ERR_PTR(-EINVAL); > } > > -- > 2.18.0 > > _______________________________________________ > dri-devel mailing list > dri-devel@lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/dri-devel -- Ville Syrjälä Intel