From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jason Gunthorpe Subject: Re: [PATCH] IB/srpt: Support HCAs with more than two ports Date: Fri, 29 Jun 2018 11:20:25 -0600 Message-ID: <20180629172025.GF379@ziepe.ca> References: <20180626222448.11411-1-bart.vanassche@wdc.com> <20180629162059.GA21030@ziepe.ca> <82918f75-5624-acf5-9495-1fd76c4318d6@wdc.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <82918f75-5624-acf5-9495-1fd76c4318d6@wdc.com> Sender: stable-owner@vger.kernel.org To: Bart Van Assche Cc: Doug Ledford , "linux-rdma@vger.kernel.org" , Steve Wise , Christoph Hellwig , "stable@vger.kernel.org" List-Id: linux-rdma@vger.kernel.org On Fri, Jun 29, 2018 at 09:32:42AM -0700, Bart Van Assche wrote: > On 06/29/18 09:21, Jason Gunthorpe wrote: > >On Tue, Jun 26, 2018 at 03:24:48PM -0700, Bart Van Assche wrote: > >>Since there are adapters that have four ports, increase the size of > >>the srpt_device.port[] array. This patch avoids that the following > >>warning is hit with quad port Chelsio adapters: > >> > >> WARN_ON(sdev->device->phys_port_cnt > ARRAY_SIZE(sdev->port)); > >> > >>Reported-by: Steve Wise > >>Signed-off-by: Bart Van Assche > >>Cc: Steve Wise > >>Cc: Christoph Hellwig > >>Cc: > >> drivers/infiniband/ulp/srpt/ib_srpt.c | 6 +++--- > >> drivers/infiniband/ulp/srpt/ib_srpt.h | 2 +- > >> 2 files changed, 4 insertions(+), 4 deletions(-) > > > >Can we write it this way instead? More typesafe. > > Hello Jason, > > The patch you posted looks fine to me. Do you want me to add your > Signed-off-by after I have retested this patch when I repost it? If you can retest it today just send me a note and I'll use it as posted, otherwise yes please. Jason