All of lore.kernel.org
 help / color / mirror / Atom feed
From: Lukas Wunner <lukas@wunner.de>
To: Bjorn Helgaas <helgaas@kernel.org>
Cc: linux-pci@vger.kernel.org, linux-acpi@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH v1 1/2] PCI: Document patch submission hints
Date: Sat, 30 Jun 2018 00:26:06 +0200	[thread overview]
Message-ID: <20180629222606.GA4317@wunner.de> (raw)
In-Reply-To: <153030405971.57832.12860154795039493576.stgit@bhelgaas-glaptop.roam.corp.google.com>

On Fri, Jun 29, 2018 at 03:27:39PM -0500, Bjorn Helgaas wrote:
> +  - Wrap changelogs to fit in 80 columns when shown by "git show", which
> +    adds 4 spaces.  I use "textwidth=75" in vim.

I guess the ideal width is subjective, I usually wrap at 72 chars because
then you've got 4 blanks on either side when viewed with "git log", which
I find neater than maxing out the horizontal width.

In some cases I deliberately wrap at less than 72 chars or allow 73 chars
if it avoids vastly unequal widths in a paragraph.  Often when I later
doublecheck what you've committed, I find that you've rewrapped everything
to 75 chars and the result doesn't look as neat as I wanted it to be.
Not a big deal, but thought I'd mention it now that you're codifying this
"rule" somewhat more formally.

Lukas

  reply	other threads:[~2018-06-29 22:26 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-06-29 20:27 [PATCH v1 0/2] PCI: Add patch submission and ACPI FW/OS info Bjorn Helgaas
2018-06-29 20:27 ` [PATCH v1 1/2] PCI: Document patch submission hints Bjorn Helgaas
2018-06-29 22:26   ` Lukas Wunner [this message]
2018-07-01 17:45   ` Lukas Wunner
2018-07-12 15:59     ` Bjorn Helgaas
2018-07-30 14:31       ` Lukas Wunner
2018-07-30 21:56         ` Bjorn Helgaas
2018-06-29 20:27 ` [PATCH v1 2/2] PCI: Document ACPI description of PCI host bridges Bjorn Helgaas
2018-07-03  4:56   ` Sinan Kaya
2018-07-03  5:15   ` Sinan Kaya
2018-07-04  9:40   ` Rafael J. Wysocki
2018-07-04  9:40     ` Rafael J. Wysocki
2018-07-27 21:01     ` Bjorn Helgaas

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180629222606.GA4317@wunner.de \
    --to=lukas@wunner.de \
    --cc=helgaas@kernel.org \
    --cc=linux-acpi@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pci@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.