From mboxrd@z Thu Jan 1 00:00:00 1970 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Subject: [v2,1/4] Simplify usbnet_cdc_update_filter From: Greg Kroah-Hartman Message-Id: <20180701081550.GA7048@kroah.com> Date: Sun, 1 Jul 2018 10:15:50 +0200 To: Miguel =?iso-8859-1?Q?Rodr=EDguez_P=E9rez?= Cc: linux-usb@vger.kernel.org, netdev@vger.kernel.org List-ID: T24gU2F0LCBKdW4gMzAsIDIwMTggYXQgMDc6MzI6MjNQTSArMDIwMCwgTWlndWVsIFJvZHLDrWd1 ZXogUMOpcmV6IHdyb3RlOgo+IFJlbW92ZSBzb21lIHVubmVlZGVkIHZhcmlibGVzIHRvIG1ha2Ug dGhlIGNvZGUgZWFzaWVyIHRvIHJlYWQKPiBhbmQsIHJlcGxhY2UgdGhlIGdlbmVyaWMgdXNiX2Nv bnRyb2xfbXNnIGZ1bmN0aW9uIGZvciB0aGUKPiBtb3JlIHNwZWNpZmljIHVzYm5ldF93cml0ZV9j bWQuCj4gLS0tCj4gIGRyaXZlcnMvbmV0L3VzYi9jZGNfZXRoZXIuYyB8IDE1ICsrKysrLS0tLS0t LS0tLQo+ICAxIGZpbGUgY2hhbmdlZCwgNSBpbnNlcnRpb25zKCspLCAxMCBkZWxldGlvbnMoLSkK Ck5vbmUgb2YgeW91ciBwYXRjaGVzIGhhdmUgYSBzaWduZWQtb2ZmLWJ5IGxpbmUsIGFuZCB5b3Vy IHN1YmplY3QgbmVlZHMKd29yayBhcyB3ZWxsIChzZWUgb3RoZXIgcGF0Y2hlcyBmb3IgaG93IHRv IGRvIHRoaXMgd2l0aCB0aGUgY29ycmVjdApwcmVmaXguKQoKQWxzbyB3b3JrIG9uIGNjOiB0aGUg Y29ycmVjdCBwZW9wbGUsIHNjcmlwdHMvZ2V0X21haW50YWluZXIucGwgb24gdGhlCnBhdGNoIHdp bGwgdGVsbCB5b3UgdGhhdCwgYW5kIGFsc28gdXNlICdnaXQgc2VuZC1lbWFpbCcgdG8gcHJvcGVy bHkKdGhyZWFkIHRoZW0uCgp0aGFua3MsCgpncmVnIGstaAotLS0KVG8gdW5zdWJzY3JpYmUgZnJv bSB0aGlzIGxpc3Q6IHNlbmQgdGhlIGxpbmUgInVuc3Vic2NyaWJlIGxpbnV4LXVzYiIgaW4KdGhl IGJvZHkgb2YgYSBtZXNzYWdlIHRvIG1ham9yZG9tb0B2Z2VyLmtlcm5lbC5vcmcKTW9yZSBtYWpv cmRvbW8gaW5mbyBhdCAgaHR0cDovL3ZnZXIua2VybmVsLm9yZy9tYWpvcmRvbW8taW5mby5odG1s Cg== From mboxrd@z Thu Jan 1 00:00:00 1970 From: Greg KH Subject: Re: [PATCH v2 1/4] Simplify usbnet_cdc_update_filter Date: Sun, 1 Jul 2018 10:15:50 +0200 Message-ID: <20180701081550.GA7048@kroah.com> References: <634ae5d9-c969-15a6-1831-10bd0719fe59@det.uvigo.gal> Mime-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Transfer-Encoding: 8bit Cc: linux-usb@vger.kernel.org, netdev@vger.kernel.org To: Miguel =?iso-8859-1?Q?Rodr=EDguez_P=E9rez?= Return-path: Received: from mail.linuxfoundation.org ([140.211.169.12]:36994 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751861AbeGAIPx (ORCPT ); Sun, 1 Jul 2018 04:15:53 -0400 Content-Disposition: inline In-Reply-To: <634ae5d9-c969-15a6-1831-10bd0719fe59@det.uvigo.gal> Sender: netdev-owner@vger.kernel.org List-ID: On Sat, Jun 30, 2018 at 07:32:23PM +0200, Miguel Rodríguez Pérez wrote: > Remove some unneeded varibles to make the code easier to read > and, replace the generic usb_control_msg function for the > more specific usbnet_write_cmd. > --- > drivers/net/usb/cdc_ether.c | 15 +++++---------- > 1 file changed, 5 insertions(+), 10 deletions(-) None of your patches have a signed-off-by line, and your subject needs work as well (see other patches for how to do this with the correct prefix.) Also work on cc: the correct people, scripts/get_maintainer.pl on the patch will tell you that, and also use 'git send-email' to properly thread them. thanks, greg k-h