From: Jesper Nilsson <jesper.nilsson@axis.com>
To: Shawn Guo <shawn.guo@linaro.org>
Cc: Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>,
Bjorn Helgaas <bhelgaas@google.com>,
Pratyush Anand <pratyush.anand@gmail.com>,
Stanimir Varbanov <svarbanov@mm-sol.com>,
Jianguo Sun <sunjianguo1@huawei.com>,
Joao Pinto <Joao.Pinto@synopsys.com>,
Jesper Nilsson <jespern@axis.com>,
Thomas Petazzoni <thomas.petazzoni@bootlin.com>,
Murali Karicheri <m-karicheri2@ti.com>,
Lucas Stach <l.stach@pengutronix.de>,
Jingoo Han <jingoohan1@gmail.com>,
linux-pci@vger.kernel.org
Subject: Re: [PATCH v3 5/9] PCI: artpec6: Drop unnecessary root_bus_nr setting
Date: Mon, 2 Jul 2018 10:47:36 +0200 [thread overview]
Message-ID: <20180702084736.GH4333@axis.com> (raw)
In-Reply-To: <1530417291-30495-6-git-send-email-shawn.guo@linaro.org>
On Sun, Jul 01, 2018 at 11:54:47AM +0800, Shawn Guo wrote:
> Function dw_pcie_host_init() already initializes the root_bus_nr field
> of 'struct pcie_port', so the -1 assignment prior to calling
> dw_pcie_host_init() in platform specific driver is not really needed.
> Drop it.
>
> Signed-off-by: Shawn Guo <shawn.guo@linaro.org>
Acked-by: Jesper Nilsson <jesper.nilsson@axis.com>
> ---
> drivers/pci/controller/dwc/pcie-artpec6.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/pci/controller/dwc/pcie-artpec6.c b/drivers/pci/controller/dwc/pcie-artpec6.c
> index 321b56cfd5d0..128b182648b3 100644
> --- a/drivers/pci/controller/dwc/pcie-artpec6.c
> +++ b/drivers/pci/controller/dwc/pcie-artpec6.c
> @@ -399,7 +399,6 @@ static int artpec6_add_pcie_port(struct artpec6_pcie *artpec6_pcie,
> }
> }
>
> - pp->root_bus_nr = -1;
> pp->ops = &artpec6_pcie_host_ops;
>
> ret = dw_pcie_host_init(pp);
> --
> 1.9.1
/^JN - Jesper Nilsson
--
Jesper Nilsson -- jesper.nilsson@axis.com
next prev parent reply other threads:[~2018-07-02 8:47 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-01 3:54 [PATCH v3 0/9] PCI: dwc: Drop unnecessary root_bus_nr setting Shawn Guo
2018-07-01 3:54 ` [PATCH v3 1/9] PCI: exynos: " Shawn Guo
2018-07-04 16:21 ` Lorenzo Pieralisi
2018-07-05 19:40 ` Jingoo Han
2018-07-06 9:20 ` Lorenzo Pieralisi
2018-07-01 3:54 ` [PATCH v3 2/9] PCI: imx6: " Shawn Guo
2018-07-02 10:25 ` Lucas Stach
2018-07-01 3:54 ` [PATCH v3 3/9] PCI: keystone: " Shawn Guo
2018-07-04 16:23 ` Lorenzo Pieralisi
2018-07-01 3:54 ` [PATCH v3 4/9] PCI: armada8k: " Shawn Guo
2018-07-01 3:54 ` [PATCH v3 5/9] PCI: artpec6: " Shawn Guo
2018-07-02 8:47 ` Jesper Nilsson [this message]
2018-07-01 3:54 ` [PATCH v3 6/9] PCI: designware-plat: " Shawn Guo
2018-07-02 8:38 ` Gustavo Pimentel
2018-07-01 3:54 ` [PATCH v3 7/9] PCI: histb: " Shawn Guo
2018-07-01 3:54 ` [PATCH v3 8/9] PCI: qcom: " Shawn Guo
2018-07-01 3:54 ` [PATCH v3 9/9] PCI: spear13xx: " Shawn Guo
2018-07-13 13:20 ` [PATCH v3 0/9] PCI: dwc: " Lorenzo Pieralisi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180702084736.GH4333@axis.com \
--to=jesper.nilsson@axis.com \
--cc=Joao.Pinto@synopsys.com \
--cc=bhelgaas@google.com \
--cc=jespern@axis.com \
--cc=jingoohan1@gmail.com \
--cc=l.stach@pengutronix.de \
--cc=linux-pci@vger.kernel.org \
--cc=lorenzo.pieralisi@arm.com \
--cc=m-karicheri2@ti.com \
--cc=pratyush.anand@gmail.com \
--cc=shawn.guo@linaro.org \
--cc=sunjianguo1@huawei.com \
--cc=svarbanov@mm-sol.com \
--cc=thomas.petazzoni@bootlin.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.