From: David Hildenbrand <david@redhat.com>
To: qemu-devel@nongnu.org
Cc: qemu-ppc@nongnu.org, Eduardo Habkost <ehabkost@redhat.com>,
Igor Mammedov <imammedo@redhat.com>,
"Michael S . Tsirkin" <mst@redhat.com>,
Marcel Apfelbaum <marcel.apfelbaum@gmail.com>,
Paolo Bonzini <pbonzini@redhat.com>,
Richard Henderson <rth@twiddle.net>,
Xiao Guangrong <xiaoguangrong.eric@gmail.com>,
David Gibson <david@gibson.dropbear.id.au>,
Alexander Graf <agraf@suse.de>, Stefan Weil <sw@weilnetz.de>,
David Hildenbrand <david@redhat.com>
Subject: [Qemu-devel] [PATCH v3 0/4] pc-dimm: pre_plug "slot" and "addr" assignment
Date: Mon, 2 Jul 2018 11:37:51 +0200 [thread overview]
Message-ID: <20180702093755.7384-1-david@redhat.com> (raw)
As requested by Igor, assign and verify "slot" and "addr" in the
pre_plug handler. Factor out the compatibility handling/configuration
for detecting the alignment to be used when searching for an address
in guest physical memory for a memory device.
This is another part of the original series
[PATCH v4 00/14] MemoryDevice: use multi stage hotplug handlers
This refactoring is the last step before factoring out pre_plug, plug and
unplug logic of memory devices completely into memory-device.c
v2 -> v3:
- "util/oslib-win32: indicate alignment for qemu_anon_ram_alloc()"
-- take allocation granularity into account
-- drop comment
- "pc-dimm: assign and verify the "addr" property during pre_plug"
-- compat_align -> legacy_align
-- shortened align detection as proposed by Igor
-- trace address asignment in pre_plug
v1 -> v2:
- dropped "machine: factor out enforce_aligned_dimm into memory_device_align"
- dropped "pc-dimm/memory-device: detect alignment internally"
- added "util/oslib-win32: indicate alignment for qemu_anon_ram_alloc()"
-- indicate the alignment and therefor simplify compat handling for
Windows as we can ...
- added "pc: drop memory region alignment check for 0"
-- ... drop a check for memory_region_get_alignment(mr), allowing us to
factor out compat handling for pc DIMM/NVDIMM alignment in a clean way.
- "pc-dimm: assign and verify the "addr" property during pre_plug"
-- Default to "memory_region_get_alignment(mr)" if no compat alignment
has been specified.
David Hildenbrand (4):
pc-dimm: assign and verify the "slot" property during pre_plug
util/oslib-win32: indicate alignment for qemu_anon_ram_alloc()
pc: drop memory region alignment check for 0
pc-dimm: assign and verify the "addr" property during pre_plug
hw/i386/pc.c | 16 ++++-------
hw/mem/pc-dimm.c | 61 +++++++++++++++++++++-------------------
hw/ppc/spapr.c | 14 ++++++---
include/hw/mem/pc-dimm.h | 5 ++--
util/oslib-win32.c | 15 ++++++++--
5 files changed, 63 insertions(+), 48 deletions(-)
--
2.17.1
next reply other threads:[~2018-07-02 9:38 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-02 9:37 David Hildenbrand [this message]
2018-07-02 9:37 ` [Qemu-devel] [PATCH v3 1/4] pc-dimm: assign and verify the "slot" property during pre_plug David Hildenbrand
2018-07-03 8:10 ` Auger Eric
2018-07-02 9:37 ` [Qemu-devel] [PATCH v3 2/4] util/oslib-win32: indicate alignment for qemu_anon_ram_alloc() David Hildenbrand
2018-07-02 10:16 ` Igor Mammedov
2018-07-03 8:10 ` Auger Eric
2018-07-02 9:37 ` [Qemu-devel] [PATCH v3 3/4] pc: drop memory region alignment check for 0 David Hildenbrand
2018-07-03 8:10 ` Auger Eric
2018-07-02 9:37 ` [Qemu-devel] [PATCH v3 4/4] pc-dimm: assign and verify the "addr" property during pre_plug David Hildenbrand
2018-07-02 10:31 ` Igor Mammedov
2018-07-02 10:39 ` David Hildenbrand
2018-07-02 12:44 ` Igor Mammedov
2018-07-02 12:47 ` David Hildenbrand
2018-07-03 8:20 ` Auger Eric
2018-07-03 8:22 ` Auger Eric
2018-07-03 0:19 ` David Gibson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180702093755.7384-1-david@redhat.com \
--to=david@redhat.com \
--cc=agraf@suse.de \
--cc=david@gibson.dropbear.id.au \
--cc=ehabkost@redhat.com \
--cc=imammedo@redhat.com \
--cc=marcel.apfelbaum@gmail.com \
--cc=mst@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-ppc@nongnu.org \
--cc=rth@twiddle.net \
--cc=sw@weilnetz.de \
--cc=xiaoguangrong.eric@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.