All of lore.kernel.org
 help / color / mirror / Atom feed
From: Igor Mammedov <imammedo@redhat.com>
To: Stefan Berger <stefanb@linux.vnet.ibm.com>
Cc: "Marc-André Lureau" <marcandre.lureau@redhat.com>,
	qemu-devel@nongnu.org, "Eduardo Habkost" <ehabkost@redhat.com>,
	"Michael S. Tsirkin" <mst@redhat.com>,
	"Paolo Bonzini" <pbonzini@redhat.com>,
	"Richard Henderson" <rth@twiddle.net>
Subject: Re: [Qemu-devel] [PATCH v6 0/4] Add support for TPM Physical Presence interface
Date: Mon, 2 Jul 2018 13:57:46 +0200	[thread overview]
Message-ID: <20180702135746.717e668d@redhat.com> (raw)
In-Reply-To: <89c2a128-3679-8b44-f00a-7f94bd3bdf0d@linux.vnet.ibm.com>

On Fri, 29 Jun 2018 08:20:38 -0400
Stefan Berger <stefanb@linux.vnet.ibm.com> wrote:

> On 06/28/2018 01:26 PM, Marc-André Lureau wrote:
> > Hi,
> >
> > The following patches implement the TPM Physical Presence Interface
> > that allows a user to set a command via ACPI (sysfs entry in Linux)
> > that, upon the next reboot, the firmware looks for and acts upon by
> > sending sequences of commands to the TPM.
> >
> > A dedicated memory region is added to the TPM CRB & TIS devices, at
> > address/size 0xFED45000/0x400. A new "etc/tpm/config" fw_cfg entry
> > holds the location for that PPI region and some version details, to
> > allow for future flexibility.
> >
> > With the associated edk2/ovmf firmware, the Windows HLK "PPI 1.3" test
> > now runs successfully.
> >
> > It is based on previous work from Stefan Berger ("[PATCH v2 0/4]
> > Implement Physical Presence interface for TPM 1.2 and 2")
> >
> > The edk2 support is merged upstream.  
> 
> The least I could do now is test this... So, I tested this now with the 
> SeaBIOS support I have for this series. It's here:
> 
> https://github.com/stefanberger/seabios-tpm/tree/qemu-ppi.v6
> 
> It works fine with at least an attached TPM 1.2. I haven't tried TPM 2 
> yet but would not expect complications from QEMU level. A operation 
> request value put into Linux's PPI interface can be read back also after 
> a VM suspend / resume operation. The list of supported operations is 
> shown correctly (needs Linux extensions for TPM 2 operation values 
> beyond a certain number iirc). The request operation is executed 
> correctly and the response shows the last operation and its result. So 
> it seems to work fine.
> 
> 
>     Stefan
> 

Are there any instructions how to test it?

  reply	other threads:[~2018-07-02 11:57 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-06-28 17:26 [Qemu-devel] [PATCH v6 0/4] Add support for TPM Physical Presence interface Marc-André Lureau
2018-06-28 17:26 ` [Qemu-devel] [PATCH v6 1/4] tpm: add a "ppi" boolean property Marc-André Lureau
2018-06-28 17:26 ` [Qemu-devel] [PATCH v6 2/4] tpm: implement virtual memory device for TPM PPI Marc-André Lureau
2018-06-28 17:26 ` [Qemu-devel] [PATCH v6 3/4] acpi: add fw_cfg file for TPM and PPI virtual memory device Marc-André Lureau
2018-06-28 17:26 ` [Qemu-devel] [PATCH v6 4/4] acpi: build TPM Physical Presence interface Marc-André Lureau
2018-07-04 15:39   ` Igor Mammedov
2018-07-04 16:00     ` Marc-André Lureau
2018-07-11 16:25       ` Igor Mammedov
2018-07-13 18:46         ` Marc-André Lureau
2018-06-29 12:20 ` [Qemu-devel] [PATCH v6 0/4] Add support for " Stefan Berger
2018-07-02 11:57   ` Igor Mammedov [this message]
2018-07-02 14:54     ` Stefan Berger
2018-07-09 14:05       ` Igor Mammedov
2018-07-09 14:07         ` Stefan Berger
2018-07-09 15:35           ` Igor Mammedov
2018-07-09 16:02             ` Stefan Berger

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180702135746.717e668d@redhat.com \
    --to=imammedo@redhat.com \
    --cc=ehabkost@redhat.com \
    --cc=marcandre.lureau@redhat.com \
    --cc=mst@redhat.com \
    --cc=pbonzini@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=rth@twiddle.net \
    --cc=stefanb@linux.vnet.ibm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.