From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ville =?iso-8859-1?Q?Syrj=E4l=E4?= Subject: Re: [Intel-gfx] [PATCH] drm/atomic-helper: Use old/new state in drm_atomic_helper_commit_planes_on_crtc() Date: Mon, 2 Jul 2018 18:55:48 +0300 Message-ID: <20180702155548.GM5565@intel.com> References: <20180626204144.14769-1-ville.syrjala@linux.intel.com> <20180627085949.GD13978@phenom.ffwll.local> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Content-Disposition: inline In-Reply-To: <20180627085949.GD13978@phenom.ffwll.local> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Daniel Vetter Cc: intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org List-Id: dri-devel@lists.freedesktop.org T24gV2VkLCBKdW4gMjcsIDIwMTggYXQgMTA6NTk6NDlBTSArMDIwMCwgRGFuaWVsIFZldHRlciB3 cm90ZToKPiBPbiBUdWUsIEp1biAyNiwgMjAxOCBhdCAxMTo0MTo0NFBNICswMzAwLCBWaWxsZSBT eXJqYWxhIHdyb3RlOgo+ID4gRnJvbTogVmlsbGUgU3lyasOkbMOkIDx2aWxsZS5zeXJqYWxhQGxp bnV4LmludGVsLmNvbT4KPiA+IAo+ID4gVXBkYXRlIGRybV9hdG9taWNfaGVscGVyX2NvbW1pdF9w bGFuZXNfb25fY3J0YygpIHRvIHVzZSBleHBsaWNpdCBvbGQvbmV3Cj4gPiBzdGF0ZXMgaW5zdGVh ZCBvZiByZWx5aW5nIG9uIG9iai0+c3RhdGUuCj4gPiAKPiA+IFNpZ25lZC1vZmYtYnk6IFZpbGxl IFN5cmrDpGzDpCA8dmlsbGUuc3lyamFsYUBsaW51eC5pbnRlbC5jb20+Cj4gCj4gUmV2aWV3ZWQt Ynk6IERhbmllbCBWZXR0ZXIgPGRhbmllbC52ZXR0ZXJAZmZ3bGwuY2g+CgpUaGFuc2suIFB1c2hl ZCB0byBkcm0tbWlzYy1uZXh0LgoKPiAKPiA+IC0tLQo+ID4gIGRyaXZlcnMvZ3B1L2RybS9kcm1f YXRvbWljX2hlbHBlci5jIHwgMTUgKysrKysrKysrKy0tLS0tCj4gPiAgMSBmaWxlIGNoYW5nZWQs IDEwIGluc2VydGlvbnMoKyksIDUgZGVsZXRpb25zKC0pCj4gPiAKPiA+IGRpZmYgLS1naXQgYS9k cml2ZXJzL2dwdS9kcm0vZHJtX2F0b21pY19oZWxwZXIuYyBiL2RyaXZlcnMvZ3B1L2RybS9kcm1f YXRvbWljX2hlbHBlci5jCj4gPiBpbmRleCBlMDIyY2FjZGFlMzQuLjgwMDhhN2RlMmUxMCAxMDA2 NDQKPiA+IC0tLSBhL2RyaXZlcnMvZ3B1L2RybS9kcm1fYXRvbWljX2hlbHBlci5jCj4gPiArKysg Yi9kcml2ZXJzL2dwdS9kcm0vZHJtX2F0b21pY19oZWxwZXIuYwo+ID4gQEAgLTIzNDIsMTEgKzIz NDIsMTMgQEAgZHJtX2F0b21pY19oZWxwZXJfY29tbWl0X3BsYW5lc19vbl9jcnRjKHN0cnVjdCBk cm1fY3J0Y19zdGF0ZSAqb2xkX2NydGNfc3RhdGUpCj4gPiAgCWNvbnN0IHN0cnVjdCBkcm1fY3J0 Y19oZWxwZXJfZnVuY3MgKmNydGNfZnVuY3M7Cj4gPiAgCXN0cnVjdCBkcm1fY3J0YyAqY3J0YyA9 IG9sZF9jcnRjX3N0YXRlLT5jcnRjOwo+ID4gIAlzdHJ1Y3QgZHJtX2F0b21pY19zdGF0ZSAqb2xk X3N0YXRlID0gb2xkX2NydGNfc3RhdGUtPnN0YXRlOwo+ID4gKwlzdHJ1Y3QgZHJtX2NydGNfc3Rh dGUgKm5ld19jcnRjX3N0YXRlID0KPiA+ICsJCWRybV9hdG9taWNfZ2V0X25ld19jcnRjX3N0YXRl KG9sZF9zdGF0ZSwgY3J0Yyk7Cj4gPiAgCXN0cnVjdCBkcm1fcGxhbmUgKnBsYW5lOwo+ID4gIAl1 bnNpZ25lZCBwbGFuZV9tYXNrOwo+ID4gIAo+ID4gIAlwbGFuZV9tYXNrID0gb2xkX2NydGNfc3Rh dGUtPnBsYW5lX21hc2s7Cj4gPiAtCXBsYW5lX21hc2sgfD0gY3J0Yy0+c3RhdGUtPnBsYW5lX21h c2s7Cj4gPiArCXBsYW5lX21hc2sgfD0gbmV3X2NydGNfc3RhdGUtPnBsYW5lX21hc2s7Cj4gPiAg Cj4gPiAgCWNydGNfZnVuY3MgPSBjcnRjLT5oZWxwZXJfcHJpdmF0ZTsKPiA+ICAJaWYgKGNydGNf ZnVuY3MgJiYgY3J0Y19mdW5jcy0+YXRvbWljX2JlZ2luKQo+ID4gQEAgLTIzNTUsNiArMjM1Nyw4 IEBAIGRybV9hdG9taWNfaGVscGVyX2NvbW1pdF9wbGFuZXNfb25fY3J0YyhzdHJ1Y3QgZHJtX2Ny dGNfc3RhdGUgKm9sZF9jcnRjX3N0YXRlKQo+ID4gIAlkcm1fZm9yX2VhY2hfcGxhbmVfbWFzayhw bGFuZSwgY3J0Yy0+ZGV2LCBwbGFuZV9tYXNrKSB7Cj4gPiAgCQlzdHJ1Y3QgZHJtX3BsYW5lX3N0 YXRlICpvbGRfcGxhbmVfc3RhdGUgPQo+ID4gIAkJCWRybV9hdG9taWNfZ2V0X29sZF9wbGFuZV9z dGF0ZShvbGRfc3RhdGUsIHBsYW5lKTsKPiA+ICsJCXN0cnVjdCBkcm1fcGxhbmVfc3RhdGUgKm5l d19wbGFuZV9zdGF0ZSA9Cj4gPiArCQkJZHJtX2F0b21pY19nZXRfbmV3X3BsYW5lX3N0YXRlKG9s ZF9zdGF0ZSwgcGxhbmUpOwo+ID4gIAkJY29uc3Qgc3RydWN0IGRybV9wbGFuZV9oZWxwZXJfZnVu Y3MgKnBsYW5lX2Z1bmNzOwo+ID4gIAo+ID4gIAkJcGxhbmVfZnVuY3MgPSBwbGFuZS0+aGVscGVy X3ByaXZhdGU7Cj4gPiBAQCAtMjM2MiwxMyArMjM2NiwxNCBAQCBkcm1fYXRvbWljX2hlbHBlcl9j b21taXRfcGxhbmVzX29uX2NydGMoc3RydWN0IGRybV9jcnRjX3N0YXRlICpvbGRfY3J0Y19zdGF0 ZSkKPiA+ICAJCWlmICghb2xkX3BsYW5lX3N0YXRlIHx8ICFwbGFuZV9mdW5jcykKPiA+ICAJCQlj b250aW51ZTsKPiA+ICAKPiA+IC0JCVdBUk5fT04ocGxhbmUtPnN0YXRlLT5jcnRjICYmIHBsYW5l LT5zdGF0ZS0+Y3J0YyAhPSBjcnRjKTsKPiA+ICsJCVdBUk5fT04obmV3X3BsYW5lX3N0YXRlLT5j cnRjICYmCj4gPiArCQkJbmV3X3BsYW5lX3N0YXRlLT5jcnRjICE9IGNydGMpOwo+ID4gIAo+ID4g LQkJaWYgKGRybV9hdG9taWNfcGxhbmVfZGlzYWJsaW5nKG9sZF9wbGFuZV9zdGF0ZSwgcGxhbmUt PnN0YXRlKSAmJgo+ID4gKwkJaWYgKGRybV9hdG9taWNfcGxhbmVfZGlzYWJsaW5nKG9sZF9wbGFu ZV9zdGF0ZSwgbmV3X3BsYW5lX3N0YXRlKSAmJgo+ID4gIAkJICAgIHBsYW5lX2Z1bmNzLT5hdG9t aWNfZGlzYWJsZSkKPiA+ICAJCQlwbGFuZV9mdW5jcy0+YXRvbWljX2Rpc2FibGUocGxhbmUsIG9s ZF9wbGFuZV9zdGF0ZSk7Cj4gPiAtCQllbHNlIGlmIChwbGFuZS0+c3RhdGUtPmNydGMgfHwKPiA+ IC0JCQkgZHJtX2F0b21pY19wbGFuZV9kaXNhYmxpbmcob2xkX3BsYW5lX3N0YXRlLCBwbGFuZS0+ c3RhdGUpKQo+ID4gKwkJZWxzZSBpZiAobmV3X3BsYW5lX3N0YXRlLT5jcnRjIHx8Cj4gPiArCQkJ IGRybV9hdG9taWNfcGxhbmVfZGlzYWJsaW5nKG9sZF9wbGFuZV9zdGF0ZSwgbmV3X3BsYW5lX3N0 YXRlKSkKPiA+ICAJCQlwbGFuZV9mdW5jcy0+YXRvbWljX3VwZGF0ZShwbGFuZSwgb2xkX3BsYW5l X3N0YXRlKTsKPiA+ICAJfQo+ID4gIAo+ID4gLS0gCj4gPiAyLjE2LjQKPiA+IAo+ID4gX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KPiA+IEludGVsLWdmeCBt YWlsaW5nIGxpc3QKPiA+IEludGVsLWdmeEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKPiA+IGh0dHBz Oi8vbGlzdHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vaW50ZWwtZ2Z4Cj4gCj4g LS0gCj4gRGFuaWVsIFZldHRlcgo+IFNvZnR3YXJlIEVuZ2luZWVyLCBJbnRlbCBDb3Jwb3JhdGlv bgo+IGh0dHA6Ly9ibG9nLmZmd2xsLmNoCgotLSAKVmlsbGUgU3lyasOkbMOkCkludGVsCl9fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCmRyaS1kZXZlbCBtYWls aW5nIGxpc3QKZHJpLWRldmVsQGxpc3RzLmZyZWVkZXNrdG9wLm9yZwpodHRwczovL2xpc3RzLmZy ZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2RyaS1kZXZlbAo=