From mboxrd@z Thu Jan  1 00:00:00 1970
From: Andrew Lunn <andrew@lunn.ch>
Subject: Re: [PATCH net-next 01/10] r8169: add basic phylib support
Date: Mon, 2 Jul 2018 23:02:39 +0200
Message-ID: <20180702210239.GA12564@lunn.ch>
References: <096a5326-963c-9bef-6218-29fcde004111@gmail.com>
 <60049e7e-b86d-1968-cdfd-7e0f91a25b88@gmail.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Cc: David Miller <davem@davemloft.net>,
        Florian Fainelli <f.fainelli@gmail.com>,
        Realtek linux nic maintainers <nic_swsd@realtek.com>,
        "netdev@vger.kernel.org" <netdev@vger.kernel.org>
To: Heiner Kallweit <hkallweit1@gmail.com>
Return-path: <netdev-owner@vger.kernel.org>
Received: from vps0.lunn.ch ([185.16.172.187]:49689 "EHLO vps0.lunn.ch"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S1752391AbeGBVCp (ORCPT <rfc822;netdev@vger.kernel.org>);
        Mon, 2 Jul 2018 17:02:45 -0400
Content-Disposition: inline
In-Reply-To: <60049e7e-b86d-1968-cdfd-7e0f91a25b88@gmail.com>
Sender: netdev-owner@vger.kernel.org
List-ID: <netdev.vger.kernel.org>

> +static int r8169_mdio_read_reg(struct mii_bus *mii_bus, int phyaddr, int phyreg)
> +{
> +	struct rtl8169_private *tp = mii_bus->priv;
> +
> +	return rtl_readphy(tp, phyreg);

So there is no support for phyaddr?

It would be better to trap the phyaddr which are not supported and
return 0xffff.

       Andrew