From mboxrd@z Thu Jan  1 00:00:00 1970
From: Andrew Lunn <andrew@lunn.ch>
Subject: Re: [PATCH net-next 03/10] r8169: replace open-coded PHY soft reset
 with genphy_soft_reset
Date: Mon, 2 Jul 2018 23:08:06 +0200
Message-ID: <20180702210806.GC12564@lunn.ch>
References: <096a5326-963c-9bef-6218-29fcde004111@gmail.com>
 <ac6d5745-2c4c-d229-12f3-b6b45b95b8ed@gmail.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Cc: David Miller <davem@davemloft.net>,
        Florian Fainelli <f.fainelli@gmail.com>,
        Realtek linux nic maintainers <nic_swsd@realtek.com>,
        "netdev@vger.kernel.org" <netdev@vger.kernel.org>
To: Heiner Kallweit <hkallweit1@gmail.com>
Return-path: <netdev-owner@vger.kernel.org>
Received: from vps0.lunn.ch ([185.16.172.187]:49706 "EHLO vps0.lunn.ch"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S1751069AbeGBVIK (ORCPT <rfc822;netdev@vger.kernel.org>);
        Mon, 2 Jul 2018 17:08:10 -0400
Content-Disposition: inline
In-Reply-To: <ac6d5745-2c4c-d229-12f3-b6b45b95b8ed@gmail.com>
Sender: netdev-owner@vger.kernel.org
List-ID: <netdev.vger.kernel.org>

On Mon, Jul 02, 2018 at 09:36:58PM +0200, Heiner Kallweit wrote:
> Use genphy_soft_reset() instead of open-coding a PHY soft reset. We have
> to do an explicit PHY soft reset because some chips use the genphy driver
> which uses a no-op as soft_reset callback.
> 
> Signed-off-by: Heiner Kallweit <hkallweit1@gmail.com>

Reviewed-by: Andrew Lunn <andrew@lunn.ch>

    Andrew