From mboxrd@z Thu Jan  1 00:00:00 1970
From: Andrew Lunn <andrew@lunn.ch>
Subject: Re: [PATCH net-next 08/10] r8169: remove rtl8169_set_speed_xmii
Date: Mon, 2 Jul 2018 23:21:50 +0200
Message-ID: <20180702212150.GG12564@lunn.ch>
References: <096a5326-963c-9bef-6218-29fcde004111@gmail.com>
 <fb72a450-8f15-2f34-38ae-26c7c3a5d159@gmail.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Cc: David Miller <davem@davemloft.net>,
        Florian Fainelli <f.fainelli@gmail.com>,
        Realtek linux nic maintainers <nic_swsd@realtek.com>,
        "netdev@vger.kernel.org" <netdev@vger.kernel.org>
To: Heiner Kallweit <hkallweit1@gmail.com>
Return-path: <netdev-owner@vger.kernel.org>
Received: from vps0.lunn.ch ([185.16.172.187]:49735 "EHLO vps0.lunn.ch"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S1753403AbeGBVVx (ORCPT <rfc822;netdev@vger.kernel.org>);
        Mon, 2 Jul 2018 17:21:53 -0400
Content-Disposition: inline
In-Reply-To: <fb72a450-8f15-2f34-38ae-26c7c3a5d159@gmail.com>
Sender: netdev-owner@vger.kernel.org
List-ID: <netdev.vger.kernel.org>

> -		auto_nego |= ADVERTISE_PAUSE_CAP | ADVERTISE_PAUSE_ASYM;

This bit you probably want to keep. The PHY never says it support
Pause. The MAC needs to enable pause if the MAC supports pause.

       Andrew