From mboxrd@z Thu Jan 1 00:00:00 1970 From: Takahiro AKASHI Date: Tue, 3 Jul 2018 08:51:32 +0900 Subject: [U-Boot] [PATCH 1/1] ARM: qemu-arm: enable RTC In-Reply-To: <3036110f-231f-0bc9-8b26-9ece81443cb0@iki.fi> References: <20180628223416.29533-1-xypron.glpk@gmx.de> <3036110f-231f-0bc9-8b26-9ece81443cb0@iki.fi> Message-ID: <20180702235131.GR23681@linaro.org> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On Mon, Jul 02, 2018 at 07:07:55PM +0300, Tuomas Tynkkynen wrote: > Hi Heinrich, > > On 06/29/2018 01:34 AM, Heinrich Schuchardt wrote: > >QEMU provides an emulated ARM AMBA PrimeCell PL031 RTC. > > > >The patch sets the base address in the board include file according to the > >definition in hw/arm/virt.c of the QEMU source. It defines the Kconfig > >option for the existing driver, and enables the RTC driver in > >qemu_arm64_defconfig and qemu_arm_defconfig as well as the date command. > > > >We need an RTC to provide the GetTime() runtime service in the UEFI > >subsystem. > > > >Signed-off-by: Heinrich Schuchardt > >--- > > configs/qemu_arm64_defconfig | 2 ++ > > configs/qemu_arm_defconfig | 2 ++ > > drivers/rtc/Kconfig | 7 +++++++ > > include/configs/qemu-arm.h | 3 +++ > > 4 files changed, 14 insertions(+) > > > > Reviewed-by: Tuomas Tynkkynen > Tested-by: Tuomas Tynkkynen > > - Tuomas Well, it is a good time. Why not change the driver to driver model like below: * I intentionally leave CONFIG_DM_RTC not mandatory here * The patch may be split into two parts; one for rtc, the other for qemu-arm ---8<---