From: Tiwei Bie <tiwei.bie@intel.com>
To: Maxime Coquelin <maxime.coquelin@redhat.com>
Cc: zhihong.wang@intel.com, dev@dpdk.org
Subject: Re: [PATCH v3 1/7] vhost: use shadow used ring in dequeue path
Date: Tue, 3 Jul 2018 11:28:19 +0800 [thread overview]
Message-ID: <20180703032819.GA3041@debian> (raw)
In-Reply-To: <20180627144959.17277-2-maxime.coquelin@redhat.com>
On Wed, Jun 27, 2018 at 04:49:53PM +0200, Maxime Coquelin wrote:
[...]
> @@ -1164,8 +1136,7 @@ rte_vhost_dequeue_burst(int vid, uint16_t queue_id,
>
> if (mbuf_is_consumed(zmbuf->mbuf)) {
> used_idx = vq->last_used_idx++ & (vq->size - 1);
Above line and other `used_idx` related code in
this function should be removed too.
Apart from that,
Reviewed-by: Tiwei Bie <tiwei.bie@intel.com>
Thanks!
> - update_used_ring(dev, vq, used_idx,
> - zmbuf->desc_idx);
> + update_shadow_used_ring(vq, zmbuf->desc_idx, 0);
> nr_updated += 1;
>
> TAILQ_REMOVE(&vq->zmbuf_list, zmbuf, next);
[...]
next prev parent reply other threads:[~2018-07-03 3:28 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-06-27 14:49 [PATCH v3 0/7] vhost: generalize buffer vectors Maxime Coquelin
2018-06-27 14:49 ` [PATCH v3 1/7] vhost: use shadow used ring in dequeue path Maxime Coquelin
2018-07-03 3:28 ` Tiwei Bie [this message]
2018-07-03 5:53 ` Maxime Coquelin
2018-06-27 14:49 ` [PATCH v3 2/7] vhost: make gpa to hpa failure an error Maxime Coquelin
2018-07-03 4:45 ` Tiwei Bie
2018-07-03 5:51 ` Maxime Coquelin
2018-06-27 14:49 ` [PATCH v3 3/7] vhost: use buffer vectors in dequeue path Maxime Coquelin
2018-06-27 14:49 ` [PATCH v3 4/7] vhost: translate iovas at vectors fill time Maxime Coquelin
2018-06-27 14:49 ` [PATCH v3 5/7] vhost: improve prefetching in dequeue path Maxime Coquelin
2018-06-27 14:49 ` [PATCH v3 6/7] vhost: prefetch first descriptor " Maxime Coquelin
2018-06-27 14:49 ` [PATCH v3 7/7] vhost: improve prefetching in enqueue path Maxime Coquelin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180703032819.GA3041@debian \
--to=tiwei.bie@intel.com \
--cc=dev@dpdk.org \
--cc=maxime.coquelin@redhat.com \
--cc=zhihong.wang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.