From: Shawn Guo <shawnguo@kernel.org>
To: Fabio Estevam <festevam@gmail.com>
Cc: Peter Chen <Peter.Chen@nxp.com>,
USB list <linux-usb@vger.kernel.org>,
Andrey Smirnov <andrew.smirnov@gmail.com>,
Lucas Stach <l.stach@pengutronix.de>,
Sebastian Reichel <sebastian.reichel@collabora.co.uk>,
NXP Linux Team <linux-imx@nxp.com>,
Sascha Hauer <kernel@pengutronix.de>,
Fabio Estevam <fabio.estevam@nxp.com>
Subject: [v2] USB: chipidea: Do not hang when CONFIG_USB_CHIPIDEA_ULPI is not selected
Date: Tue, 3 Jul 2018 11:40:54 +0800 [thread overview]
Message-ID: <20180703034052.GB4348@dragon> (raw)
On Mon, Jul 02, 2018 at 11:22:55PM -0300, Fabio Estevam wrote:
> Hi Shawn,
>
> On Mon, Jul 2, 2018 at 11:06 PM, Shawn Guo <shawnguo@kernel.org> wrote:
>
> > A second thought on this - shouldn't such dependency be solved by
> > Kconfig select clause?
>
> I suspect we are not able to fix it via Kconfig as we really don't
> know if a system uses ULPI interface or not via Kconfig perspective.
>
> If we always select the chipidea ULPI driver, then it will be dead
> code for boards that do not use ULPI.
>
> Currently there are some defconfigs that explicitly select the
> chipidea ulpi driver:
>
> arch/arm/configs/qcom_defconfig:CONFIG_USB_CHIPIDEA_ULPI=y
> arch/arm64/configs/defconfig:CONFIG_USB_CHIPIDEA_ULPI=y
>
> I would be interested to get feedback whether it would be possible to
> fix it on a different way.
We can have the options in defconfig, but they can still be turned off
for whatever reason and we get the hang. Really, missing a user
selectable option in defconfig shouldn't result in a system hang.
Shawn
---
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next reply other threads:[~2018-07-03 3:40 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-03 3:40 Shawn Guo [this message]
-- strict thread matches above, loose matches on Subject: below --
2018-07-04 13:11 [v2] USB: chipidea: Do not hang when CONFIG_USB_CHIPIDEA_ULPI is not selected Fabio Estevam
2018-07-04 8:24 Peter Chen
2018-07-03 12:38 Shawn Guo
2018-07-03 10:52 Fabio Estevam
2018-07-03 2:22 Fabio Estevam
2018-07-03 2:06 Shawn Guo
2018-07-03 2:00 Fabio Estevam
2018-07-03 1:48 Shawn Guo
2018-07-02 11:52 Fabio Estevam
2018-07-02 3:08 Peter Chen
2018-06-27 4:10 Andrey Smirnov
2018-06-26 11:26 Fabio Estevam
2018-06-26 2:51 Peter Chen
2018-06-25 14:25 Fabio Estevam
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180703034052.GB4348@dragon \
--to=shawnguo@kernel.org \
--cc=Peter.Chen@nxp.com \
--cc=andrew.smirnov@gmail.com \
--cc=fabio.estevam@nxp.com \
--cc=festevam@gmail.com \
--cc=kernel@pengutronix.de \
--cc=l.stach@pengutronix.de \
--cc=linux-imx@nxp.com \
--cc=linux-usb@vger.kernel.org \
--cc=sebastian.reichel@collabora.co.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.