From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Return-Path: Date: Tue, 3 Jul 2018 08:04:16 +0100 From: Lee Jones To: Matthias Brugger Cc: matthias.bgg@kernel.org, ulrich.hecht+renesas@gmail.com, laurent.pinchart@ideasonboard.com, ck.hu@mediatek.com, p.zabel@pengutronix.de, airlied@linux.ie, robh+dt@kernel.org, mark.rutland@arm.com, mturquette@baylibre.com, sboyd@codeaurora.org, davem@davemloft.net, gregkh@linuxfoundation.org, mchehab@kernel.org, rdunlap@infradead.org, sean.wang@mediatek.com, linux-clk@vger.kernel.org, linux@armlinux.org.uk, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, Matthias Brugger Subject: Re: [v3 01/10] dt-bindings: mediatek: mmsys: Add support for mfd Message-ID: <20180703070416.GD20176@dell> References: <64ca273429d92f581568a48f3efe6035af65f579.1524820923.git.mbrugger@suse.com> <20180430103029.GD5147@dell> <4ead47f6-2f69-2afa-bfcc-a240a9845dc4@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 In-Reply-To: <4ead47f6-2f69-2afa-bfcc-a240a9845dc4@gmail.com> List-ID: On Mon, 25 Jun 2018, Matthias Brugger wrote: > > > On 30/04/18 12:30, Lee Jones wrote: > > On Fri, 27 Apr 2018, matthias.bgg@kernel.org wrote: > > > >> From: Matthias Brugger > >> > >> Add binding description for the mmsys mfd for some Mediatek > >> devices. mmsys has some registers to control clock gates (which is > >> used in the clk driver) and some registers to set the routing and enable > >> the differnet blocks of the display subsystem. > >> > >> Signed-off-by: Matthias Brugger > >> --- > >> .../bindings/arm/mediatek/mediatek,mmsys.txt | 2 -- > >> .../bindings/display/mediatek/mediatek,disp.txt | 2 +- > >> .../devicetree/bindings/mfd/mediatek,mmsys.txt | 27 ++++++++++++++++++++++ > >> 3 files changed, 28 insertions(+), 3 deletions(-) > >> create mode 100644 Documentation/devicetree/bindings/mfd/mediatek,mmsys.txt > >> > >> diff --git a/Documentation/devicetree/bindings/arm/mediatek/mediatek,mmsys.txt b/Documentation/devicetree/bindings/arm/mediatek/mediatek,mmsys.txt > >> index 4eb8bbe15c01..4468345f8b1a 100644 > >> --- a/Documentation/devicetree/bindings/arm/mediatek/mediatek,mmsys.txt > >> +++ b/Documentation/devicetree/bindings/arm/mediatek/mediatek,mmsys.txt > >> @@ -6,10 +6,8 @@ The Mediatek mmsys controller provides various clocks to the system. > >> Required Properties: > >> > >> - compatible: Should be one of: > >> - - "mediatek,mt2701-mmsys", "syscon" > >> - "mediatek,mt2712-mmsys", "syscon" > >> - "mediatek,mt6797-mmsys", "syscon" > >> - - "mediatek,mt8173-mmsys", "syscon" > >> - #clock-cells: Must be 1 > >> > >> The mmsys controller uses the common clk binding from > >> diff --git a/Documentation/devicetree/bindings/display/mediatek/mediatek,disp.txt b/Documentation/devicetree/bindings/display/mediatek/mediatek,disp.txt > >> index 383183a89164..85a3b4ec06cd 100644 > >> --- a/Documentation/devicetree/bindings/display/mediatek/mediatek,disp.txt > >> +++ b/Documentation/devicetree/bindings/display/mediatek/mediatek,disp.txt > >> @@ -9,7 +9,7 @@ function block. > >> > >> All DISP device tree nodes must be siblings to the central MMSYS_CONFIG node. > >> For a description of the MMSYS_CONFIG binding, see > >> -Documentation/devicetree/bindings/arm/mediatek/mediatek,mmsys.txt. > >> +Documentation/devicetree/bindings/mfd/mediatek,mmsys.txt > >> > >> DISP function blocks > >> ==================== > >> diff --git a/Documentation/devicetree/bindings/mfd/mediatek,mmsys.txt b/Documentation/devicetree/bindings/mfd/mediatek,mmsys.txt > >> new file mode 100644 > >> index 000000000000..2331ae16917e > >> --- /dev/null > >> +++ b/Documentation/devicetree/bindings/mfd/mediatek,mmsys.txt > >> @@ -0,0 +1,27 @@ > >> +MediaTek MMSYS Multifunction Device Driver > > > > What is "MMSYS"? > > > > "Multi-Function Driver"s are specific to Linux. > > > > What actually is the device? > > It's includes all the DRM parts of the SoC together with the clocks for the > device. MMSYS IMHO stands for Multi-Media-System. Please update the document with that information. Is there a datasheet I can view? > >> +MMSYS is a multifunction device with the following sub modules: > >> +- clocks for the multi-media subsystem > >> +- central node for the DRM subsystem. > >> + > >> +This document describes the binding for MFD device. The MFD takes care to initailize > >> +the clock driver and the DRM driver. More info see > >> +Documentation/devicetree/bindings/display/mediatek/mediatek,disp.txt > >> + > >> +Required properties: > >> +- compatible: Should be one of: > >> + - "mediatek,mt2701-mmsys", "syscon" > >> + - "mediatek,mt8173-mmsys", "syscon" > >> +- #clock-cells: Must be 1 > >> + > >> +Optional properties: > >> +- power-domains: list of powerdomains needed for the subsystem to work > >> + > >> +Example: > >> + > >> +mmsys: clock-controller@14000000 { > >> + compatible = "mediatek,mt8173-mmsys", "syscon"; > >> + reg = <0 0x14000000 0 0x1000>; > >> + power-domains = <&scpsys MT8173_POWER_DOMAIN_MM>; > >> + #clock-cells = <1>; > >> +}; > > -- Lee Jones [李琼斯] Linaro Services Technical Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog From mboxrd@z Thu Jan 1 00:00:00 1970 From: Lee Jones Subject: Re: [v3 01/10] dt-bindings: mediatek: mmsys: Add support for mfd Date: Tue, 3 Jul 2018 08:04:16 +0100 Message-ID: <20180703070416.GD20176@dell> References: <64ca273429d92f581568a48f3efe6035af65f579.1524820923.git.mbrugger@suse.com> <20180430103029.GD5147@dell> <4ead47f6-2f69-2afa-bfcc-a240a9845dc4@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Content-Disposition: inline In-Reply-To: <4ead47f6-2f69-2afa-bfcc-a240a9845dc4@gmail.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Matthias Brugger Cc: mark.rutland@arm.com, airlied@linux.ie, mturquette@baylibre.com, dri-devel@lists.freedesktop.org, laurent.pinchart@ideasonboard.com, ulrich.hecht+renesas@gmail.com, linux-clk@vger.kernel.org, linux@armlinux.org.uk, sean.wang@mediatek.com, robh+dt@kernel.org, linux-mediatek@lists.infradead.org, mchehab@kernel.org, linux-arm-kernel@lists.infradead.org, Matthias Brugger , gregkh@linuxfoundation.org, rdunlap@infradead.org, sboyd@codeaurora.org, linux-kernel@vger.kernel.org, matthias.bgg@kernel.org, davem@davemloft.net List-Id: linux-mediatek@lists.infradead.org T24gTW9uLCAyNSBKdW4gMjAxOCwgTWF0dGhpYXMgQnJ1Z2dlciB3cm90ZToKCj4gCj4gCj4gT24g MzAvMDQvMTggMTI6MzAsIExlZSBKb25lcyB3cm90ZToKPiA+IE9uIEZyaSwgMjcgQXByIDIwMTgs IG1hdHRoaWFzLmJnZ0BrZXJuZWwub3JnIHdyb3RlOgo+ID4gCj4gPj4gRnJvbTogTWF0dGhpYXMg QnJ1Z2dlciA8bWJydWdnZXJAc3VzZS5jb20+Cj4gPj4KPiA+PiBBZGQgYmluZGluZyBkZXNjcmlw dGlvbiBmb3IgdGhlIG1tc3lzIG1mZCBmb3Igc29tZSBNZWRpYXRlawo+ID4+IGRldmljZXMuIG1t c3lzIGhhcyBzb21lIHJlZ2lzdGVycyB0byBjb250cm9sIGNsb2NrIGdhdGVzICh3aGljaCBpcwo+ ID4+IHVzZWQgaW4gdGhlIGNsayBkcml2ZXIpIGFuZCBzb21lIHJlZ2lzdGVycyB0byBzZXQgdGhl IHJvdXRpbmcgYW5kIGVuYWJsZQo+ID4+IHRoZSBkaWZmZXJuZXQgYmxvY2tzIG9mIHRoZSBkaXNw bGF5IHN1YnN5c3RlbS4KPiA+Pgo+ID4+IFNpZ25lZC1vZmYtYnk6IE1hdHRoaWFzIEJydWdnZXIg PG1icnVnZ2VyQHN1c2UuY29tPgo+ID4+IC0tLQo+ID4+ICAuLi4vYmluZGluZ3MvYXJtL21lZGlh dGVrL21lZGlhdGVrLG1tc3lzLnR4dCAgICAgICB8ICAyIC0tCj4gPj4gIC4uLi9iaW5kaW5ncy9k aXNwbGF5L21lZGlhdGVrL21lZGlhdGVrLGRpc3AudHh0ICAgIHwgIDIgKy0KPiA+PiAgLi4uL2Rl dmljZXRyZWUvYmluZGluZ3MvbWZkL21lZGlhdGVrLG1tc3lzLnR4dCAgICAgfCAyNyArKysrKysr KysrKysrKysrKysrKysrCj4gPj4gIDMgZmlsZXMgY2hhbmdlZCwgMjggaW5zZXJ0aW9ucygrKSwg MyBkZWxldGlvbnMoLSkKPiA+PiAgY3JlYXRlIG1vZGUgMTAwNjQ0IERvY3VtZW50YXRpb24vZGV2 aWNldHJlZS9iaW5kaW5ncy9tZmQvbWVkaWF0ZWssbW1zeXMudHh0Cj4gPj4KPiA+PiBkaWZmIC0t Z2l0IGEvRG9jdW1lbnRhdGlvbi9kZXZpY2V0cmVlL2JpbmRpbmdzL2FybS9tZWRpYXRlay9tZWRp YXRlayxtbXN5cy50eHQgYi9Eb2N1bWVudGF0aW9uL2RldmljZXRyZWUvYmluZGluZ3MvYXJtL21l ZGlhdGVrL21lZGlhdGVrLG1tc3lzLnR4dAo+ID4+IGluZGV4IDRlYjhiYmUxNWMwMS4uNDQ2ODM0 NWY4YjFhIDEwMDY0NAo+ID4+IC0tLSBhL0RvY3VtZW50YXRpb24vZGV2aWNldHJlZS9iaW5kaW5n cy9hcm0vbWVkaWF0ZWsvbWVkaWF0ZWssbW1zeXMudHh0Cj4gPj4gKysrIGIvRG9jdW1lbnRhdGlv bi9kZXZpY2V0cmVlL2JpbmRpbmdzL2FybS9tZWRpYXRlay9tZWRpYXRlayxtbXN5cy50eHQKPiA+ PiBAQCAtNiwxMCArNiw4IEBAIFRoZSBNZWRpYXRlayBtbXN5cyBjb250cm9sbGVyIHByb3ZpZGVz IHZhcmlvdXMgY2xvY2tzIHRvIHRoZSBzeXN0ZW0uCj4gPj4gIFJlcXVpcmVkIFByb3BlcnRpZXM6 Cj4gPj4gIAo+ID4+ICAtIGNvbXBhdGlibGU6IFNob3VsZCBiZSBvbmUgb2Y6Cj4gPj4gLQktICJt ZWRpYXRlayxtdDI3MDEtbW1zeXMiLCAic3lzY29uIgo+ID4+ICAJLSAibWVkaWF0ZWssbXQyNzEy LW1tc3lzIiwgInN5c2NvbiIKPiA+PiAgCS0gIm1lZGlhdGVrLG10Njc5Ny1tbXN5cyIsICJzeXNj b24iCj4gPj4gLQktICJtZWRpYXRlayxtdDgxNzMtbW1zeXMiLCAic3lzY29uIgo+ID4+ICAtICNj bG9jay1jZWxsczogTXVzdCBiZSAxCj4gPj4gIAo+ID4+ICBUaGUgbW1zeXMgY29udHJvbGxlciB1 c2VzIHRoZSBjb21tb24gY2xrIGJpbmRpbmcgZnJvbQo+ID4+IGRpZmYgLS1naXQgYS9Eb2N1bWVu dGF0aW9uL2RldmljZXRyZWUvYmluZGluZ3MvZGlzcGxheS9tZWRpYXRlay9tZWRpYXRlayxkaXNw LnR4dCBiL0RvY3VtZW50YXRpb24vZGV2aWNldHJlZS9iaW5kaW5ncy9kaXNwbGF5L21lZGlhdGVr L21lZGlhdGVrLGRpc3AudHh0Cj4gPj4gaW5kZXggMzgzMTgzYTg5MTY0Li44NWEzYjRlYzA2Y2Qg MTAwNjQ0Cj4gPj4gLS0tIGEvRG9jdW1lbnRhdGlvbi9kZXZpY2V0cmVlL2JpbmRpbmdzL2Rpc3Bs YXkvbWVkaWF0ZWsvbWVkaWF0ZWssZGlzcC50eHQKPiA+PiArKysgYi9Eb2N1bWVudGF0aW9uL2Rl dmljZXRyZWUvYmluZGluZ3MvZGlzcGxheS9tZWRpYXRlay9tZWRpYXRlayxkaXNwLnR4dAo+ID4+ IEBAIC05LDcgKzksNyBAQCBmdW5jdGlvbiBibG9jay4KPiA+PiAgCj4gPj4gIEFsbCBESVNQIGRl dmljZSB0cmVlIG5vZGVzIG11c3QgYmUgc2libGluZ3MgdG8gdGhlIGNlbnRyYWwgTU1TWVNfQ09O RklHIG5vZGUuCj4gPj4gIEZvciBhIGRlc2NyaXB0aW9uIG9mIHRoZSBNTVNZU19DT05GSUcgYmlu ZGluZywgc2VlCj4gPj4gLURvY3VtZW50YXRpb24vZGV2aWNldHJlZS9iaW5kaW5ncy9hcm0vbWVk aWF0ZWsvbWVkaWF0ZWssbW1zeXMudHh0Lgo+ID4+ICtEb2N1bWVudGF0aW9uL2RldmljZXRyZWUv YmluZGluZ3MvbWZkL21lZGlhdGVrLG1tc3lzLnR4dAo+ID4+ICAKPiA+PiAgRElTUCBmdW5jdGlv biBibG9ja3MKPiA+PiAgPT09PT09PT09PT09PT09PT09PT0KPiA+PiBkaWZmIC0tZ2l0IGEvRG9j dW1lbnRhdGlvbi9kZXZpY2V0cmVlL2JpbmRpbmdzL21mZC9tZWRpYXRlayxtbXN5cy50eHQgYi9E b2N1bWVudGF0aW9uL2RldmljZXRyZWUvYmluZGluZ3MvbWZkL21lZGlhdGVrLG1tc3lzLnR4dAo+ ID4+IG5ldyBmaWxlIG1vZGUgMTAwNjQ0Cj4gPj4gaW5kZXggMDAwMDAwMDAwMDAwLi4yMzMxYWUx NjkxN2UKPiA+PiAtLS0gL2Rldi9udWxsCj4gPj4gKysrIGIvRG9jdW1lbnRhdGlvbi9kZXZpY2V0 cmVlL2JpbmRpbmdzL21mZC9tZWRpYXRlayxtbXN5cy50eHQKPiA+PiBAQCAtMCwwICsxLDI3IEBA Cj4gPj4gK01lZGlhVGVrIE1NU1lTIE11bHRpZnVuY3Rpb24gRGV2aWNlIERyaXZlcgo+ID4gCj4g PiBXaGF0IGlzICJNTVNZUyI/Cj4gPiAKPiA+ICJNdWx0aS1GdW5jdGlvbiBEcml2ZXIicyBhcmUg c3BlY2lmaWMgdG8gTGludXguCj4gPiAKPiA+IFdoYXQgYWN0dWFsbHkgaXMgdGhlIGRldmljZT8K PiAKPiBJdCdzIGluY2x1ZGVzIGFsbCB0aGUgRFJNIHBhcnRzIG9mIHRoZSBTb0MgdG9nZXRoZXIg d2l0aCB0aGUgY2xvY2tzIGZvciB0aGUKPiBkZXZpY2UuIE1NU1lTIElNSE8gc3RhbmRzIGZvciBN dWx0aS1NZWRpYS1TeXN0ZW0uCgpQbGVhc2UgdXBkYXRlIHRoZSBkb2N1bWVudCB3aXRoIHRoYXQg aW5mb3JtYXRpb24uCgpJcyB0aGVyZSBhIGRhdGFzaGVldCBJIGNhbiB2aWV3PwoKPiA+PiArTU1T WVMgaXMgYSBtdWx0aWZ1bmN0aW9uIGRldmljZSB3aXRoIHRoZSBmb2xsb3dpbmcgc3ViIG1vZHVs ZXM6Cj4gPj4gKy0gY2xvY2tzIGZvciB0aGUgbXVsdGktbWVkaWEgc3Vic3lzdGVtCj4gPj4gKy0g Y2VudHJhbCBub2RlIGZvciB0aGUgRFJNIHN1YnN5c3RlbS4KPiA+PiArCj4gPj4gK1RoaXMgZG9j dW1lbnQgZGVzY3JpYmVzIHRoZSBiaW5kaW5nIGZvciBNRkQgZGV2aWNlLiBUaGUgTUZEIHRha2Vz IGNhcmUgdG8gaW5pdGFpbGl6ZQo+ID4+ICt0aGUgY2xvY2sgZHJpdmVyIGFuZCB0aGUgRFJNIGRy aXZlci4gTW9yZSBpbmZvIHNlZQo+ID4+ICtEb2N1bWVudGF0aW9uL2RldmljZXRyZWUvYmluZGlu Z3MvZGlzcGxheS9tZWRpYXRlay9tZWRpYXRlayxkaXNwLnR4dAo+ID4+ICsKPiA+PiArUmVxdWly ZWQgcHJvcGVydGllczoKPiA+PiArLSBjb21wYXRpYmxlOiBTaG91bGQgYmUgb25lIG9mOgo+ID4+ ICsJLSAibWVkaWF0ZWssbXQyNzAxLW1tc3lzIiwgInN5c2NvbiIKPiA+PiArCS0gIm1lZGlhdGVr LG10ODE3My1tbXN5cyIsICJzeXNjb24iCj4gPj4gKy0gI2Nsb2NrLWNlbGxzOiBNdXN0IGJlIDEK PiA+PiArCj4gPj4gK09wdGlvbmFsIHByb3BlcnRpZXM6Cj4gPj4gKy0gcG93ZXItZG9tYWluczog bGlzdCBvZiBwb3dlcmRvbWFpbnMgbmVlZGVkIGZvciB0aGUgc3Vic3lzdGVtIHRvIHdvcmsKPiA+ PiArCj4gPj4gK0V4YW1wbGU6Cj4gPj4gKwo+ID4+ICttbXN5czogY2xvY2stY29udHJvbGxlckAx NDAwMDAwMCB7Cj4gPj4gKwljb21wYXRpYmxlID0gIm1lZGlhdGVrLG10ODE3My1tbXN5cyIsICJz eXNjb24iOwo+ID4+ICsJcmVnID0gPDAgMHgxNDAwMDAwMCAwIDB4MTAwMD47Cj4gPj4gKwlwb3dl ci1kb21haW5zID0gPCZzY3BzeXMgTVQ4MTczX1BPV0VSX0RPTUFJTl9NTT47Cj4gPj4gKwkjY2xv Y2stY2VsbHMgPSA8MT47Cj4gPj4gK307Cj4gPiAKCi0tIApMZWUgSm9uZXMgW+adjueQvOaWr10K TGluYXJvIFNlcnZpY2VzIFRlY2huaWNhbCBMZWFkCkxpbmFyby5vcmcg4pSCIE9wZW4gc291cmNl IHNvZnR3YXJlIGZvciBBUk0gU29DcwpGb2xsb3cgTGluYXJvOiBGYWNlYm9vayB8IFR3aXR0ZXIg fCBCbG9nCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCmRy aS1kZXZlbCBtYWlsaW5nIGxpc3QKZHJpLWRldmVsQGxpc3RzLmZyZWVkZXNrdG9wLm9yZwpodHRw czovL2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2RyaS1kZXZlbAo= From mboxrd@z Thu Jan 1 00:00:00 1970 From: lee.jones@linaro.org (Lee Jones) Date: Tue, 3 Jul 2018 08:04:16 +0100 Subject: [v3 01/10] dt-bindings: mediatek: mmsys: Add support for mfd In-Reply-To: <4ead47f6-2f69-2afa-bfcc-a240a9845dc4@gmail.com> References: <64ca273429d92f581568a48f3efe6035af65f579.1524820923.git.mbrugger@suse.com> <20180430103029.GD5147@dell> <4ead47f6-2f69-2afa-bfcc-a240a9845dc4@gmail.com> Message-ID: <20180703070416.GD20176@dell> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On Mon, 25 Jun 2018, Matthias Brugger wrote: > > > On 30/04/18 12:30, Lee Jones wrote: > > On Fri, 27 Apr 2018, matthias.bgg at kernel.org wrote: > > > >> From: Matthias Brugger > >> > >> Add binding description for the mmsys mfd for some Mediatek > >> devices. mmsys has some registers to control clock gates (which is > >> used in the clk driver) and some registers to set the routing and enable > >> the differnet blocks of the display subsystem. > >> > >> Signed-off-by: Matthias Brugger > >> --- > >> .../bindings/arm/mediatek/mediatek,mmsys.txt | 2 -- > >> .../bindings/display/mediatek/mediatek,disp.txt | 2 +- > >> .../devicetree/bindings/mfd/mediatek,mmsys.txt | 27 ++++++++++++++++++++++ > >> 3 files changed, 28 insertions(+), 3 deletions(-) > >> create mode 100644 Documentation/devicetree/bindings/mfd/mediatek,mmsys.txt > >> > >> diff --git a/Documentation/devicetree/bindings/arm/mediatek/mediatek,mmsys.txt b/Documentation/devicetree/bindings/arm/mediatek/mediatek,mmsys.txt > >> index 4eb8bbe15c01..4468345f8b1a 100644 > >> --- a/Documentation/devicetree/bindings/arm/mediatek/mediatek,mmsys.txt > >> +++ b/Documentation/devicetree/bindings/arm/mediatek/mediatek,mmsys.txt > >> @@ -6,10 +6,8 @@ The Mediatek mmsys controller provides various clocks to the system. > >> Required Properties: > >> > >> - compatible: Should be one of: > >> - - "mediatek,mt2701-mmsys", "syscon" > >> - "mediatek,mt2712-mmsys", "syscon" > >> - "mediatek,mt6797-mmsys", "syscon" > >> - - "mediatek,mt8173-mmsys", "syscon" > >> - #clock-cells: Must be 1 > >> > >> The mmsys controller uses the common clk binding from > >> diff --git a/Documentation/devicetree/bindings/display/mediatek/mediatek,disp.txt b/Documentation/devicetree/bindings/display/mediatek/mediatek,disp.txt > >> index 383183a89164..85a3b4ec06cd 100644 > >> --- a/Documentation/devicetree/bindings/display/mediatek/mediatek,disp.txt > >> +++ b/Documentation/devicetree/bindings/display/mediatek/mediatek,disp.txt > >> @@ -9,7 +9,7 @@ function block. > >> > >> All DISP device tree nodes must be siblings to the central MMSYS_CONFIG node. > >> For a description of the MMSYS_CONFIG binding, see > >> -Documentation/devicetree/bindings/arm/mediatek/mediatek,mmsys.txt. > >> +Documentation/devicetree/bindings/mfd/mediatek,mmsys.txt > >> > >> DISP function blocks > >> ==================== > >> diff --git a/Documentation/devicetree/bindings/mfd/mediatek,mmsys.txt b/Documentation/devicetree/bindings/mfd/mediatek,mmsys.txt > >> new file mode 100644 > >> index 000000000000..2331ae16917e > >> --- /dev/null > >> +++ b/Documentation/devicetree/bindings/mfd/mediatek,mmsys.txt > >> @@ -0,0 +1,27 @@ > >> +MediaTek MMSYS Multifunction Device Driver > > > > What is "MMSYS"? > > > > "Multi-Function Driver"s are specific to Linux. > > > > What actually is the device? > > It's includes all the DRM parts of the SoC together with the clocks for the > device. MMSYS IMHO stands for Multi-Media-System. Please update the document with that information. Is there a datasheet I can view? > >> +MMSYS is a multifunction device with the following sub modules: > >> +- clocks for the multi-media subsystem > >> +- central node for the DRM subsystem. > >> + > >> +This document describes the binding for MFD device. The MFD takes care to initailize > >> +the clock driver and the DRM driver. More info see > >> +Documentation/devicetree/bindings/display/mediatek/mediatek,disp.txt > >> + > >> +Required properties: > >> +- compatible: Should be one of: > >> + - "mediatek,mt2701-mmsys", "syscon" > >> + - "mediatek,mt8173-mmsys", "syscon" > >> +- #clock-cells: Must be 1 > >> + > >> +Optional properties: > >> +- power-domains: list of powerdomains needed for the subsystem to work > >> + > >> +Example: > >> + > >> +mmsys: clock-controller at 14000000 { > >> + compatible = "mediatek,mt8173-mmsys", "syscon"; > >> + reg = <0 0x14000000 0 0x1000>; > >> + power-domains = <&scpsys MT8173_POWER_DOMAIN_MM>; > >> + #clock-cells = <1>; > >> +}; > > -- Lee Jones [???] Linaro Services Technical Lead Linaro.org ? Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog